Page MenuHomePhabricator
Differential D13328

[lib] implement hook to send text message from `InputStateContainer
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 2:00 PM
Unknown Object (File)
Thu, Nov 7, 1:23 PM
Unknown Object (File)
Fri, Nov 1, 10:10 PM
Unknown Object (File)
Fri, Nov 1, 10:10 PM
Unknown Object (File)
Fri, Nov 1, 10:10 PM
Unknown Object (File)
Fri, Nov 1, 10:10 PM
Unknown Object (File)
Fri, Nov 1, 10:10 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
View All 46 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer
Summary

ENG-8424.

This code will handle both thick and thin threads, this is the point where we diverge logic, not in InputStateContainer on web and native.

Depends on D13327

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 13 2024, 4:05 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:05 AM
kamil added inline comments.Sep 13 2024, 4:06 AM
lib/hooks/input-state-container-hooks.js
74–76 ↗(On Diff #44141)
85–89 ↗(On Diff #44141)

not sure what is a better way of handling this without any

kamil added a child revision: D13329: [web][native] update `InputStateContainer` logic for sending text messages.Sep 13 2024, 4:12 AM
Harbormaster completed remote builds in B31596: Diff 44141.Sep 13 2024, 4:22 AM
kamil published this revision for review.Sep 13 2024, 4:39 AM
kamil mentioned this in D13331: [lib] implement hook to send text multimedia message from `InputStateContainer`.Sep 13 2024, 4:41 AM
tomek accepted this revision.Sep 13 2024, 6:53 AM
tomek added inline comments.
lib/hooks/input-state-container-hooks.js
85–89 ↗(On Diff #44141)

Can we use our ExtendableError?

This revision is now accepted and ready to land.Sep 13 2024, 6:53 AM
kamil updated this revision to Diff 44209.Sep 16 2024, 3:06 AM
  • rebase
  • fix comment
Harbormaster completed remote builds in B31637: Diff 44209.Sep 16 2024, 3:24 AM
kamil added inline comments.Sep 16 2024, 3:27 AM
lib/hooks/input-state-container-hooks.js
85–89 ↗(On Diff #44141)

created ENG-9277

Closed by commit rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer (authored by kamil). · Explain WhySep 16 2024, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb262440cd963: [lib] implement hook to send text message from `InputStateContainer.
ashoat mentioned this in D13432: [native] Add log for when all_thread_members is used for a thread missing from ThreadStore.Sep 23 2024, 10:18 PM
ashoat mentioned this in rCOMMda25916ca609: [native] Add log for when all_thread_members is used for a thread missing from….Sep 24 2024, 3:04 PM

Revision Contents
Changeset List

PathSize
lib/
hooks/
100 lines

Diff 44223

View Options

lib/hooks/input-state-container-hooks.js

Loading...