[lib] Only show reactions to viewer's messages in MessagePreview
Needs ReviewPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:47 AM.

Details

Reviewers

tomek

Summary

Part of addressing ENG-9556.

Depends on D13827

Test Plan

Tested in combination with the rest of the stack:

Make sure membership operations (user joining / leaving) don't appear in MessagePreview
Make sure reactions to the viewer's messages still appear in MessagePreview
Make sure reactions to other user's messages don't appear in MessagePreview
Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

lib/shared/messages/reaction-message-spec.js
234	I considered also hiding all "unreactions" (`remove_reaction`) as well, but I decided against it because it might accidentally result in the prior `add_reaction` message being shown, which would be misleading given it was reversed. Ideally we could have something like `fetchMessage` that would return all reactions on a message. But this would need to work for thin threads, which would require querying the keyserver.

ashoat requested review of this revision.Wed, Oct 30, 12:57 PM

Path

Size

lib/

shared/

messages/

14 lines