Page MenuHomePhabricator
Differential D13828

[lib] Only show reactions to viewer's messages in MessagePreview
AcceptedPublic
Actions

Authored by ashoat on Oct 30 2024, 11:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 5:16 AM
Unknown Object (File)
Wed, Nov 27, 2:53 AM
Unknown Object (File)
Mon, Nov 18, 3:56 PM
Unknown Object (File)
Sat, Nov 16, 2:21 AM
Unknown Object (File)
Sun, Nov 10, 10:17 PM
Unknown Object (File)
Sun, Nov 10, 6:54 AM
Unknown Object (File)
Thu, Nov 7, 12:30 PM
Unknown Object (File)
Thu, Nov 7, 6:44 AM
View All 20 Files
Subscribers
None

Details

Reviewers
tomek
Summary

Part of addressing ENG-9556.

Depends on D13827

Test Plan

Tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 30 2024, 11:47 AM
ashoat added a child revision: D13829: [lib] Hide membership robotext from MessagePreview in thin threads.
ashoat added inline comments.Oct 30 2024, 11:57 AM
lib/shared/messages/reaction-message-spec.js
234

I considered also hiding all "unreactions" (remove_reaction) as well, but I decided against it because it might accidentally result in the prior add_reaction message being shown, which would be misleading given it was reversed.

Ideally we could have something like fetchMessage that would return all reactions on a message. But this would need to work for thin threads, which would require querying the keyserver.

Harbormaster completed remote builds in B32445: Diff 45478.Oct 30 2024, 12:57 PM
ashoat requested review of this revision.Oct 30 2024, 12:57 PM
tomek accepted this revision.Thu, Oct 31, 5:57 AM
This revision is now accepted and ready to land.Thu, Oct 31, 5:57 AM
ashoat removed a parent revision: D13827: [lib] Introduce MessageSpec.showInMessagePreview.Thu, Oct 31, 11:09 AM
ashoat added a parent revision: D13831: [lib] Fetch older messages when showInMessagePreview rejects messages in local store.
ashoat mentioned this in D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.Tue, Nov 12, 12:46 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
14 lines

Diff 45478

View Options

lib/shared/messages/reaction-message-spec.js

Loading...