Page MenuHomePhabricator
Differential D13829

[lib] Hide membership robotext from MessagePreview in thin threads
AcceptedPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:50 PM
Unknown Object (File)
Wed, Nov 13, 8:40 AM
Unknown Object (File)
Sun, Nov 10, 9:55 PM
Unknown Object (File)
Sun, Nov 10, 12:46 PM
Unknown Object (File)
Sat, Nov 9, 10:57 PM
Unknown Object (File)
Fri, Nov 8, 1:19 AM
Unknown Object (File)
Thu, Nov 7, 10:26 PM
Unknown Object (File)
Thu, Nov 7, 7:43 PM
View All 22 Files
Subscribers
None

Details

Reviewers
tomek
Summary

Part of addressing ENG-9556.

This diff makes it so that in thin threads, we don't show robotext about users joining/leaving/being added/being removed in MessagePreview on both web and native.

Depends on D13828

Test Plan

Tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 30, 11:48 AM
ashoat added a child revision: D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
ashoat added inline comments.Wed, Oct 30, 11:58 AM
lib/shared/messages/add-members-message-spec.js
233

Flow didn't like when I tried checking params.threadInfo.thick instead

Harbormaster completed remote builds in B32446: Diff 45479.Wed, Oct 30, 1:05 PM
ashoat requested review of this revision.Wed, Oct 30, 1:05 PM
tomek accepted this revision.Thu, Oct 31, 6:06 AM
tomek added inline comments.
lib/shared/messages/add-members-message-spec.js
233

That's because only RawThreadInfo has this property. ThreadInfo doesn't have it.

This revision is now accepted and ready to land.Thu, Oct 31, 6:06 AM
ashoat removed a child revision: D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.Thu, Oct 31, 11:08 AM
ashoat added a child revision: D13910: [lib] Inline getMostRecentMessageInfo.Tue, Nov 12, 12:39 PM
ashoat mentioned this in D13919: [lib] Don't bump thin thread timestamp for membership robotext.Tue, Nov 12, 12:47 PM

Revision Contents
Changeset List

Diff 45479

View Options

lib/shared/messages/add-members-message-spec.js

Loading...
View Options

lib/shared/messages/join-thread-message-spec.js

Loading...
View Options

lib/shared/messages/leave-thread-message-spec.js

Loading...
View Options

lib/shared/messages/remove-members-message-spec.js

Loading...