Page MenuHomePhabricator

[backup-client] avoid adding `attachments` when uploading User Keys
ClosedPublic

Authored by kamil on Nov 14 2024, 8:03 AM.
Tags
None
Referenced Files
F3517607: D13928.id46005.diff
Sun, Dec 22, 5:55 PM
F3513504: D13928.id46005.diff
Sun, Dec 22, 12:25 AM
F3513503: D13928.id45818.diff
Sun, Dec 22, 12:25 AM
F3513447: D13928.id.diff
Sun, Dec 22, 12:24 AM
F3513423: D13928.diff
Sun, Dec 22, 12:24 AM
Unknown Object (File)
Thu, Dec 5, 2:04 PM
Unknown Object (File)
Thu, Dec 5, 9:29 AM
Unknown Object (File)
Thu, Dec 5, 1:16 AM
Subscribers

Details

Summary

ENG-9656.

On backup service, we parse multipart in sequence, so we're going to read attachments and as a result set siwe_backup_msg to None even if this is present.

The alternative is to completely refactor how we parse Multipart on the service side - but this is quick and clean, as attachments are present only if we have User Data.

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage