Page MenuHomePhabricator

[backup-client] avoid adding `attachments` when uploading User Keys
ClosedPublic

Authored by kamil on Nov 14 2024, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 12:33 PM
Unknown Object (File)
Thu, Apr 3, 9:57 AM
Unknown Object (File)
Thu, Apr 3, 7:43 AM
Unknown Object (File)
Wed, Apr 2, 12:44 PM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Feb 28 2025, 2:56 AM
Unknown Object (File)
Feb 28 2025, 2:56 AM
Subscribers

Details

Summary

ENG-9656.

On backup service, we parse multipart in sequence, so we're going to read attachments and as a result set siwe_backup_msg to None even if this is present.

The alternative is to completely refactor how we parse Multipart on the service side - but this is quick and clean, as attachments are present only if we have User Data.

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage