[backup-client][native_rust_library] update backup client to run cleanup on any failure
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:17 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMMc935e7cacce2: [backup-client][native_rust_library] update backup client to run cleanup on any…

Summary

ENG-9656.

Previously, we ran cleanup only if the final stage failed, potentially leaving some files in storage - this diff fixes this and attempt cleanup on each failure.

Depends on D13929

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

publish-client-backup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 14 2024, 8:17 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 8:17 AM

kamil added a child revision: D13931: [backup-client][native_rust_library] implement creating User Keys backup.Nov 14 2024, 8:22 AM

Harbormaster completed remote builds in B32661: Diff 45820.Nov 14 2024, 9:52 AM

kamil published this revision for review.Nov 15 2024, 2:21 AM

bartek accepted this revision.Nov 19 2024, 5:41 AM

This revision is now accepted and ready to land.Nov 19 2024, 5:41 AM

Closed by commit rCOMMc935e7cacce2: [backup-client][native_rust_library] update backup client to run cleanup on any… (authored by kamil). · Explain WhyNov 25 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc935e7cacce2: [backup-client][native_rust_library] update backup client to run cleanup on any….

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup.rs

12 lines

Diff 45820

View Options

native/native_rust_library/src/backup.rs

[backup-client][native_rust_library] update backup client to run cleanup on any failureClosedPublicActions