Page MenuHomePhabricator

[lib] standarize broadcasting device list update when removing device
AcceptedPublic

Authored by kamil on Wed, Nov 20, 3:05 AM.
Tags
None
Referenced Files
F3332967: D13972.id45894.diff
Thu, Nov 21, 3:02 AM
F3328597: D13972.id45894.diff
Wed, Nov 20, 2:07 PM
F3328583: D13972.id.diff
Wed, Nov 20, 2:06 PM
F3328577: D13972.diff
Wed, Nov 20, 2:06 PM
Subscribers

Details

Reviewers
bartek
ashoat
Summary

Addressing https://phab.comm.dev/D13963#inline-78590 and https://phab.comm.dev/D13963#inline-78595.

Right now we have the same approach each time:

  1. Sending device list updates to all our peers
  2. Sending device list updates to all our devices that are on the device list, but without the primary device
  3. Call getAndUpdateDeviceListsForUsers for our userID
    • update AuxUserStore
    • get platform details if the device was added

Depends on D13963

Test Plan

Remove secondary device and test if other peers received device list update

Diff Detail

Repository
rCOMM Comm
Branch
secondary-auth
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Wed, Nov 20, 3:10 AM
kamil edited the summary of this revision. (Show Details)
lib/shared/device-list-utils.js
345

We could consider extracting this outside the if branches since it's shared across all branches

356

Same with this line

This revision is now accepted and ready to land.Wed, Nov 20, 4:23 AM