[backup-client] set `backupID` after uploading User Keys
ClosedPublic
Actions

Authored by kamil on Nov 22 2024, 10:19 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM80e355759ad2: [backup-client] set `backupID` after uploading User Keys

Summary

Part of ENG-9656

We're going to store this in Redux too, but it's needed for native backup logic and was previously implemented for uploading User Data compaction, adding this for User Keys too.

Depends on D14000

Test Plan

Tested creating backup and secondary device login

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 22 2024, 10:19 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 22 2024, 10:19 AM

kamil added a child revision: D14002: [CommCoreModule] avoid calling Backup Service to get backup secrets.Nov 22 2024, 10:23 AM

Harbormaster failed remote builds in B32762: Diff 45938!Nov 22 2024, 10:44 AM

rebase

Harbormaster completed remote builds in B32765: Diff 45941.Nov 22 2024, 11:14 AM

kamil published this revision for review.Nov 22 2024, 12:01 PM

bartek accepted this revision.Nov 25 2024, 1:27 PM

This revision is now accepted and ready to land.Nov 25 2024, 1:27 PM

Closed by commit rCOMM80e355759ad2: [backup-client] set `backupID` after uploading User Keys. · Explain WhyDec 3 2024, 2:28 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM80e355759ad2: [backup-client] set `backupID` after uploading User Keys.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

PersistentStorageUtilities/

BackupOperationsUtilities/

BackupOperationsExecutor.h

1 line

BackupOperationsExecutor.cpp

15 lines

native_rust_library/

RustBackupExecutor.h

1 line

RustBackupExecutor.cpp

4 lines

src/

backup.rs

9 lines

lib.rs

3 lines

Diff 45941

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.h

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.cpp

View Options

native/native_rust_library/RustBackupExecutor.h

View Options

native/native_rust_library/RustBackupExecutor.cpp

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/lib.rs

[backup-client] set `backupID` after uploading User KeysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45941

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.cpp

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/backup.rs

native/native_rust_library/src/lib.rs

[backup-client] set `backupID` after uploading User Keys
ClosedPublic
Actions

Revision Contents
Changeset List