Page MenuHomePhabricator

[backup-client][native] refactor restoring logic and deprecate `restoreBackup`
ClosedPublic

Authored by kamil on Nov 22 2024, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 2:46 AM
Unknown Object (File)
Fri, Dec 13, 1:32 AM
Unknown Object (File)
Wed, Dec 11, 2:53 AM
Unknown Object (File)
Wed, Dec 4, 9:34 AM
Unknown Object (File)
Sat, Nov 30, 6:48 AM
Unknown Object (File)
Sat, Nov 30, 4:46 AM
Unknown Object (File)
Fri, Nov 29, 8:59 AM
Unknown Object (File)
Fri, Nov 29, 8:27 AM
Subscribers

Details

Summary

Part of ENG-9656

This was introduced mostly for testing purposes, there is no need to restore everything at once, we need to:

  1. Restore Backup Data on Secondary Device Auth
  2. Download User Keys to be able to decrypt data and sign a new device list using the old account, and then separately restore only Backup Data during the Restore protocol

We can test it as it should be (later in the stack), but this code is now hard to maintain, and keeping this adds a lot of additional and not needed work.

Depends on D14003

Test Plan

N/A, removing testing code and simplify logic, functionality tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Nov 22 2024, 4:01 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
native/backup/restore-siwe-backup.react.js
40–50
native/profile/backup-menu.react.js
72–82
This revision is now accepted and ready to land.Nov 26 2024, 1:51 AM