[CommCoreModule] sign message with custom Olm Account
ClosedPublic
Actions

Authored by kamil on Nov 26 2024, 6:07 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM45130c2f0341: [CommCoreModule] sign message with custom Olm Account

Summary

ENG-9603.

Needed to sign a new device list with the old primary device account.

This doesn't need to be scheduled on cryptoThread because it is using the ephemeral CryptoModule, but perhaps it's better to keep it similar to all crypto-related operations and use a dedicated thread.

Depends on D14045

Test Plan

Tested in next diff in the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 26 2024, 6:07 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 26 2024, 6:07 AM

kamil edited the summary of this revision. (Show Details)Nov 26 2024, 6:07 AM

kamil added a child revision: D14047: [native] make it possible to test signing using Olm Account from User Keys.Nov 26 2024, 6:08 AM

kamil retitled this revision from [CommCoreModule] sing message with custom Olm Account to [CommCoreModule] sign message with custom Olm Account.Nov 26 2024, 6:17 AM

kamil published this revision for review.Nov 26 2024, 6:45 AM

Harbormaster completed remote builds in B32864: Diff 46079.Nov 26 2024, 8:30 AM

bartek accepted this revision.Nov 27 2024, 1:31 AM

This revision is now accepted and ready to land.Nov 27 2024, 1:31 AM

Closed by commit rCOMM45130c2f0341: [CommCoreModule] sign message with custom Olm Account (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM45130c2f0341: [CommCoreModule] sign message with custom Olm Account.