Page MenuHomePhabricator

[native] make it possible to test signing using Olm Account from User Keys
AcceptedPublic

Authored by kamil on Tue, Nov 26, 6:08 AM.
Tags
None
Referenced Files
F3389892: D14047.id46080.diff
Fri, Nov 29, 8:57 PM
F3387756: D14047.diff
Fri, Nov 29, 11:01 AM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Tue, Nov 26, 8:52 PM
Subscribers

Details

Reviewers
bartek
tomek
Summary

ENG-9603.

This is a test case and an example of how to use it, probably this code can be updated, exported, and used in Restore Flow later (cc. @tomek).

This is a real-life use case because we take the previous Primary Device deviceID from the device list history, then sign the message using Olm Account from Backup without extracting deviceID, and use deviceID from the device list to verify — so if this passes verification, both device list history and User Keys upload/download/crypto operations work together.

Depends on D14046

Test Plan

Perform what is explained in test case

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
native/backup/restore-siwe-backup.react.js
52–60

The old code is wrong - I mentioned this here

native/profile/backup-menu.react.js
197–211
kamil retitled this revision from [native] make it possible to test singing using Olm Account from User Keys to [native] make it possible to test signing using Olm Account from User Keys.Tue, Nov 26, 6:17 AM
kamil published this revision for review.Tue, Nov 26, 6:45 AM
bartek added inline comments.
native/profile/backup-menu.react.js
335–337 ↗(On Diff #46081)

I was thinking about a note e.g. "see code comments" but not sure if it's worth it. Only us will be using it and this test button i going to be removed when the feature is released

This revision is now accepted and ready to land.Fri, Nov 29, 2:20 AM