Page MenuHomePhabricator
Differential D13914

[lib] Extract getSidebarItems
ClosedPublic
Actions

Authored by ashoat on Nov 12 2024, 12:42 PM.
Tags
None
Referenced Files
F3513917: D13914.diff
Sun, Dec 22, 2:32 AM
Unknown Object (File)
Wed, Dec 18, 6:20 PM
Unknown Object (File)
Wed, Dec 18, 6:20 PM
Unknown Object (File)
Wed, Dec 18, 6:19 PM
Unknown Object (File)
Wed, Dec 18, 6:19 PM
Unknown Object (File)
Wed, Dec 18, 6:04 PM
Unknown Object (File)
Wed, Dec 18, 4:14 PM
Unknown Object (File)
Wed, Dec 18, 4:13 PM
View All 43 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM381a55bb9bb9: [lib] Extract getSidebarItems
rCOMM481690308381: [lib] Extract getSidebarItems
Summary

This will make a following diff a little easier.

Depends on D13913

Test Plan

Flow. Also tested in combination with the rest of the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 12 2024, 12:42 PM
ashoat added a child revision: D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
ashoat updated this revision to Diff 45768.Nov 12 2024, 12:56 PM

Rebase

Harbormaster failed remote builds in B32625: Diff 45761!Nov 12 2024, 1:09 PM
Harbormaster completed remote builds in B32632: Diff 45768.Nov 12 2024, 2:18 PM
ashoat requested review of this revision.Nov 12 2024, 2:18 PM
tomek accepted this revision.Nov 13 2024, 4:13 AM
This revision is now accepted and ready to land.Nov 13 2024, 4:13 AM
Closed by commit rCOMM481690308381: [lib] Extract getSidebarItems (authored by ashoat). · Explain WhyNov 13 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM481690308381: [lib] Extract getSidebarItems.
ashoat added a reverting change: rCOMMd5b919ba29cf: Revert "[lib] Extract getSidebarItems".Tue, Dec 10, 8:24 AM
ashoat reopened this revision.Tue, Dec 10, 8:24 AM
This revision is now accepted and ready to land.Tue, Dec 10, 8:24 AM
ashoat updated this revision to Diff 46292.Tue, Dec 10, 8:27 AM

Rebase

Harbormaster completed remote builds in B32986: Diff 46292.Tue, Dec 10, 8:57 AM
Closed by commit rCOMM381a55bb9bb9: [lib] Extract getSidebarItems (authored by ashoat). · Explain WhyFri, Dec 13, 6:13 AM
This revision was automatically updated to reflect the committed changes.
Ashoat Tevosyan <ashoat@gmail.com> added a commit: rCOMM381a55bb9bb9: [lib] Extract getSidebarItems.

Revision Contents
Changeset List

PathSize
lib/
selectors/
63 lines
shared/
68 lines
6 lines

Diff 46432

View Options

lib/selectors/chat-selectors.js

Loading...
View Options

lib/shared/sidebar-item-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...