Page MenuHomePhabricator

[android] Implement hasMultipleFrames() function on Android
ClosedPublic

Authored by angelika on Thu, Mar 20, 4:38 AM.
Tags
None
Referenced Files
F5114222: D14472.id47483.diff
Wed, Apr 2, 7:39 AM
F5111000: D14472.id47599.diff
Wed, Apr 2, 2:07 AM
F5107071: D14472.id47598.diff
Tue, Apr 1, 10:18 AM
Unknown Object (File)
Tue, Apr 1, 1:12 AM
Unknown Object (File)
Mon, Mar 31, 1:05 PM
Unknown Object (File)
Mon, Mar 31, 11:02 AM
Unknown Object (File)
Sun, Mar 30, 5:38 PM
Unknown Object (File)
Sun, Mar 30, 1:40 PM
Subscribers

Details

Summary
Test Plan

Try to send a gif with animation and without animation and verify that the function returns correct result.
Set mediaType to 'photo_or_video' for gifs in order to trigger the check.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika held this revision as a draft.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91

Movie is deprecated but AnimatedImageDrawable is available only for Android 9+. According to our build.gradle we're supporting Android 8.0+ so I put both versions and a check here.

bartek added inline comments.
native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt
91

👍

This revision is now accepted and ready to land.Fri, Mar 21, 1:51 AM