Paths

Table of Contentst

Differential D14571

[CommCoreModule][SQLite] remove unused JSI calls
ClosedPublic
Actions

Authored by kamil on Apr 11 2025, 12:51 PM.

Tags

None

Referenced Files

	F32359748: D14571.1765320452.diff
	Mon, Dec 8, 10:47 PM

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls

Summary

There are some calls that are unused now and won't be in the future. Removing them to avoid unnecessary maintenance of dead code.

Depends on D14570

Test Plan

Build native app

Diff Detail

Repository

Branch

poc

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 11 2025, 12:51 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 11 2025, 12:51 PM

Harbormaster completed remote builds in B33968: Diff 47753.Apr 11 2025, 1:08 PM

kamil edited the summary of this revision. (Show Details)Apr 11 2025, 1:54 PM

kamil added a parent revision: D14570: [SQLite][native] introduce `SQLiteUtils` class.

kamil edited the summary of this revision. (Show Details)Apr 11 2025, 3:04 PM

kamil published this revision for review.Apr 11 2025, 3:07 PM

kamil added inline comments.

native/schema/CommCoreModuleSchema.js
39–43	we have ops for it now
146–147	No need to store Notif device token in SQLite
160	This is called as part of `clearSensitiveData`
161–162	We should use `setCommServicesAuthMetadata` and `getCommServicesAuthMetadata` to handle all auth metadata at once

kamil added a child revision: D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.Apr 11 2025, 3:09 PM

tomek accepted this revision.Apr 14 2025, 8:37 AM

This revision is now accepted and ready to land.Apr 14 2025, 8:37 AM

Closed by commit rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls. · Explain WhyApr 14 2025, 10:12 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

2 lines

SQLiteQueryExecutor.h

2 lines

SQLiteQueryExecutor.cpp

8 lines

NativeModules/

CommCoreModule.h

12 lines

CommCoreModule.cpp

182 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

8 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 47753

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...