rebase

rebase

rebase

rebase

rebase

fix type and move capitalizing header into parent component

Fixes after review & capitalize headers

replace alertTitle with alertText and change css class name to label

rebase, convert set to array

replace array of users with set and changed button types.

Add missing useMemo and make the component more readable

Follow comments after review

Updates following review comments

remove redundant variable

Excluded overridable Modal props into separate type

Fixes after Tomek's review

Isn't the screenshot in the diff description from some other task?

Allow passing other Modal parameters

rebase

rebase

rebase

Introduce generating UUIDs as keys for modals

In D3665#101474, @palys-swm wrote:

Not sure if you've done that, but we need to confirm one thing: there's a significant difference between calling setModal and pushModal when calling it multiple times. setModal would render the same modal again but push will add its copy. So please check all the calls to pushModal and confirm that each user action / function call would result in at most one call to the function. If we call it from an effect (even indirectly) it might be an indication that we have some issues.

@benschac please take a look at my last comment in D3678. The initial solution seems to be ok - it was my mistake. Really sorry for that

The issue I had using useEffect is presented on video below:

The problem source was, that we were calling renderMenu before updatePosition, which was called in useEffect, so the position was correctly set after in the next render, so the menu was shown in a position of previously rendered menu for a short period of time (it was nondeterministic and happened only from time to time, as it's in the video). The solution was to execute effect with updatePosition synchronously, so the position was updated in the same render which contains calling renderMenu.

I disagree with the summary:

useLayoutEffect isn't needed here.

@benschac for what reasons was such a conclusion made?

rebase

The color picker looks cool!
Suggested some small fixes

fix missed problems caused by rebase

rebase

rebase

rebase

rebase

rebase

rebase & use single plural form

Moved code as suggested and fix typo