Feed Search

Search
Use Results
Edit Query
Hide Query

Mar 1 2023

atul added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.

While I agree that it might be better database design to create a separate table, it will complicate things on the SQLite side.

Mar 1 2023, 6:05 PM

atul requested review of D6916: [native][keyserver] Persist `signedIdentityKeysBlob` on `register` from `native`.

Mar 1 2023, 5:12 AM

atul updated the test plan for D6915: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth` requests.

Mar 1 2023, 4:44 AM

atul updated the test plan for D6915: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth` requests.

Mar 1 2023, 4:06 AM

atul updated the test plan for D6915: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth` requests.

Mar 1 2023, 4:04 AM

atul requested review of D6915: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth` requests.

Mar 1 2023, 4:02 AM

Feb 28 2023

atul committed rCOMMefe0e21baa66: Revert "Temporary changes for staff release".

Feb 28 2023, 10:31 PM

atul committed rCOMMffe0c349f5fa: [native] `codeVersion` -> 192.

Feb 28 2023, 10:31 PM

atul committed rCOMM34706ec8919d: Temporary changes for staff release.

Feb 28 2023, 10:31 PM

atul committed rCOMM46ebe66ea772: [native] `codeVersion` -> 191.

Feb 28 2023, 10:31 PM

atul abandoned D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.

Feb 28 2023, 7:13 AM

atul abandoned D6172: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.

Feb 28 2023, 7:12 AM

atul closed D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.

Feb 28 2023, 3:52 AM

atul committed rCOMMadcf374c60af: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement….

Feb 28 2023, 3:52 AM

atul updated the diff for D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.

rebase + land

Feb 28 2023, 3:51 AM

atul closed D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

Feb 28 2023, 3:50 AM

atul committed rCOMMe24fd69b5b83: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

Feb 28 2023, 3:50 AM

atul updated the diff for D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

rebase + land

Feb 28 2023, 3:49 AM

atul closed D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

Feb 28 2023, 3:47 AM

atul committed rCOMMde9ea3310c90: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

Feb 28 2023, 3:47 AM

atul updated the diff for D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

rebase + land

Feb 28 2023, 3:46 AM

atul published D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey` for review.

Feb 28 2023, 3:34 AM

atul published D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth` for review.

Feb 28 2023, 3:14 AM

atul attached a referenced file: F404710: 52524c.png.

Feb 28 2023, 1:49 AM

atul published D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login` for review.

Feb 28 2023, 1:49 AM

atul closed D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

Feb 28 2023, 1:29 AM

atul committed rCOMMb3a783e613e6: [keyserver] Replace `public_key` column with `signed_identity_keys` in….

Feb 28 2023, 1:29 AM

atul updated the diff for D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

rebase + land

Feb 28 2023, 1:28 AM

atul closed D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.

Feb 28 2023, 12:51 AM

atul committed rCOMMca5a871c35cd: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth`….

Feb 28 2023, 12:51 AM

atul updated the diff for D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.

rebase + land

Feb 28 2023, 12:51 AM

atul added a comment to D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

In D6907#205331, @ashoat wrote:

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

Feb 28 2023, 12:36 AM

atul added inline comments to D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

Feb 28 2023, 12:09 AM

atul published D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table for review.

Feb 28 2023, 12:08 AM

Feb 27 2023

atul published D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints for review.

Feb 27 2023, 11:44 PM

atul closed D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.

Feb 27 2023, 11:32 PM

atul committed rCOMMe2ca77f62c9d: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.

Feb 27 2023, 11:32 PM

atul updated the diff for D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.

rebase + land

Feb 27 2023, 11:22 PM

atul closed D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start.

Feb 27 2023, 11:20 PM

atul committed rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`….

Feb 27 2023, 11:20 PM

atul updated the diff for D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start.

rebase + land

Feb 27 2023, 11:20 PM

atul closed D6900: [keyserver] Introduce `OLMUtility` type.

Feb 27 2023, 11:16 PM

atul committed rCOMM4895ba2d1a3e: [keyserver] Introduce `OLMUtility` type.

Feb 27 2023, 11:16 PM

atul updated the diff for D6900: [keyserver] Introduce `OLMUtility` type.

rebase + land

Feb 27 2023, 11:16 PM

atul closed D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

Feb 27 2023, 11:15 PM

atul committed rCOMM76c64df43f92: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

Feb 27 2023, 11:15 PM

atul updated the diff for D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

rebase + land

Feb 27 2023, 11:13 PM

atul added inline comments to D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.

Feb 27 2023, 10:15 PM

atul retitled D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request from [keyserver] No longer persist `primaryIdentityPublicKey` from `login` request

Feb 27 2023, 10:14 PM

atul published D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request for review.

Feb 27 2023, 10:14 PM

atul updated the test plan for D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start.

Feb 27 2023, 9:59 PM

atul updated the diff for D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start.

annotate

Feb 27 2023, 9:59 PM

atul published D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start for review.

Feb 27 2023, 9:59 PM

atul added a comment to D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

Thought the approach here was cleaner: https://phab.comm.dev/D6901

Feb 27 2023, 9:58 PM

atul published D6900: [keyserver] Introduce `OLMUtility` type for review.

Feb 27 2023, 9:42 PM

atul added a comment to D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

In D6897#205161, @ashoat wrote:

this can be landed without issue

Did you test calling await olm.init() multiple times?

Feb 27 2023, 9:33 PM

atul requested review of D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

The reason this diff is titled [DRAFT] is because of the way we're calling olm.init() and new olm.Utility() every time logInResponder encounters a request with signedIdentityKeysBlob. Instead we'll want to probably run olm.init() once when keyserver starts up, and we'll want to instantiate olm.Utility() once and make it accessible globally.

Feb 27 2023, 9:28 PM

atul retitled D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder` from [DRAFT] Verify `signedIdentityKeysBlob` signature in `logInResponder`

Feb 27 2023, 9:27 PM

atul added a comment to D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

We could probably just have a function getOlmUtility that returns a Promise that does lines 345 and 346 here, and caches the result.

Feb 27 2023, 8:40 PM

atul accepted D6887: [desktop] Allow building with a provisioning profile.

Feb 27 2023, 3:27 PM

atul accepted D6722: [Android] Reference Tools by CMake project.

Feb 27 2023, 3:26 PM

atul accepted D6822: Sign concatenation of public and notif keypairs using private key of public identity.

Feb 27 2023, 3:25 PM

atul accepted D6781: Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.

Feb 27 2023, 3:24 PM

atul closed D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

Feb 27 2023, 2:03 AM

atul committed rCOMM0e56a7857d8c: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

Feb 27 2023, 2:03 AM

atul updated the diff for D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

rebase + land

Feb 27 2023, 2:02 AM

atul added a comment to D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

PS looks like a missing screenshot in the Test Plan.

Feb 27 2023, 1:54 AM

atul closed D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator`.

Feb 27 2023, 1:45 AM

atul committed rCOMM27c3ce790fd9: [keyserver] Add `signedIdentityKeysBlobValidator` to….

Feb 27 2023, 1:45 AM

atul updated the diff for D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator`.

rebase + land

Feb 27 2023, 1:38 AM

atul updated the test plan for D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

Feb 27 2023, 1:18 AM

Feb 25 2023

atul accepted D6874: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient.

Feb 25 2023, 9:38 AM

atul requested review of D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

Feb 25 2023, 9:34 AM

atul accepted D6873: [keyserver][lib] Pass notifTargetUserInfo to notificationTexts.

Feb 25 2023, 9:31 AM

atul accepted D6872: [keyserver] Update notif prepare functions to take bag of params.

Feb 25 2023, 7:51 AM

atul accepted D6871: [keyserver] Make sure we fetch username of all notif recipients.

Feb 25 2023, 7:50 AM

atul accepted D6870: [lib] Add invariant to SidebarSource notificationTexts.

Feb 25 2023, 7:50 AM

atul accepted D6869: [lib] Collapse CreateSidebar and SidebarSource notifs together.

Feb 25 2023, 7:50 AM

atul accepted D6868: [lib] Allow multiple messages in CreateSidebar notificationTexts.

Feb 25 2023, 7:50 AM

atul requested review of D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.

Feb 25 2023, 7:46 AM

atul published D6895: [keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator` for review.

Feb 25 2023, 7:09 AM

Feb 24 2023

atul closed D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob`.

Feb 24 2023, 10:39 PM

atul committed rCOMM6fbcb6ddc7d6: [web] "Unpickle" primary OLM account to sign keys and get….

Feb 24 2023, 10:39 PM

atul closed D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.

Feb 24 2023, 10:39 PM

atul closed D6882: [web] Add `PickledOLMAccount`s to Redux `CryptoStore`.

Feb 24 2023, 10:39 PM

atul committed rCOMM6151beabc857: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.

Feb 24 2023, 10:39 PM

atul committed rCOMM4857a25e20f0: [web] Add `PickledOLMAccount`s to Redux `CryptoStore`.

Feb 24 2023, 10:39 PM

atul closed D6881: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in `TraditionalLoginForm`.

Feb 24 2023, 10:39 PM

atul closed D6879: [web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys`.

Feb 24 2023, 10:39 PM

atul committed rCOMMacbfdb96925c: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in….

Feb 24 2023, 10:39 PM

atul closed D6880: [web] Update `primaryIdentityPublicKey[s]` selector to capture `primaryIdentityPublicKeys`.

Feb 24 2023, 10:39 PM

atul committed rCOMM0d877e8557ff: [web] Update `primaryIdentityPublicKey[s]` selector to capture….

Feb 24 2023, 10:39 PM

atul committed rCOMM5e9a5a925a98: [web] Update `LoginForm` `useEffect` early-exit logic to include….

Feb 24 2023, 10:39 PM

atul closed D6878: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`.

Feb 24 2023, 10:39 PM

atul closed D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.

Feb 24 2023, 10:39 PM

atul committed rCOMM21d6d9f1bfa1: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`.

Feb 24 2023, 10:39 PM

atul committed rCOMMad4b46f367ab: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.

Feb 24 2023, 10:39 PM

atul closed D6876: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`.

Feb 24 2023, 10:39 PM

atul committed rCOMM4a16ce09e722: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`.

Feb 24 2023, 10:39 PM

atul updated the diff for D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.

merge conflict

Feb 24 2023, 10:29 PM