Looks like a fairly straightforward refactor
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 14 2023
Jun 14 2023
atul requested review of D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
rebase and land
Thanks for addressing feedback
atul added a reviewer for D8200: [keyserver] Prevent the only admin role from being changed on the keyserver: ashoat.
Adding @ashoat as blocking here to take another look
Looks good, thanks for linking successful workflow
Jun 12 2023
Jun 12 2023
trigger blob unit tests
atul requested changes to D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Can we show a spinner when the request is in progress? It's probably pretty "instant" in your dev environment, but could look janky on prod if things are frozen until the request completes.
Requesting changes for changes suggested by @ashoat.
atul requested changes to D8156: [native] Create a new screen that will show the role change information.
Requesting changes for letterSpacing justification. Also adding @ginsu as blocking to take a look at showActionSheet(...), specifically how it behaves "across platforms."
Was removing "Remove admin" and "Make admin" options also intended to be a part of this diff? Didn't see anything in the title or summary so just want to make sure before this diff is accepted.
(We're also ensuring that this isn't possible from the keyserver side, right?)
Seems a little weird to me from a product standpoint, but code looks correct.
(Restarted failing iOS build)
atul added a comment to D8114: Provided detailed error messages on olm functions failures in CryptoModule.
(Restarted failing iOS build)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
(Shellcheck CI job should pass after pulling in latest changes.)
Can you pull in latest changes before landing and ensure CI checks pass
Trusting the numbers, would be good if there was a comment explaining where the numbers come from
Jun 9 2023
Jun 9 2023
atul retitled D8138: [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons) from [web] Create a model that allows admins to change a member's role (dropdown menu, actionable buttons)
If you'd prefer I can remove the import in the previous diff instead
atul added 1 blocking reviewer(s) for D8136: [web] Implement a custom dropdown menu component: ginsu.
Requesting changes for clarification on memberIsAdmin import change.
Thanks for the annotations
If the avatar upload fails, we'll log the user in anyways, and display an error Alert. The user can then go and change their avatar using the normal flow. I opted for this approach because I figured trying to "undo" the registration would be more complicated, and leaving the registration in a half-complete state would be confusing to the user.
Jun 8 2023
Jun 8 2023
rebase and land
atul updated the diff for D8130: [native] Navigate to newly created community after successful creation.
rebase and land
atul updated the diff for D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
address feedback
atul updated the diff for D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.
rebase and land
Jun 7 2023
Jun 7 2023
Had to change text encoding in Phabricator to "see the difference," but looks good.
Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.
Label having a bg prop that expects a CSS variable is a weird API. Is there a way we can introduce a variant prop to Label instead and style accordingly within?
atul added inline comments to D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Accepting, but please take a look at the trailing space
Jun 6 2023
Jun 6 2023
whoa this looks smooth, first rotation animation?
atul updated the diff for D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
rebase and alnd
atul published D8130: [native] Navigate to newly created community after successful creation for review.