Thanks for making this followup diff
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 26 2023
Jun 26 2023
atul committed rCOMMe1a40d1ec5df: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/blob (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMe031dbf6fe9a: Bump openssl from 0.10.52 to 0.10.55 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM0668a19b4ec7: Bump openssl from 0.10.48 to 0.10.55 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMae6731c26eeb: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/backup (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM30c9bad44198: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/feature-flags (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMfd170f6645ae: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/comm-services-lib (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM92f8d092e271: Bump aws-sigv4 from 0.54.1 to 0.54.2 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Seems right at a high level, adding @ashoat as blocking to take a look at babel-plugin-transform-import-meta dependency and related changes.
Was this based off of comm-icon-config.json from the repo?
Looks good, thanks for taking care of this. Let's re-run CI before landing.
Jun 23 2023
Jun 23 2023
rebase before landing
atul updated the diff for D8287: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab.
rebase before landing
rebase before landing
rebase before landing
atul updated the diff for D8283: [web] Consolidate `errorMessage` and `updateSuccessful` state in `EmojiAvatarSelectionModal`.
rebase before landing
rebase before landing
rebase before landing
atul updated the diff for D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.
rebase and land
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
address feedback
rebase
Landing, but @ashoat should take a look when he's back since it's regarding dependencies.
rebase and land
In D8297#244953, @tomek wrote:Bumping the version looks ok, but it seems to break iOS build
Jun 22 2023
Jun 22 2023
rebase before addressing @rohan's feedback
rebase before landing
rebase before landing
rebase before landing
remove patch
land this once Android CI passes
In D8296#244671, @bartek wrote:I wonder if we need fresco as direct dependency... Do we use it anywhere outside expo-image? I think it's some leftovers from old expo.
Expo-image docs don't mention any additional gradle steps: https://github.com/expo/expo/tree/sdk-48/packages/expo-image#installationAnyway, accepting for now, feel free to either experiment with removing these deps or just land this once Android CI passes
atul added 1 blocking reviewer(s) for D8269: [web] Wrap modals with `WebEditUserAvatarProvider`: ginsu.
Adding @ginsu since he introduced the equivalent provider on native.
atul added 1 blocking reviewer(s) for D8268: [web] Add emoji `Picker` to `EmojiAvatarSelectionModal`: ginsu.
Adding @ginsu as blocking since he's worked w/ Picker component
Maybe next code version?
atul added inline comments to D8264: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`.
undefined -> null
atul updated the diff for D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.
undefined -> null
In D8263#244474, @kamil wrote:The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.
Can you link it?
Jun 21 2023
Jun 21 2023
update min-height to account for tabBody padding
atul published D8287: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab for review.