Removed reviewers since this is a "draft" diff
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Aug 22 2023
Aug 22 2023
ginsu added inline comments to D8893: DRAFT: [native] fix forcing message height breaking message timestamp.
ginsu updated the test plan for D8893: DRAFT: [native] fix forcing message height breaking message timestamp.
ginsu added a comment to D8893: DRAFT: [native] fix forcing message height breaking message timestamp.
ginsu updated the test plan for D8893: DRAFT: [native] fix forcing message height breaking message timestamp.
ginsu retitled D8893: DRAFT: [native] fix forcing message height breaking message timestamp from [native] fix forcing message height breaking message timestamp
ginsu requested review of D8893: DRAFT: [native] fix forcing message height breaking message timestamp.
Aug 18 2023
Aug 18 2023
ginsu updated the test plan for D8860: [web] introduce getTooltipScreenOverflowRightCorrection function.
adjust padding
ginsu requested review of D8861: [native/web] change title of MessageReactionsModal to All reactions.
update
rebase
Aug 17 2023
Aug 17 2023
memoize viewStyle
ginsu added 1 blocking reviewer(s) for D8827: [web] convert createTooltip to getTooltipPositionStyle: atul.
would prefer if someone more familiar with the tooltip could confirm
LGTM, also you can disregard my comment on D8840 since there is a screenshot/demo here to watch.
Code looks good, it would be helpful to get a screenshot of EditThreadAvatarMenu even if it's barebones since we are introducing the component here
ginsu retitled D8823: [web] introduce ReactionTooltip component from DRAFT: [web] introduce ReactionTooltip component
update
address comments
update
update
use messageItemHeight
simplify height forcing logic
Removing this from reviewers queue until I confirm my comment above
Where did we factor in failedSendHeight in the code before your changes?
Aug 16 2023
Aug 16 2023
There are no reviewers specified – is this one a draft too?
ginsu added reviewers for D8828: [web] move getTooltipPositionStyle into tooltip-utils: atul, kamil.
ginsu requested review of D8831: [web] update calculateMaxTextWidth to consider different font sizes.
ginsu updated the summary of D8810: [web] show which reactions the viewer has already selected in the inline engagement.
Aug 15 2023
Aug 15 2023
ginsu added inline comments to D8822: [landing] decrease spacing between paragraphs in landing page info blocks.
ginsu added inline comments to D8822: [landing] decrease spacing between paragraphs in landing page info blocks.
ginsu updated the summary of D8822: [landing] decrease spacing between paragraphs in landing page info blocks.
ginsu updated the diff for D8822: [landing] decrease spacing between paragraphs in landing page info blocks.
quick fix
ginsu requested review of D8822: [landing] decrease spacing between paragraphs in landing page info blocks.