Page MenuHomePhabricator
Feed Advanced Search

Sep 22 2023

patryk updated the diff for D9057: [web] Add webMentionTypeaheadRegex tests.

Simplify test cases

Sep 22 2023, 7:44 AM
patryk added a comment to D8944: [web] Modify mention typeahead regex.

D9057

Sep 22 2023, 7:29 AM

Sep 21 2023

patryk published D9057: [web] Add webMentionTypeaheadRegex tests for review.
Sep 21 2023, 7:53 AM
patryk added a comment to D8908: [lib] Encode chat name in raw chat mention.

D9254

Sep 21 2023, 6:24 AM
patryk published D9254: [lib] Add unit tests for mention utils for review.
Sep 21 2023, 4:34 AM
patryk updated the diff for D9005: [lib] Introduce chat mention utilities for plain text.

Decode alternative text

Sep 21 2023, 4:13 AM
patryk retitled D9218: [keyserver] Render raw chat mention in the notification text from [keyserver] Render raw chat mention to [keyserver] Render raw chat mention in the notification text.
Sep 21 2023, 2:06 AM
patryk added a comment to D9152: [native] Use expo-file-system uploads.

I've tested this diff on Android and it's working properly.

Sep 21 2023, 2:05 AM

Sep 20 2023

patryk added a comment to D9005: [lib] Introduce chat mention utilities for plain text.

I'm no longer using entityTextToRawString since I only need to extract alternative text. Please take a look at the latest diff, 31258. Throughout the entire stack, I use the useResolvedThreadInfo hook. Also, I'm not handling ENS names in this stack; user mentions are handled as they were before. The only change was made in the search index -> however this change does affect mentioning in the input bar only. I can add a comment that the new search index needs to be refactored to support ENS names.

Sep 20 2023, 1:34 AM

Sep 19 2023

patryk abandoned D9007: [keyserver] Render chat mention in notification text.

Abandoning this diff since I don't have much time left in Comm.

Sep 19 2023, 4:18 AM
patryk abandoned D9006: [keyserver] Introduce function which checks if thread is mentionable.

Abandoning this diff since I don't have much time left in Comm.

Sep 19 2023, 4:18 AM
patryk published D9218: [keyserver] Render raw chat mention in the notification text for review.
Sep 19 2023, 4:16 AM
patryk updated the diff for D9005: [lib] Introduce chat mention utilities for plain text.

Remove unused utilities and introduce renderChatMentionsWithAltText

Sep 19 2023, 3:56 AM
patryk added inline comments to D9005: [lib] Introduce chat mention utilities for plain text.
Sep 19 2023, 3:56 AM
patryk updated the diff for D8945: [web] Show chats in mention typeahead tooltip.

Use getRawChatMention

Sep 19 2023, 3:54 AM
patryk added inline comments to D8945: [web] Show chats in mention typeahead tooltip.
Sep 19 2023, 3:53 AM
patryk updated the diff for D8944: [web] Modify mention typeahead regex.

Remove oldValidUsernameRegexString.

Sep 19 2023, 3:48 AM
patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Remove oldValidUsernameRegexString from mention regex

Sep 19 2023, 3:44 AM
patryk added inline comments to D8910: [native] Show chats in mention typeahead tooltip.
Sep 19 2023, 3:43 AM
patryk updated the diff for D8909: [native] Replace chat name with raw chat mention.

Extract mention text to separate function and apply DRY rule

Sep 19 2023, 3:24 AM
patryk added a comment to D8901: [lib] Add userStoreMentionSearchIndex selector.
In D8901#267694, @inka wrote:

D8903 will introduce new regex for detecting when typeahead should be shown (it will catch spaces too). Because of that change, the tooltip would never close.

D8903 was abandoned, does this influence this diff? What does the regex look like now?

Sep 19 2023, 3:11 AM
patryk added inline comments to D8900: [lib] Add chat mention SearchIndex selector.
Sep 19 2023, 3:08 AM
patryk updated the diff for D8899: [lib] Introduce SentencePrefixSearchIndex.

Rename addEntryHandler to addAllPrefixes and simplify code

Sep 19 2023, 2:49 AM
patryk updated the diff for D8898: [web][native] Modify typeahead function and variable names to distinguish chat mention utilities.

Rebase

Sep 19 2023, 2:47 AM
patryk updated the diff for D8897: [native] Refactor TypeaheadTooltip component.

Change void to mixed

Sep 19 2023, 2:46 AM
patryk added inline comments to D8897: [native] Refactor TypeaheadTooltip component.
Sep 19 2023, 2:44 AM
patryk updated the diff for D8896: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings type.

Rename textPrefix to query

Sep 19 2023, 2:04 AM
patryk added inline comments to D8875: [web] Make chat mentions clickable.
Sep 19 2023, 2:01 AM
patryk updated the diff for D8875: [web] Make chat mentions clickable.

Rebase

Sep 19 2023, 2:01 AM
patryk updated the diff for D8852: [web] Introduce markdown component for chat mentions.

Wrap <a> with <strong>

Sep 19 2023, 1:57 AM
patryk added inline comments to D8852: [web] Introduce markdown component for chat mentions.
Sep 19 2023, 1:57 AM
patryk updated the diff for D8851: [web] Use chat mention candidates in markdown rules.

Rebase and early return textMessageRules

Sep 19 2023, 1:56 AM
patryk updated the diff for D8847: [native] Change ChatContextProvider position.

Rebase

Sep 19 2023, 1:50 AM
patryk added a comment to D8846: [native] Use chat mention candidates in markdown rules.

@tomek's improvement makes sense, but I'm not applying them right now because I don't believe it will bring significant improvements. If there will be any performance issues during testing, it might be worth wrapping default rules with memo.

Sep 19 2023, 1:46 AM
patryk updated the diff for D8846: [native] Use chat mention candidates in markdown rules.

Early return textMessageRules

Sep 19 2023, 1:39 AM
patryk added a comment to D8873: [native] Make chat mentions clickable.

Yes, the sidebarAnimationType is set to move_source_message in this case.

Sep 19 2023, 1:33 AM
patryk updated the diff for D8844: [native] Refactor markdown-link component.

Rebase

Sep 19 2023, 1:30 AM
patryk updated the diff for D9056: [lib] Add unit tests for chat mention regex.

Move match word

Sep 19 2023, 1:28 AM

Sep 18 2023

patryk updated the diff for D9159: [web] Use blobServiceUpload upload action.

Fix flow

Sep 18 2023, 7:46 AM
patryk updated the diff for D9163: [native] Use blobServiceUpload upload action.

Fix flow bugs

Sep 18 2023, 7:44 AM
patryk updated the diff for D9159: [web] Use blobServiceUpload upload action.

Rebuild

Sep 18 2023, 7:27 AM
patryk updated the diff for D9163: [native] Use blobServiceUpload upload action.

Rebuild

Sep 18 2023, 7:26 AM
patryk updated the diff for D9157: [lib] Add blobServiceUpload upload action.

Failing CI fix

Sep 18 2023, 7:15 AM
patryk updated the diff for D9163: [native] Use blobServiceUpload upload action.

Use new syntax

Sep 18 2023, 5:34 AM
patryk updated the diff for D9157: [lib] Add blobServiceUpload upload action.

Destructure options.

Sep 18 2023, 5:32 AM

Sep 15 2023

patryk closed D9154: [lib] Add uuid dependency.
Sep 15 2023, 6:24 AM
patryk committed rCOMM2904579fc7a0: [lib] Add uuid dependency (authored by patryk).
[lib] Add uuid dependency
Sep 15 2023, 6:24 AM
patryk closed D9151: [native] Add expo-file-system dependency.
Sep 15 2023, 6:23 AM
patryk committed rCOMM7aea5c13119d: [native] Add expo-file-system dependency (authored by patryk).
[native] Add expo-file-system dependency
Sep 15 2023, 6:23 AM

Sep 14 2023

patryk published D9159: [web] Use blobServiceUpload upload action for review.
Sep 14 2023, 4:46 AM
patryk published D9163: [native] Use blobServiceUpload upload action for review.
Sep 14 2023, 4:46 AM
patryk published D9157: [lib] Add blobServiceUpload upload action for review.
Sep 14 2023, 4:46 AM
patryk published D9154: [lib] Add uuid dependency for review.
Sep 14 2023, 4:45 AM
patryk published D9152: [native] Use expo-file-system uploads for review.

This code works properly on iOS, but I need to check if it is working properly on Android.

Sep 14 2023, 4:45 AM
patryk published D9151: [native] Add expo-file-system dependency for review.
Sep 14 2023, 4:43 AM
patryk added inline comments to D8834: [lib] Introduce chat mention match and parse utilities.
Sep 14 2023, 1:11 AM

Sep 13 2023

patryk abandoned D8643: [blob-service] Clean up uploaded blob data if any test fails.

Unfortunately, I don't have time to fix this diff, so I'll have to abandon it because it requires a refactor.

Sep 13 2023, 9:01 AM
patryk abandoned D8647: [blob-service] Test HTTP Ranges.

Unfortunately, I don't have time to fix this diff, so I'll have to abandon it because it requires a refactor.

Sep 13 2023, 9:00 AM

Sep 4 2023

patryk closed D9067: [lib] Move pendingThreadIDRegex to validation-utils.js.
Sep 4 2023, 1:14 AM
patryk committed rCOMM043aed1fc0cf: [lib] Move pendingThreadIDRegex to validation-utils.js (authored by patryk).
[lib] Move pendingThreadIDRegex to validation-utils.js
Sep 4 2023, 1:14 AM

Sep 3 2023

patryk updated the test plan for D9067: [lib] Move pendingThreadIDRegex to validation-utils.js.
Sep 3 2023, 10:38 PM

Sep 1 2023

patryk added a reviewer for D9067: [lib] Move pendingThreadIDRegex to validation-utils.js: tomek.
Sep 1 2023, 9:03 AM
patryk published D9067: [lib] Move pendingThreadIDRegex to validation-utils.js for review.
Sep 1 2023, 8:54 AM
patryk added inline comments to D9006: [keyserver] Introduce function which checks if thread is mentionable.
Sep 1 2023, 8:28 AM
patryk closed D8833: [lib] Introduce chat mention candidates getters.
Sep 1 2023, 6:25 AM
patryk committed rCOMM07be3385ef50: [lib] Introduce chat mention candidates getters (authored by patryk).
[lib] Introduce chat mention candidates getters
Sep 1 2023, 6:25 AM
patryk updated the diff for D8833: [lib] Introduce chat mention candidates getters.

Refactor useThreadChatMentionCandidates

Sep 1 2023, 6:03 AM
patryk published D9061: [lib][native][web] Move validChatNameRegex to validation-utils.js for review.
Sep 1 2023, 5:47 AM
patryk added inline comments to D8846: [native] Use chat mention candidates in markdown rules.
Sep 1 2023, 3:39 AM
patryk updated the diff for D8851: [web] Use chat mention candidates in markdown rules.

Change getDefaultTextMessageRules

Sep 1 2023, 3:15 AM
patryk updated the diff for D8846: [native] Use chat mention candidates in markdown rules.

Change getDefaultTextMessageRules

Sep 1 2023, 3:14 AM
patryk abandoned D8871: [web][native] Refactor getDefaultTextMessageRules.

Since _memoize can use too much memory, I'm abandoning this diff and leaving the previous approach.

Sep 1 2023, 3:12 AM
patryk updated the diff for D9056: [lib] Add unit tests for chat mention regex.

Fix nits

Sep 1 2023, 12:02 AM
patryk updated the diff for D9056: [lib] Add unit tests for chat mention regex.

Change test messages

Sep 1 2023, 12:00 AM

Aug 31 2023

patryk published D9056: [lib] Add unit tests for chat mention regex for review.
Aug 31 2023, 11:53 PM
patryk updated the diff for D9005: [lib] Introduce chat mention utilities for plain text.

Rebase

Aug 31 2023, 11:53 PM
patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Rebase

Aug 31 2023, 11:52 PM
patryk updated the diff for D8902: [web][native] Use userStoreMentionSearchIndex.

Rebase

Aug 31 2023, 11:51 PM
patryk updated the diff for D8834: [lib] Introduce chat mention match and parse utilities.

Use idSchemaRegex

Aug 31 2023, 11:50 PM
patryk updated the test plan for D8847: [native] Change ChatContextProvider position.
Aug 31 2023, 6:52 AM
patryk updated the summary of D8909: [native] Replace chat name with raw chat mention.
Aug 31 2023, 5:37 AM
patryk added inline comments to D9006: [keyserver] Introduce function which checks if thread is mentionable.
Aug 31 2023, 5:34 AM
patryk updated the diff for D9006: [keyserver] Introduce function which checks if thread is mentionable.

Fix

Aug 31 2023, 5:31 AM
patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Rebase

Aug 31 2023, 2:29 AM
patryk updated the diff for D8898: [web][native] Modify typeahead function and variable names to distinguish chat mention utilities.

Rebase

Aug 31 2023, 2:28 AM
patryk updated the diff for D8897: [native] Refactor TypeaheadTooltip component.

Change renderTypeaheadButton to component since this function does not return an array of components like on web

Aug 31 2023, 2:28 AM
patryk updated the diff for D8945: [web] Show chats in mention typeahead tooltip.

Simplify useMemos

Aug 31 2023, 1:08 AM

Aug 30 2023

patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Refactor getMentionTypeaheadChatSuggestions

Aug 30 2023, 11:55 PM
patryk updated the diff for D8900: [lib] Add chat mention SearchIndex selector.

Change useChatMentionSearchIndex

Aug 30 2023, 11:41 PM
patryk updated the diff for D8833: [lib] Introduce chat mention candidates getters.

Rename variable and hook

Aug 30 2023, 11:40 PM
patryk updated the diff for D8875: [web] Make chat mentions clickable.

Rebase

Aug 30 2023, 8:11 AM
patryk updated the diff for D8852: [web] Introduce markdown component for chat mentions.

Remove memoization and threadInfo prop

Aug 30 2023, 8:09 AM
patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Rebase

Aug 30 2023, 7:47 AM
patryk updated the diff for D8909: [native] Replace chat name with raw chat mention.

Change chat to threadInfo

Aug 30 2023, 7:45 AM
patryk updated the diff for D8910: [native] Show chats in mention typeahead tooltip.

Rebase

Aug 30 2023, 7:35 AM
patryk updated the diff for D8909: [native] Replace chat name with raw chat mention.

Add read-only type

Aug 30 2023, 7:30 AM
patryk updated the diff for D8849: [native] Add chat mention rule to text message rules.

Remove style prop

Aug 30 2023, 7:14 AM
patryk updated the diff for D8873: [native] Make chat mentions clickable.

Rebase

Aug 30 2023, 7:13 AM
patryk updated the diff for D8845: [native] Introduce markdown component for chat mentions.

Move style condition to chat mention component

Aug 30 2023, 7:11 AM
patryk updated the diff for D8845: [native] Introduce markdown component for chat mentions.

Remove threadInfo prop

Aug 30 2023, 7:09 AM