Feed Search

Search
Use Results
Edit Query
Hide Query

Oct 5 2023

ginsu committed rCOMMdf113b8f3846: [native] update avatar size variants to use t-shirt sizes.

Oct 5 2023, 3:50 AM

ginsu closed D9363: [native] introduce contentDimensions prop to full screen view modal.

Oct 5 2023, 3:50 AM

ginsu closed D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.

Oct 5 2023, 3:50 AM

ginsu committed rCOMMdb6358f55b9f: [native] introduce contentDimensions prop to full screen view modal.

Oct 5 2023, 3:50 AM

ginsu committed rCOMM318dc92cfbb2: [native] introduce saveContentCallback and copyContentCallback props to full….

Oct 5 2023, 3:50 AM

ginsu closed D9359: [native] introduce children prop to FullScreenViewModal.

Oct 5 2023, 3:50 AM

ginsu closed D9361: [native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component.

Oct 5 2023, 3:50 AM

ginsu committed rCOMMfb83d81c3057: [native] introduce children prop to FullScreenViewModal.

Oct 5 2023, 3:50 AM

ginsu committed rCOMM7b02e7e5afa7: [native] rename instances of ImageModal to FullScreenViewModal in….

Oct 5 2023, 3:50 AM

ginsu closed D9360: [native] introduce FullScreenViewModal.

Oct 5 2023, 3:50 AM

ginsu closed D9358: [native] introduce user profile constants.

Oct 5 2023, 3:50 AM

ginsu committed rCOMM4bfd03b6a558: [native] introduce FullScreenViewModal.

Oct 5 2023, 3:50 AM

ginsu committed rCOMM6a421e536baa: [native] introduce user profile constants.

Oct 5 2023, 3:50 AM

ginsu updated the diff for D9366: [lib/native] introduce XXL size to AvatarSize.

rebase before landing

Oct 5 2023, 3:25 AM

ginsu added a comment to D9366: [lib/native] introduce XXL size to AvatarSize.

In D9366#275107, @atul wrote:

Double Extra Large??

Oct 5 2023, 3:24 AM

ginsu updated the diff for D9365: [lib/native] lift AvatarSize type into lib.

rebase before landing

Oct 5 2023, 3:23 AM

ginsu updated the diff for D9364: [native] update avatar size variants to use t-shirt sizes.

rebase before landing

Oct 5 2023, 3:22 AM

ginsu updated the diff for D9363: [native] introduce contentDimensions prop to full screen view modal.

rebase before landing

Oct 5 2023, 3:20 AM

ginsu updated the diff for D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.

rebase before landing

Oct 5 2023, 3:19 AM

ginsu updated the diff for D9359: [native] introduce children prop to FullScreenViewModal.

address atul's feedback

Oct 5 2023, 3:10 AM

ginsu updated the diff for D9361: [native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component.

rebase before landing

Oct 5 2023, 3:05 AM

ginsu updated the diff for D9360: [native] introduce FullScreenViewModal.

rebase before landing

Oct 5 2023, 3:03 AM

ginsu updated the diff for D9358: [native] introduce user profile constants.

rebase before landing

Oct 5 2023, 2:59 AM

ginsu added a comment to D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.

https://linear.app/comm/issue/ENG-5166/improve-refactoring-of-fullscreenviewmodal-compoment

Oct 5 2023, 2:52 AM

ginsu added a comment to D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.

In D9362#275121, @atul wrote:

Makes sense, wonder if there's a way to make FullScreenViewModal a little more "children-agnostic" since saveContentCallback and copyContentCallback are kind of media-specific and presumably FullScreenViewModal should be a general purpose component.

Accepting to unblock, but might be worth thinking through a more general purpose API?

Oct 5 2023, 2:40 AM

Oct 4 2023

ginsu added a comment to D9358: [native] introduce user profile constants.

In D9358#275100, @atul wrote:

In D9358#275095, @ginsu wrote:

Don't love the indirection, but seems like a reasonable approach

Wdym by indirection here? Happy to make any updates to make it less indirect

cc @atul

Just that the constants are in a separate file creates "distance" from where the values are defined and where they're used. But given you need to use them in multiple places this seems like a good bet.

IDE will "show" value of eg userProfileActionButtonHeight on hover anyways

Oct 4 2023, 11:36 PM

ginsu added a comment to D9358: [native] introduce user profile constants.

Don't love the indirection, but seems like a reasonable approach

Oct 4 2023, 11:30 PM

ginsu requested review of D9366: [lib/native] introduce XXL size to AvatarSize.

Oct 4 2023, 9:12 PM

ginsu requested review of D9365: [lib/native] lift AvatarSize type into lib.

Oct 4 2023, 9:09 PM

ginsu requested review of D9364: [native] update avatar size variants to use t-shirt sizes.

Oct 4 2023, 8:57 PM

ginsu requested review of D9363: [native] introduce contentDimensions prop to full screen view modal.

Oct 4 2023, 8:45 PM

ginsu requested review of D9362: [native] introduce saveContentCallback and copyContentCallback props to full screen view modal.

Oct 4 2023, 8:28 PM

ginsu requested review of D9361: [native] rename instances of ImageModal to FullScreenViewModal in FullScreenViewModal component.

Oct 4 2023, 7:21 PM

ginsu retitled D9359: [native] introduce children prop to FullScreenViewModal from DO NOT REVIEW FOR NOW [native] introduce FullScreenViewModal

Oct 4 2023, 7:12 PM

ginsu updated the diff for D9359: [native] introduce children prop to FullScreenViewModal.

update

Oct 4 2023, 7:08 PM

ginsu updated the diff for D9359: [native] introduce children prop to FullScreenViewModal.

update

Oct 4 2023, 6:59 PM

ginsu added inline comments to D9360: [native] introduce FullScreenViewModal.

Oct 4 2023, 6:43 PM

ginsu added inline comments to D9360: [native] introduce FullScreenViewModal.

Oct 4 2023, 6:40 PM

ginsu requested review of D9360: [native] introduce FullScreenViewModal.

Oct 4 2023, 6:39 PM

ginsu retitled D9359: [native] introduce children prop to FullScreenViewModal from [native] introduce FullScreenViewModal to DO NOT REVIEW FOR NOW [native] introduce FullScreenViewModal .

Oct 4 2023, 6:21 PM

ginsu closed D9274: [native] make bottomsheet snap point dynamic.

Oct 4 2023, 5:29 PM

ginsu committed rCOMM050b1af776c0: [native] make bottomsheet snap point dynamic.

Oct 4 2023, 5:29 PM

ginsu requested review of D9358: [native] introduce user profile constants.

Oct 4 2023, 5:28 PM

ginsu planned changes to D9359: [native] introduce children prop to FullScreenViewModal.

This seems pretty difficult to review... will break down this diff further

Oct 4 2023, 5:27 PM

ginsu published D9359: [native] introduce children prop to FullScreenViewModal for review.

Oct 4 2023, 5:26 PM

ginsu updated the diff for D9274: [native] make bottomsheet snap point dynamic.

rebase before landing

Oct 4 2023, 5:06 PM

Sep 29 2023

ginsu closed D9272: [native] introduce BottomSheetProvider.

Sep 29 2023, 8:27 PM

ginsu committed rCOMMb272611288b5: [native] introduce BottomSheetProvider.

Sep 29 2023, 8:27 PM

ginsu accepted D9325: [lib] Introduce a canBeSidebarSource function in each message spec.

Sep 29 2023, 7:46 PM

ginsu added a comment to D9325: [lib] Introduce a canBeSidebarSource function in each message spec.

looks good! Trusting test plan so skimmed through the test file

Sep 29 2023, 7:46 PM

ginsu accepted D9324: [lib] Update types for SIDEBAR_SOURCE messages to reflect isInvalidSidebarSource.

seems reasonable

Sep 29 2023, 7:43 PM

ginsu abandoned D9273: [native] factor out UserProfileRelationshipButton condtionals.

Personally would prefer to inline these conditions but it doesn't matter a ton

Sep 29 2023, 7:36 PM

ginsu updated the diff for D9272: [native] introduce BottomSheetProvider.

rebase before landing

Sep 29 2023, 7:33 PM

ginsu closed D9271: [native] improve organization of user profiles work.

Sep 29 2023, 7:10 PM

ginsu closed D9260: [native] improve BottomSheet component close function.

Sep 29 2023, 7:10 PM

ginsu committed rCOMM588581374141: [native] improve organization of user profiles work.

Sep 29 2023, 7:10 PM

ginsu closed D9258: [native] introduce UserProfileRelationshipButton.

Sep 29 2023, 7:10 PM

ginsu committed rCOMM647baa08494b: [native] improve BottomSheet component close function.

Sep 29 2023, 7:10 PM

ginsu closed D9252: [lib/native] introduce UserProfileMessageButton.

Sep 29 2023, 7:10 PM

ginsu committed rCOMMc4c8db828ad9: [native] introduce UserProfileRelationshipButton.

Sep 29 2023, 7:10 PM

ginsu committed rCOMM9761ffcc760f: [lib/native] introduce UserProfileMessageButton.

Sep 29 2023, 7:10 PM

ginsu accepted D9323: [keyserver/lib] Move isInvalidSidebarSource from message-utils to message-types.

Sep 29 2023, 7:07 PM

ginsu accepted D9322: [keyserver/lib] Dedup isMessageSidebarSourceReactionEditOrPin into isInvalidSidebarSource.

Sep 29 2023, 7:05 PM

ginsu added a comment to D9322: [keyserver/lib] Dedup isMessageSidebarSourceReactionEditOrPin into isInvalidSidebarSource.

looks good, skimmed through the tests file (trusting your test plan here), but please see one inline comment

Sep 29 2023, 7:05 PM

ginsu updated the diff for D9271: [native] improve organization of user profiles work.

rebase before landing

Sep 29 2023, 6:48 PM

ginsu updated the diff for D9260: [native] improve BottomSheet component close function.

rebase before landing

Sep 29 2023, 6:47 PM

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebase before landing

Sep 29 2023, 6:46 PM

ginsu updated the diff for D9252: [lib/native] introduce UserProfileMessageButton.

rebase before landing

Sep 29 2023, 6:44 PM

Sep 28 2023

ginsu updated the diff for D9272: [native] introduce BottomSheetProvider.

fix merge conflict after merging master

Sep 28 2023, 5:17 PM

ginsu closed D9309: [native] introduce relationship button.

Sep 28 2023, 6:02 AM

ginsu committed rCOMM3c4aa0915e83: [native] introduce relationship button.

Sep 28 2023, 6:02 AM

ginsu closed D9247: [lib] introduce useUserProfileThreadInfo hook.

Sep 28 2023, 6:01 AM

ginsu committed rCOMMf5dd6833e19a: [lib] introduce useUserProfileThreadInfo hook.

Sep 28 2023, 6:01 AM

ginsu updated the diff for D9274: [native] make bottomsheet snap point dynamic.

address @atul's feedback

Sep 28 2023, 5:58 AM

ginsu updated the diff for D9273: [native] factor out UserProfileRelationshipButton condtionals.

address @atul's comments

Sep 28 2023, 5:51 AM

ginsu updated the diff for D9309: [native] introduce relationship button.

rebase before landing

Sep 28 2023, 5:34 AM

ginsu updated the diff for D9247: [lib] introduce useUserProfileThreadInfo hook.

rebase before landing

Sep 28 2023, 5:33 AM

Sep 27 2023

ginsu requested review of D9285: [native] simplify RelationshipListItem jsx.

Sep 27 2023, 10:33 PM

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

address @atul's comments

Sep 27 2023, 10:09 PM

ginsu requested review of D9309: [native] introduce relationship button.

Sep 27 2023, 9:59 PM

ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.

Sep 27 2023, 9:58 PM

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebasing (still need to address @atul's feedback)

Sep 27 2023, 7:32 PM

ginsu retitled D9252: [lib/native] introduce UserProfileMessageButton from [native] introduce UserProfileMessageButton

Sep 27 2023, 6:49 PM

ginsu added inline comments to D9252: [lib/native] introduce UserProfileMessageButton.

Sep 27 2023, 6:48 PM

ginsu added inline comments to D9252: [lib/native] introduce UserProfileMessageButton.

Sep 27 2023, 6:40 PM

ginsu updated the diff for D9252: [lib/native] introduce UserProfileMessageButton.

address @atul's comments

Sep 27 2023, 6:38 PM

ginsu added inline comments to D9286: [native] make user profiles accessible from RelationshipListItem.

Sep 27 2023, 6:06 PM

Sep 26 2023

ginsu updated the diff for D9247: [lib] introduce useUserProfileThreadInfo hook.

address comments

Sep 26 2023, 7:52 PM

ginsu added reviewers for D9285: [native] simplify RelationshipListItem jsx: atul, inka.

Sep 26 2023, 6:40 PM

Sep 25 2023

ginsu requested review of D9289: [native] make user profile accessible from message author avatar.

Sep 25 2023, 2:38 PM

ginsu requested review of D9286: [native] make user profiles accessible from RelationshipListItem.

Sep 25 2023, 2:22 PM

ginsu requested review of D9285: [native] simplify RelationshipListItem jsx.

Sep 25 2023, 1:56 PM

ginsu requested review of D9274: [native] make bottomsheet snap point dynamic.

Sep 25 2023, 7:01 AM

ginsu attached a referenced file: F772625: Screenshot 2023-09-25 at 2.35.25 AM.png.

Sep 25 2023, 6:57 AM

ginsu updated the summary of D9272: [native] introduce BottomSheetProvider.

Sep 25 2023, 6:57 AM

ginsu requested review of D9273: [native] factor out UserProfileRelationshipButton condtionals.

Sep 25 2023, 6:57 AM

ginsu requested review of D9272: [native] introduce BottomSheetProvider.

Sep 25 2023, 6:47 AM

Sep 22 2023

ginsu requested review of D9271: [native] improve organization of user profiles work.

Sep 22 2023, 9:22 PM

ginsu updated the summary of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

Sep 22 2023, 9:07 PM

ginsu planned changes to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

changing stack order/will need to rebase

Sep 22 2023, 8:43 PM