Feed Search

Search
Use Results
Edit Query
Hide Query

Nov 29 2023

ginsu closed D9916: [web] introduce add keyserver modal.

Nov 29 2023, 4:07 AM

ginsu committed rCOMM01beb1a4d4ac: [web] introduce add keyserver modal.

Nov 29 2023, 4:07 AM

ginsu updated the diff for D9920: [web] introduce keyserver selection modal.

rebase before landing

Nov 29 2023, 3:23 AM

ginsu updated the diff for D9918: [web] introduce add keyserver button.

address comments + rebase before landing

Nov 29 2023, 3:16 AM

ginsu updated the diff for D9916: [web] introduce add keyserver modal.

address comments + rebase before landing

Nov 29 2023, 3:14 AM

Nov 28 2023

ginsu accepted D10078: [lib] Reintroduce `RawThreadInfo` (`[Legacy/MinimallyEncoded]RawThreadInfo`).

Nov 28 2023, 11:11 PM

ginsu accepted D9885: [lib] Detect a valid ENS name in search experiences.

LGTM, again sorry for not reviewing this sooner.

Nov 28 2023, 9:47 PM

ginsu accepted D9884: [web/native] Use useSearchUsers for the friends list.

sorry for not getting to this sooner!

Nov 28 2023, 9:31 PM

ginsu added a comment to D9916: [web] introduce add keyserver modal.

Another design question - just in terms of consistency, do normally use a darker background behind the action button in modals?

Nov 28 2023, 8:45 PM

ginsu updated the diff for D9916: [web] introduce add keyserver modal.

address comments

Nov 28 2023, 8:44 PM

Nov 27 2023

ginsu accepted D10063: [Flow202][web][skip-ci] [22/x] Add updatesCurrentAsOf to PersistedKeyserverInfo.

Nov 27 2023, 10:14 PM

ginsu accepted D10031: [Flow202][native][skip-ci] [47/x] Parameterize StyleSheet.flatten invocations.

Nov 27 2023, 10:14 PM

ginsu accepted D10027: [Flow202][native][skip-ci] [43/x] Add type for BottomSheetRef.

Nov 27 2023, 10:13 PM

ginsu accepted D10025: [Flow202][native][skip-ci] [41/x] Fix type error in native/themes/colors.js.

Nov 27 2023, 10:12 PM

ginsu accepted D10019: [Flow202][native][skip-ci] [35/x] Add memo for appliedStyles in EditSettingButton.

Nov 27 2023, 10:11 PM

ginsu accepted D10018: [Flow202][native][skip-ci] [34/x] Type WritableAnimatedStyleObj in ReactionSelectionPopover and Tooltip.

Nov 27 2023, 10:08 PM

ginsu accepted D10009: [Flow202][native][skip-ci] [25/x] Get rid of ProfileScreen.navigateIfActive.

Nov 27 2023, 10:06 PM

ginsu accepted D10005: [Flow202][native][skip-ci] [21/x] Update AnimatedStyleObj type.

Nov 27 2023, 10:03 PM

ginsu closed D9983: [native] remove unused user profile bottom sheet ref.

Nov 27 2023, 4:40 AM

ginsu committed rCOMM5d8bb1971abe: [native] remove unused user profile bottom sheet ref.

Nov 27 2023, 4:40 AM

ginsu closed D9892: [web] introduce keyserver selection list.

Nov 27 2023, 4:18 AM

ginsu committed rCOMM8927c3f5b07a: [web] introduce keyserver selection list.

Nov 27 2023, 4:18 AM

ginsu closed D9891: [web] introduce keyserver selection list item.

Nov 27 2023, 4:18 AM

ginsu committed rCOMM0b8e58dacd3f: [web] introduce keyserver selection list item.

Nov 27 2023, 4:18 AM

ginsu closed D9905: [web] introduce keyserver pill component.

Nov 27 2023, 4:18 AM

ginsu committed rCOMM02d9845ea208: [web] introduce keyserver pill component.

Nov 27 2023, 4:18 AM

ginsu requested review of D9983: [native] remove unused user profile bottom sheet ref.

Nov 27 2023, 2:52 AM

ginsu added inline comments to D9373: [native] replace out of box BottomSheetModal with basic BottomSheet.

Nov 27 2023, 2:22 AM

ginsu updated the diff for D9892: [web] introduce keyserver selection list.

rebase before landing

Nov 27 2023, 2:07 AM

ginsu updated the diff for D9891: [web] introduce keyserver selection list item.

rebase before landing

Nov 27 2023, 2:06 AM

ginsu updated the diff for D9905: [web] introduce keyserver pill component.

rebase before landing

Nov 27 2023, 2:06 AM

Nov 16 2023

ginsu published D9920: [web] introduce keyserver selection modal for review.

Nov 16 2023, 9:11 PM

ginsu added a comment to D9905: [web] introduce keyserver pill component.

Can you share a screenshot of the UI that was changed? Not just the pill, but the pill in the context of where it's used

Nov 16 2023, 9:10 PM

ginsu updated the test plan for D9905: [web] introduce keyserver pill component.

Nov 16 2023, 9:08 PM

ginsu requested review of D9918: [web] introduce add keyserver button.

Nov 16 2023, 8:51 PM

ginsu added inline comments to D9892: [web] introduce keyserver selection list.

Nov 16 2023, 8:20 PM

ginsu published D9916: [web] introduce add keyserver modal for review.

Nov 16 2023, 6:22 PM

ginsu added a comment to D9882: [lib] Calculate currentAsOf for every keyserver in mergeNewMessages.

as far as I understand for now we are just leaving all data related to a keyserver when we leave it. @ginsu is that right?

Nov 16 2023, 5:35 PM

ginsu requested review of D9906: [native] save the recently deleted server url to customServer redux state.

Nov 16 2023, 12:14 AM

ginsu requested review of D9905: [web] introduce keyserver pill component.

Nov 16 2023, 12:12 AM

Nov 15 2023

ginsu updated the diff for D9891: [web] introduce keyserver selection list item.

update

Nov 15 2023, 9:33 PM

ginsu updated the summary of D9891: [web] introduce keyserver selection list item.

Nov 15 2023, 9:25 PM

ginsu closed D9888: [web] introduce status indicator component.

Nov 15 2023, 6:48 PM

ginsu committed rCOMMf4bed298e4f8: [web] introduce status indicator component.

Nov 15 2023, 6:48 PM

ginsu closed D9887: [web] introduce keyservers to the settings switcher.

Nov 15 2023, 6:48 PM

ginsu committed rCOMMc055ddbdb6cb: [web] introduce keyservers to the settings switcher.

Nov 15 2023, 6:48 PM

ginsu updated the diff for D9888: [web] introduce status indicator component.

rebase before landing

Nov 15 2023, 6:42 PM

ginsu added a comment to D9888: [web] introduce status indicator component.

I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design.

Nov 15 2023, 6:41 PM

ginsu updated the diff for D9887: [web] introduce keyservers to the settings switcher.

rebase before landing

Nov 15 2023, 6:35 PM

ginsu requested review of D9892: [web] introduce keyserver selection list.

Nov 15 2023, 4:40 AM

ginsu requested review of D9891: [web] introduce keyserver selection list item.

Nov 15 2023, 4:33 AM

ginsu closed D9830: [native] introduce functionality for onPressRemoveKeyserver callback.

Nov 15 2023, 1:52 AM

ginsu committed rCOMMedc5a062bf93: [native] introduce functionality for onPressRemoveKeyserver callback.

Nov 15 2023, 1:52 AM

ginsu closed D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.

Nov 15 2023, 1:49 AM

ginsu committed rCOMMb89136d8d288: [lib] introduce removeKeyserverActionType condition to keyserver reducer.

Nov 15 2023, 1:49 AM

ginsu closed D9828: [native] introduce temp onPressDisconnectKeyserver callback.

Nov 15 2023, 1:47 AM

ginsu closed D9826: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.

Nov 15 2023, 1:47 AM

ginsu committed rCOMMb759ac739fef: [native] introduce temp onPressDisconnectKeyserver callback.

Nov 15 2023, 1:47 AM

ginsu committed rCOMM371f6f808e5e: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.

Nov 15 2023, 1:47 AM

ginsu updated the diff for D9830: [native] introduce functionality for onPressRemoveKeyserver callback.

rebase before landing

Nov 15 2023, 1:45 AM

ginsu updated the diff for D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.

address comments + rebase before landing

Nov 15 2023, 1:42 AM

ginsu updated the diff for D9828: [native] introduce temp onPressDisconnectKeyserver callback.

rebase before landing

Nov 15 2023, 1:28 AM

ginsu updated the diff for D9826: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.

rebase before landing

Nov 15 2023, 1:25 AM

ginsu closed D9795: [native] calculate snap points for keyserver selection bottomsheet.

Nov 15 2023, 1:18 AM

ginsu committed rCOMM79cc9a34d6f7: [native] calculate snap points for keyserver selection bottomsheet.

Nov 15 2023, 1:18 AM

ginsu closed D9794: [native] update remove keyserver text based on connection status.

Nov 15 2023, 1:18 AM

ginsu closed D9756: [native] add onPress function to keyserver selection list item.

Nov 15 2023, 1:18 AM

ginsu committed rCOMM8073ea0aa3cd: [native] add onPress function to keyserver selection list item.

Nov 15 2023, 1:18 AM

ginsu committed rCOMMbda34094c90b: [native] update remove keyserver text based on connection status.

Nov 15 2023, 1:18 AM

ginsu closed D9754: [native] introduce keyserver selection bottom sheet ui.

Nov 15 2023, 1:18 AM

ginsu committed rCOMM494bc1013d3b: [native] introduce keyserver selection bottom sheet ui.

Nov 15 2023, 1:18 AM

Nov 14 2023

ginsu updated the diff for D9795: [native] calculate snap points for keyserver selection bottomsheet.

rebase before landing

Nov 14 2023, 11:00 PM

ginsu updated the diff for D9794: [native] update remove keyserver text based on connection status.

rebase before landing

Nov 14 2023, 11:00 PM

ginsu added a comment to D9794: [native] update remove keyserver text based on connection status.

Accepting, but we need to figure out D9828 before landing this

Nov 14 2023, 10:59 PM

ginsu requested review of D9888: [web] introduce status indicator component.

Nov 14 2023, 10:56 PM

ginsu requested review of D9887: [web] introduce keyservers to the settings switcher.

Nov 14 2023, 10:52 PM

ginsu updated the diff for D9756: [native] add onPress function to keyserver selection list item.

rebase before landing

Nov 14 2023, 10:46 PM

ginsu updated the diff for D9754: [native] introduce keyserver selection bottom sheet ui.

rebae before landing

Nov 14 2023, 10:44 PM

ginsu closed D9665: [native] implement onPressSave keyserver button callback.

Nov 14 2023, 10:41 PM

ginsu committed rCOMM5ccad7e00e91: [native] implement onPressSave keyserver button callback.

Nov 14 2023, 10:41 PM

ginsu updated the diff for D9665: [native] implement onPressSave keyserver button callback.

rebase before landing

Nov 14 2023, 10:11 PM

ginsu added a comment to D9828: [native] introduce temp onPressDisconnectKeyserver callback.

this copy won't be surfaced to users

Nov 14 2023, 7:14 PM

ginsu accepted D9815: [lib] Inline reduceConnectionInfo pt.2.

Nov 14 2023, 7:08 PM

Nov 13 2023

ginsu retitled D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer from DRAFT [lib] introduce removeKeyserverActionType condition to keyserver reducer

Nov 13 2023, 9:20 PM

ginsu attached a referenced file: F873225: Screenshot 2023-11-13 at 4.19.22 PM.png.

Nov 13 2023, 9:20 PM

ginsu attached a referenced file: F873223: Screenshot 2023-11-13 at 4.18.52 PM.png.

Nov 13 2023, 9:20 PM

ginsu updated the summary of D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.

Nov 13 2023, 9:20 PM

ginsu updated the diff for D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.

rebase

Nov 13 2023, 9:13 PM

ginsu updated the summary of D9830: [native] introduce functionality for onPressRemoveKeyserver callback.

Nov 13 2023, 8:57 PM

ginsu updated the diff for D9830: [native] introduce functionality for onPressRemoveKeyserver callback.

address @ashoat's comments

Nov 13 2023, 8:55 PM

ginsu updated the diff for D9795: [native] calculate snap points for keyserver selection bottomsheet.

address @inka's comments

Nov 13 2023, 8:41 PM

ginsu abandoned D9791: [native] update drawerOpenCommunityBackground color with panelBackgroundAccent.

After thinking about this some more, I updated D9754 with a better solution and left a comment justifying the changes I made with the colors.

Nov 13 2023, 8:32 PM

ginsu attached a referenced file: F873027: Screenshot 2023-11-13 at 3.19.49 PM.png.

Nov 13 2023, 8:27 PM

ginsu attached a referenced file: F873033: Screenshot 2023-11-13 at 3.26.38 PM.png.

Nov 13 2023, 8:27 PM

ginsu added inline comments to D9754: [native] introduce keyserver selection bottom sheet ui.

Nov 13 2023, 8:27 PM

ginsu updated the diff for D9754: [native] introduce keyserver selection bottom sheet ui.

update

Nov 13 2023, 8:22 PM

ginsu closed D9664: [lib] add conditions for adding keyserver to the keyserver store.

Nov 13 2023, 8:00 PM

ginsu committed rCOMMde96f810073b: [lib] add conditions for adding keyserver to the keyserver store.

Nov 13 2023, 8:00 PM

ginsu updated the diff for D9664: [lib] add conditions for adding keyserver to the keyserver store.

rebase before landing

Nov 13 2023, 7:43 PM

ginsu closed D9838: [web] introduce light mode to settings switcher.

Nov 13 2023, 7:40 PM