Page MenuHomePhorge
Feed Search

Feb 1 2024

ginsu updated the summary of D10919: [lib] introduce useMembersGroupedByRole.
Feb 1 2024, 11:01 PM
ginsu requested review of D10919: [lib] introduce useMembersGroupedByRole.
Feb 1 2024, 10:57 PM
ginsu added inline comments to D10899: [web] introduce member list sidebar provider.
Feb 1 2024, 10:27 PM
ginsu updated the diff for D10899: [web] introduce member list sidebar provider.

address comments

Feb 1 2024, 10:24 PM
ginsu planned changes to D10901: [web] introduce threadMembersSelectorForThread.

There is a flaw in my logic, putting this diff back in my queue until the updates are ready

Feb 1 2024, 9:43 AM
ginsu retitled D10823: [web] update toggleUser to use previouslySelectedUsers map if previously selected user is toggled from [web] update toggleUser to use vip users map if vip user is toggled
Feb 1 2024, 12:40 AM
ginsu updated the summary of D10823: [web] update toggleUser to use previouslySelectedUsers map if previously selected user is toggled.
Feb 1 2024, 12:40 AM
ginsu updated the diff for D10823: [web] update toggleUser to use previouslySelectedUsers map if previously selected user is toggled.

address comments

Feb 1 2024, 12:38 AM

Jan 31 2024

ginsu retitled D10822: [web] introduce previouslySelectedUsers ui to add users list from [web] introduce vip users ui to add users list
Jan 31 2024, 11:34 PM
ginsu updated the diff for D10822: [web] introduce previouslySelectedUsers ui to add users list.

fix typo

Jan 31 2024, 11:31 PM
ginsu updated the diff for D10822: [web] introduce previouslySelectedUsers ui to add users list.

update vip users with previouslySelectedUsers

Jan 31 2024, 11:24 PM
ginsu added a comment to D10822: [web] introduce previouslySelectedUsers ui to add users list.

Thanks for addressing feedback, could we use if statement instead of invariant where I annotated?

Jan 31 2024, 10:55 PM
ginsu updated the diff for D10822: [web] introduce previouslySelectedUsers ui to add users list.

rebase + address comments

Jan 31 2024, 10:55 PM
ginsu retitled D10820: [web] introduce previouslySelectedUsers map to add users list from [web] introduce vipPendingUsers map to add users list
Jan 31 2024, 10:46 PM
ginsu updated the diff for D10820: [web] introduce previouslySelectedUsers map to add users list.

address comments

Jan 31 2024, 10:38 PM
ginsu requested review of D10901: [web] introduce threadMembersSelectorForThread.
Jan 31 2024, 10:08 PM
ginsu requested review of D10900: [web] introduce member list sidebar header.
Jan 31 2024, 9:40 PM
ginsu requested review of D10899: [web] introduce member list sidebar provider.
Jan 31 2024, 9:34 PM
ginsu closed D10839: [lib/native] lift staff provider into lib.
Jan 31 2024, 9:08 PM
ginsu closed D10840: [web] introduce build info panel.
Jan 31 2024, 9:08 PM
ginsu committed rCOMM56ad0ef9ae3c: [web] introduce build info panel.
Jan 31 2024, 9:08 PM
ginsu committed rCOMM6025a259cd6f: [lib/native] lift staff provider into lib.
Jan 31 2024, 9:08 PM
ginsu closed D10825: [native] consolidate staff context provider into one file.
Jan 31 2024, 9:08 PM
ginsu closed D10824: [web] introduce build info to users settings list.
Jan 31 2024, 9:08 PM
ginsu committed rCOMM519b88a1656d: [native] consolidate staff context provider into one file.
Jan 31 2024, 9:08 PM
ginsu committed rCOMM51034220c407: [web] introduce build info to users settings list.
Jan 31 2024, 9:08 PM
ginsu closed D10717: [web] make mouse pointer when hovering over checkbox input.
Jan 31 2024, 9:08 PM
ginsu committed rCOMMbd14b070b31d: [web] make mouse pointer when hovering over checkbox input.
Jan 31 2024, 9:08 PM
ginsu updated the diff for D10840: [web] introduce build info panel.

rebase

Jan 31 2024, 8:46 PM
ginsu updated the diff for D10839: [lib/native] lift staff provider into lib.

rebase

Jan 31 2024, 8:45 PM
ginsu updated the diff for D10825: [native] consolidate staff context provider into one file.

rebase

Jan 31 2024, 8:44 PM
ginsu updated the diff for D10824: [web] introduce build info to users settings list.

fix merge conflicts + rebase

Jan 31 2024, 8:43 PM
ginsu closed D10897: [web] introduce useSortedENSResolvedUsers.
Jan 31 2024, 8:36 PM
ginsu committed rCOMM8edec5cb6dad: [web] introduce useSortedENSResolvedUsers.
Jan 31 2024, 8:36 PM
ginsu updated the diff for D10897: [web] introduce useSortedENSResolvedUsers.

address comments

Jan 31 2024, 8:31 PM
ginsu attached a referenced file: F1103013: Screenshot 2024-01-31 at 2.30.48 PM.png.
Jan 31 2024, 8:30 PM
ginsu attached a referenced file: F1103012: Screenshot 2024-01-31 at 2.30.58 PM.png.
Jan 31 2024, 8:30 PM
ginsu updated the test plan for D10822: [web] introduce previouslySelectedUsers ui to add users list.
Jan 31 2024, 8:30 PM
ginsu updated the diff for D10822: [web] introduce previouslySelectedUsers ui to add users list.

address comments

Jan 31 2024, 8:27 PM
ginsu accepted D10898: [lib] Split `WebInitialReduxStateResponse` into `Client/Server` variants.
Jan 31 2024, 8:20 PM
ginsu accepted D10895: [lib] Move `WebInitialReduxStateResponse` to `lib`.
Jan 31 2024, 8:20 PM
ginsu requested review of D10897: [web] introduce useSortedENSResolvedUsers.
Jan 31 2024, 7:46 PM
ginsu accepted D10894: [web] Rename `InitialKeyserverInfo` -> `WebInitialKeyserverInfo`.
Jan 31 2024, 7:25 PM
ginsu updated the diff for D10825: [native] consolidate staff context provider into one file.

address feedback

Jan 31 2024, 7:21 PM
ginsu accepted D10893: [web] Rename `InitialReduxStateResponse` -> `InitialWebReduxStateResponse`.
Jan 31 2024, 7:02 PM
ginsu accepted D10892: [lib] Move `WebNavInfo` to `lib`.
Jan 31 2024, 7:01 PM
ginsu accepted D10891: [web][lib] Move `WebNavInfo` type dependencies to `lib`.
Jan 31 2024, 7:01 PM
ginsu added a comment to D10891: [web][lib] Move `WebNavInfo` type dependencies to `lib`.

Looks good, could you lmk when you land this. I know I made some changes to WebNavigationSettingsSection in my stacks (D10824) so just want to make sure to make changes to that if you land this diff first

Jan 31 2024, 7:00 PM
ginsu requested review of D10825: [native] consolidate staff context provider into one file.

Spoke to @atul IRL about this, but we decided that what I have is okay and even though useStaffContext isn't really doing too much it provides nice autocompletion for devs with fields for this provider in the code editor since we get to utilize the StaffContextType

Jan 31 2024, 6:58 PM
ginsu attached a referenced file: F1102363: Screenshot 2024-01-31 at 1.47.28 PM.png.
Jan 31 2024, 6:52 PM
ginsu attached a referenced file: F1102364: Screenshot 2024-01-31 at 1.47.34 PM.png.
Jan 31 2024, 6:52 PM
ginsu added inline comments to D10717: [web] make mouse pointer when hovering over checkbox input.
Jan 31 2024, 6:52 PM
ginsu updated the diff for D10717: [web] make mouse pointer when hovering over checkbox input.

update with fix to checkbox shrinking

Jan 31 2024, 6:48 PM
ginsu added a comment to D10717: [web] make mouse pointer when hovering over checkbox input.

(Have read misc things on Twitter that cursor: pointer should be avoided for non-link elements, but I don't really have an opinion)

Jan 31 2024, 6:44 PM
ginsu accepted D10890: [web] Rename `NavInfo` to `WebNavInfo`.
Jan 31 2024, 6:41 PM
ginsu accepted D10889: [web] Rename `NavigationChatMode` to `WebNavigationChatMode`.
Jan 31 2024, 6:41 PM
ginsu accepted D10887: [web] Rename `LoginMethod` -> `WebLoginMethod`.
Jan 31 2024, 6:40 PM
ginsu accepted D10886: [web] Rename `NavigationTab` -> `WebNavigationTab`.
Jan 31 2024, 6:40 PM
ginsu accepted D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.

thanks for fixing this!

Jan 31 2024, 6:23 PM
ginsu accepted D10888: [web] Rename `NavigationSettingsSection` -> `WebNavigationSettingsSection`.
Jan 31 2024, 6:22 PM
ginsu accepted D10872: [lib] Remove lateResponses on logout.
Jan 31 2024, 6:42 AM
ginsu accepted D10870: [native] Remove logout / delete account / identity login logic from specific reducers.
Jan 31 2024, 6:42 AM
ginsu accepted D10869: [web] Remove logout / delete account / identity login logic from specific reducers.
Jan 31 2024, 6:41 AM
ginsu requested changes to D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.

Looks good, let's just fix up the flickering issue

Jan 31 2024, 6:40 AM

Jan 29 2024

ginsu requested review of D10855: [web] introduce danger zone panel.
Jan 29 2024, 7:38 AM
ginsu requested review of D10856: [web] introduce account settings panel.
Jan 29 2024, 7:33 AM

Jan 26 2024

ginsu requested review of D10850: [web] introduce keyserver selection list panel.
Jan 26 2024, 10:27 PM
ginsu requested review of D10849: [web] fix button in add friends modal not visible on small screens.
Jan 26 2024, 10:18 PM
ginsu requested review of D10840: [web] introduce build info panel.
Jan 26 2024, 4:40 PM
ginsu requested review of D10839: [lib/native] lift staff provider into lib.
Jan 26 2024, 4:39 PM
ginsu closed D10419: [web] ens resolve usernames in the reaction tooltip.
Jan 26 2024, 4:38 PM
ginsu committed rCOMM43149a92ccca: [web] ens resolve usernames in the reaction tooltip.
Jan 26 2024, 4:37 PM
ginsu updated the diff for D10419: [web] ens resolve usernames in the reaction tooltip.

rebase before landing

Jan 26 2024, 4:37 PM
ginsu updated the summary of D10825: [native] consolidate staff context provider into one file.
Jan 26 2024, 4:15 PM

Jan 25 2024

ginsu requested review of D10825: [native] consolidate staff context provider into one file.
Jan 25 2024, 10:15 PM
ginsu requested review of D10824: [web] introduce build info to users settings list.
Jan 25 2024, 10:14 PM
ginsu requested review of D10823: [web] update toggleUser to use previouslySelectedUsers map if previously selected user is toggled.
Jan 25 2024, 9:37 PM
ginsu added a comment to D10820: [web] introduce previouslySelectedUsers map to add users list.

What does "vip" mean in this situation?

Jan 25 2024, 9:13 PM
ginsu requested review of D10822: [web] introduce previouslySelectedUsers ui to add users list.
Jan 25 2024, 8:44 PM
ginsu updated the summary of D10820: [web] introduce previouslySelectedUsers map to add users list.
Jan 25 2024, 8:37 PM
ginsu updated the summary of D10819: [web] convert pendingUsersToAdd into a map.
Jan 25 2024, 8:37 PM
ginsu updated the summary of D10747: [web] update add user list header based on if searching users.
Jan 25 2024, 8:37 PM
ginsu requested review of D10820: [web] introduce previouslySelectedUsers map to add users list.
Jan 25 2024, 8:19 PM
ginsu requested review of D10819: [web] convert pendingUsersToAdd into a map.
Jan 25 2024, 7:59 PM

Jan 24 2024

ginsu requested review of D10746: [web] introduce clear all button to add users list.

Rerequesting review after responding to concerns inline

Jan 24 2024, 10:55 PM
ginsu updated the diff for D10735: [web] update add friends modal selection logic.

address comments

Jan 24 2024, 10:35 PM
ginsu updated the diff for D10722: [web] update add users list item ui.

address comments

Jan 24 2024, 10:34 PM
ginsu added inline comments to D10735: [web] update add friends modal selection logic.
Jan 24 2024, 10:25 PM
ginsu added inline comments to D10735: [web] update add friends modal selection logic.
Jan 24 2024, 10:05 PM
ginsu added a comment to D10419: [web] ens resolve usernames in the reaction tooltip.

Is this working & ready for review now?

Jan 24 2024, 8:55 PM
ginsu closed D10714: [web] add feedback if user list is empty.
Jan 24 2024, 8:17 PM
ginsu committed rCOMMb90e58e67f76: [web] add feedback if user list is empty.
Jan 24 2024, 8:17 PM
ginsu closed D10712: [web] introduce block list panel.
Jan 24 2024, 8:17 PM
ginsu committed rCOMM1f2b1238d36c: [web] introduce block list panel.
Jan 24 2024, 8:17 PM
ginsu updated the diff for D10714: [web] add feedback if user list is empty.

address feedback copy now just says "No results" + rebase before landing

Jan 24 2024, 7:51 PM
ginsu updated the diff for D10712: [web] introduce block list panel.

rebase before landing

Jan 24 2024, 7:37 PM
ginsu added a comment to D10712: [web] introduce block list panel.

Look good. Personally would've preferred deduplicating BlockListModal, but not sure how involved that would've been.

Jan 24 2024, 7:34 PM
ginsu accepted D10636: [lib] Refactor draft reducer.
Jan 24 2024, 7:31 PM
ginsu accepted D10628: [lib] Refactor user reducer.
Jan 24 2024, 7:26 PM
ginsu accepted D10619: [lib] Refactor report store reducer.
Jan 24 2024, 7:23 PM