address comments
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feb 1 2024
There is a flaw in my logic, putting this diff back in my queue until the updates are ready
address comments
Jan 31 2024
fix typo
update vip users with previouslySelectedUsers
Thanks for addressing feedback, could we use if statement instead of invariant where I annotated?
rebase + address comments
address comments
rebase
rebase
fix merge conflicts + rebase
address comments
address comments
address feedback
Looks good, could you lmk when you land this. I know I made some changes to WebNavigationSettingsSection in my stacks (D10824) so just want to make sure to make changes to that if you land this diff first
Spoke to @atul IRL about this, but we decided that what I have is okay and even though useStaffContext isn't really doing too much it provides nice autocompletion for devs with fields for this provider in the code editor since we get to utilize the StaffContextType
update with fix to checkbox shrinking
(Have read misc things on Twitter that cursor: pointer should be avoided for non-link elements, but I don't really have an opinion)
thanks for fixing this!
Looks good, let's just fix up the flickering issue
Jan 29 2024
Jan 26 2024
rebase before landing
Jan 25 2024
What does "vip" mean in this situation?
Jan 24 2024
Rerequesting review after responding to concerns inline
address comments
address comments
Is this working & ready for review now?
address feedback copy now just says "No results" + rebase before landing
rebase before landing
Look good. Personally would've preferred deduplicating BlockListModal, but not sure how involved that would've been.