Invert the flag
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 1 2024
Rebase
Rebase
Rebase and address comments
Rebased the diff but I'm not sure whether it works and is the right approach
Rebase
Rebase
Rebase
Update comment
Rebase
Rebase
In D10134#296332, @tomek wrote:I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions
Rebase
Include status and text in a result
This is quite fragile - it should work because in identity context we select commServicesAccessToken, and when it changes, we create a new value of getAuthMetadata function. Also, accessToken and userID are exposed by the same emitter.
Rename
Improve canceling logic
Jan 31 2024
Rebase
Destructure in the function
Instantly delete blobs
Set instant flag
Rebase
Destructure params inside function
Delete unnecessary async
Decided that it is a lot more efficient to introduce a new diff which introduces canceling the auth D10884.
My understanding is that ConnectionInfo is a client-only type and no inital value is sent from the keyserver. I was a bit confused because of connectionInfoValidator, but it turns out connectionInfoValidator is only consumed by keyserverInfoValidator which is only consumed by keyserverStoreValidator... which doesn't seem to be used anywhere? It looks like the only two KeyserverInfo fields we send as part of initialReduxState are sessionID and updatesCurrentAsOf.
This seems to be correct, but we should extend the test plan by checking if old clients can work correctly after this change.
Jan 30 2024
Jan 29 2024
In D10842#312452, @ashoat wrote:Is this what we want to do for all connection issues, even for my keyserver? Or are there some kinds of connection issues, where if they occur for my keyserver, we'd want to log the user out?
Jan 26 2024
Delete unnecessary check - a dependency on dataLoaded flag makes this logic invalid
Jan 25 2024
This diff should have a meaningful test plan
Jan 22 2024
Rebase onto D10752