Page MenuHomePhorge
Feed Search

Jul 11 2024

will requested review of D12729: [terraform] Make number of secondary nodes configured by the user.
Jul 11 2024, 5:24 PM
will added inline comments to D12689: [terraform] create comm database on aws rds startup.
Jul 11 2024, 3:32 PM
will requested review of D12725: [terraform] add Tunnelbroker configuration variable to self-host.
Jul 11 2024, 11:48 AM
will requested review of D12724: [keyserver] add `aws` proxy type for self-hosted keyservers.
Jul 11 2024, 11:36 AM
will requested changes to D12723: [terraform] bump staging identity to 0.29-staging.

Just saw https://linear.app/comm/issue/ENG-8810/unable-to-login#comment-47abbe95. Unrelated to the actual code in this diff but we should probably make a fix a dependency for this one

Jul 11 2024, 11:10 AM
will accepted D12723: [terraform] bump staging identity to 0.29-staging.
Jul 11 2024, 11:04 AM

Jul 10 2024

will updated the diff for D12689: [terraform] create comm database on aws rds startup.

run this command every time

Jul 10 2024, 9:25 PM
will accepted D12704: [identity] fix issues with capitalized usernames in users and reserved usernames tables.

Directly synced with Varun. Looks good. Before landing make sure to remove need for unnecessary partition key check and add a comment for changes starting from line 340 in services/identity/src/database.rs

Jul 10 2024, 4:35 PM
will added inline comments to D12719: Fix CORS issues with identity HTTP.
Jul 10 2024, 2:41 PM
will requested review of D12711: [terraform] Introduce secondary keyserver service.
Jul 10 2024, 2:47 AM
will requested review of D12709: [terraform] Ensure only one running ecs task for primary service.
Jul 10 2024, 2:45 AM
will requested review of D12710: [terraform] add authoritative keyserver id as a user-specified variable.
Jul 10 2024, 2:45 AM
will requested review of D12708: [keyserver] configure separation of primary secondary logic.
Jul 10 2024, 2:39 AM

Jul 9 2024

will requested review of D12689: [terraform] create comm database on aws rds startup.
Jul 9 2024, 1:56 PM

Jul 8 2024

will requested review of D12691: [terraform] include REDIS_URL as part of keyserver terraform config.
Jul 8 2024, 1:03 PM
will requested review of D12690: [terraform] restrict redis access to ecs keyserver service only.
Jul 8 2024, 12:56 PM
will requested review of D12688: [terraform] make aws rds instance class configurable for self-hosting.
Jul 8 2024, 12:50 PM
will requested review of D12687: [keyserver] use yarn instead of npm for running prod.
Jul 8 2024, 12:47 PM
will requested review of D12686: [lib] remove integrity store assertion and use sqlite.
Jul 8 2024, 12:30 PM
will updated the diff for D12531: [terraform] initial ecs setup for keyserver primary.

set to false initially

Jul 8 2024, 10:35 AM

Jun 28 2024

will requested review of D12623: [identity] downgrade no auth message error to warning.
Jun 28 2024, 11:41 PM
will closed D12622: [terraform] upgrade identity staging image to 0.27-staging.
Jun 28 2024, 10:27 PM
will committed rCOMMe5da765b7617: [terraform] upgrade identity staging image to 0.27-staging.
Jun 28 2024, 10:27 PM
will closed D12621: [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 10:27 PM
will committed rCOMM41b1598dab24: [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 10:27 PM
will updated the test plan for D12621: [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 10:19 PM
will updated the test plan for D12622: [terraform] upgrade identity staging image to 0.27-staging.
Jun 28 2024, 10:18 PM
will updated the diff for D12622: [terraform] upgrade identity staging image to 0.27-staging.

rebase

Jun 28 2024, 10:09 PM
will updated the diff for D12622: [terraform] upgrade identity staging image to 0.27-staging.

rebase with new docker image push

Jun 28 2024, 10:04 PM
will retitled D12621: [identity] ensure identity reqwest crate has rustls-tls from [services] add back default features to reqwest in cargo workspaces
Jun 28 2024, 9:58 PM
will updated the diff for D12621: [identity] ensure identity reqwest crate has rustls-tls.

revamp. No longer reenabling default features. Instead just adding to rustls-tls to identity Cargo.toml

Jun 28 2024, 9:57 PM
will published D12622: [terraform] upgrade identity staging image to 0.27-staging for review.
Jun 28 2024, 8:43 PM
will updated the diff for D12621: [identity] ensure identity reqwest crate has rustls-tls.

recompile backup_client from workspace cargo.toml change

Jun 28 2024, 8:32 PM
will published D12621: [identity] ensure identity reqwest crate has rustls-tls for review.
Jun 28 2024, 8:01 PM

Jun 27 2024

will closed D12579: [terraform] service connection error alarms.
Jun 27 2024, 5:06 PM
will committed rCOMMc467ef6439c5: [terraform] service connection error alarms.
Jun 27 2024, 5:06 PM

Jun 26 2024

will updated the diff for D12579: [terraform] service connection error alarms.

add email subscription

Jun 26 2024, 10:16 PM
will closed D12564: [terraform] created combined error reports email.
Jun 26 2024, 10:05 PM
will committed rCOMM6704a4e7c9de: [terraform] created combined error reports email.
Jun 26 2024, 10:05 PM
will closed D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 26 2024, 10:05 PM
will committed rCOMM5c7fad19c1ab: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 26 2024, 10:05 PM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 10:00 PM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 10:00 PM
will updated the diff for D12579: [terraform] service connection error alarms.

fix filters and log group names

Jun 26 2024, 9:58 PM
will updated the summary of D12579: [terraform] service connection error alarms.
Jun 26 2024, 4:18 PM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 4:18 PM
will updated the diff for D12579: [terraform] service connection error alarms.

change pattern to "dns error"

Jun 26 2024, 4:17 PM
will planned changes to D12579: [terraform] service connection error alarms.

We actually do want this as "dns error"

Jun 26 2024, 3:45 PM
will requested review of D12579: [terraform] service connection error alarms.
Jun 26 2024, 2:53 PM

Jun 25 2024

will updated the summary of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 25 2024, 5:21 PM
will updated the summary of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 25 2024, 5:20 PM
will added a comment to D12563: [terraform] change cloudwatch subscription prefix from common to identity.

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

Jun 25 2024, 5:20 PM
will requested review of D12564: [terraform] created combined error reports email.
Jun 25 2024, 5:01 AM
will requested review of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 25 2024, 5:00 AM
will requested review of D12560: [terraform] set up keyserver load balancer.
Jun 25 2024, 2:50 AM
will requested review of D12559: [terraform] Increase keyserver primary ecs task resources.
Jun 25 2024, 2:46 AM
will added inline comments to D12531: [terraform] initial ecs setup for keyserver primary.
Jun 25 2024, 2:26 AM
will updated the summary of D12558: [keyserver] add health check route to keyserver for use by load balancer.
Jun 25 2024, 2:25 AM
will requested review of D12558: [keyserver] add health check route to keyserver for use by load balancer.
Jun 25 2024, 1:56 AM
will published D12531: [terraform] initial ecs setup for keyserver primary for review.
Jun 25 2024, 1:42 AM
will accepted D12555: [terraform] bump staging identity to 0.26.
Jun 25 2024, 1:38 AM

Jun 24 2024

will closed D12550: [terraform] Change alarm names to reflect staging or production environment.
Jun 24 2024, 5:18 PM
will committed rCOMMf6f382e7b6d9: [terraform] Change alarm names to reflect staging or production environment.
Jun 24 2024, 5:18 PM
will closed D12551: [identity] Downgrades search trace error.
Jun 24 2024, 5:17 PM
will committed rCOMM94236c7f1b9a: [identity] Downgrades search trace error.
Jun 24 2024, 5:17 PM
will requested review of D12551: [identity] Downgrades search trace error.
Jun 24 2024, 3:41 AM
will requested review of D12550: [terraform] Change alarm names to reflect staging or production environment.
Jun 24 2024, 3:22 AM

Jun 21 2024

will requested review of D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Jun 21 2024, 3:30 AM
will requested review of D12528: [terraform] run mariadb in public db group.
Jun 21 2024, 3:28 AM

Jun 20 2024

will accepted D12515: [identity] fix wallet account deletion bug.
Jun 20 2024, 8:18 PM

Jun 19 2024

will requested review of D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.
Jun 19 2024, 5:32 PM

Jun 18 2024

will added a comment to D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.

Why not the latest version?

Jun 18 2024, 5:00 PM
will accepted D12447: [identity][websocket] Call DB client directly to verify CSAT.

This makes a lot of sense. Not sure why I didn't consider this on first implementation but glad you caught it now.

Jun 18 2024, 2:15 PM
will accepted D12462: [terraform] Refactor search lambda IAM role policy attachments.

Thanks for solving this!

Jun 18 2024, 2:11 PM
will accepted D12460: [terraform] Add DNS records for load balancers.
Jun 18 2024, 2:04 PM
will accepted D12461: [terraform] Remove unused outputs.
Jun 18 2024, 1:56 PM
will requested review of D12458: [terraform] initial Redis terraform config.
Jun 18 2024, 4:28 AM
will requested review of D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.
Jun 18 2024, 4:23 AM

Jun 12 2024

will closed D12384: [lib] assert function and setting client db with sqlite data.
Jun 12 2024, 9:20 PM
will requested review of D12409: [lib] Use sqlite for message store local instead of redux persist.
Jun 12 2024, 9:20 PM
will committed rCOMM23c6aa4e6c09: [lib] assert function and setting client db with sqlite data.
Jun 12 2024, 9:20 PM
will updated the test plan for D12384: [lib] assert function and setting client db with sqlite data.
Jun 12 2024, 9:18 PM
will updated the diff for D12384: [lib] assert function and setting client db with sqlite data.

set web app start to use sqlite

Jun 12 2024, 8:40 PM
will updated the test plan for D12384: [lib] assert function and setting client db with sqlite data.
Jun 12 2024, 7:39 PM
will updated the diff for D12384: [lib] assert function and setting client db with sqlite data.

rebase

Jun 12 2024, 7:36 PM
will updated the diff for D12384: [lib] assert function and setting client db with sqlite data.

review feedback

Jun 12 2024, 7:17 PM

Jun 11 2024

will requested review of D12384: [lib] assert function and setting client db with sqlite data.
Jun 11 2024, 11:08 PM
will updated the test plan for D12384: [lib] assert function and setting client db with sqlite data.
Jun 11 2024, 10:55 PM
will updated the diff for D12384: [lib] assert function and setting client db with sqlite data.

This diff actually uses sqlite data

Jun 11 2024, 10:53 PM
will added inline comments to D12384: [lib] assert function and setting client db with sqlite data.
Jun 11 2024, 9:32 PM
will updated subscribers of D12384: [lib] assert function and setting client db with sqlite data.
Jun 11 2024, 9:28 PM
will added a reviewer for D12384: [lib] assert function and setting client db with sqlite data: ginsu.
Jun 11 2024, 9:27 PM
will planned changes to D12384: [lib] assert function and setting client db with sqlite data.

Realized this diff requires a critical change of using the action payload sqlite data

Jun 11 2024, 9:27 PM

Jun 10 2024

will updated the summary of D12384: [lib] assert function and setting client db with sqlite data.
Jun 10 2024, 6:53 PM
will requested review of D12384: [lib] assert function and setting client db with sqlite data.
Jun 10 2024, 6:49 PM
will closed D12355: [identity] change 'no authentication message' for websocket server to warning.
Jun 10 2024, 12:59 PM
will committed rCOMM8960a8efd182: [identity] change 'no authentication message' for websocket server to warning.
Jun 10 2024, 12:59 PM
will closed D12253: [sqlite] implement logic to get message store logic from SQLite.
Jun 10 2024, 12:57 PM
will committed rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite.
Jun 10 2024, 12:57 PM
will updated the diff for D12253: [sqlite] implement logic to get message store logic from SQLite.

fix prior rebase

Jun 10 2024, 12:29 PM