Did you test that things still work for the non-nix workflow?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Nov 3 2022
Nov 3 2022
Nov 2 2022
Nov 2 2022
Nov 1 2022
Nov 1 2022
• jon added inline comments to D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.
• jon added a comment to D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.
otherwise LGTM
• jon added 1 blocking reviewer(s) for D5508: [iOS] Fix pod install and react-native with nix env: atul.
Oct 31 2022
Oct 31 2022
Rebase on new branch
Oct 27 2022
Oct 27 2022
going to shelve this later for https://linear.app/comm/issue/ENG-1837, and do a more holistic refactoring of the different parts of the shells including the shell hook.
Oct 26 2022
Oct 26 2022
• jon accepted D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.
LGTM
• jon accepted D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.
accepting since the builds are corrected later on.
• jon added inline comments to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
• jon added a comment to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
Sure, it's done in a further D5461 diff.
don't feel like blocking this work, since we have the goal of transitioning away from C++ eventually. So the issue of include! hygiene might not be relevant in the future.
• jon added inline comments to D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
• jon accepted D5486: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file.
seems logical to me
otherwise LGTM
Rebase on fixes
Rebase on fixes
• jon accepted D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.
CI gates are fixed later. Don't want perfect to be the enemy of better. I'm good with the changes as long as they all land as once
Oct 25 2022
Oct 25 2022
retested this on top of the node changes, seems to work for web app and landing page
Oct 24 2022
Oct 24 2022
Use proper value for proxy
• jon requested changes to D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.
Correct other usage of http://localhost
Apply feedback
Oct 21 2022
Oct 21 2022
• jon accepted D5454: [native][android] move `rustup target add` from CMakeLists.txt to build.gradle.
Going to assume that the android gate passing means this is likely to succeed.
• jon added inline comments to D5448: [services][identity] create a struct for the users table in MySQL.
• jon added inline comments to D5441: [IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction.
• jon added a comment to D5440: [IGNORE][CommCoreModule] `ROLLBACK` transaction on migration failure.
looks fine to me, but let someone else more familiar with the sqlite logic to do approval
• jon added a comment to D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.
The CI gates should be updated as part of this as well, having two failing gates isn't good.
• jon requested changes to D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.
• jon requested changes to D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.
please also update the path used by the tunnel broker tests under .buildkite/
Oct 20 2022
Oct 20 2022
Looks fine to me.
Oct 18 2022
Oct 18 2022
• jon accepted D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository.
LGTM
Is there a way we could default to the number of cores that the computer has?
Oct 17 2022
Oct 17 2022
still need to update test plan
Apply whitespace feedback
Use test instead of [
Oct 14 2022
Oct 14 2022
• jon added a comment to D5367: Ensure Server{Write/Read/Bidi}ReactorBase derived class instance is deallocated after all thread pool tasks writing to its memory complete.
otherwise LGTM
Oct 13 2022
Oct 13 2022
• jon accepted D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.
meant to accept, misclick
• jon requested changes to D5361: [services] Tunnelbroker - Update Tunnelbroker protobuf file with ping and new device token in bidirectional stream.
This is probably what I would do, but @tomek should still review
@atul and I paired, and from a cleaned repository (e.g. git clean -xfd && rm -rf ~/.local/share/MariaDB), we were able to post a message after creating a user.
Rebase on master
Fix commapp_url.json configuration, and rebase on master
Oct 12 2022
Oct 12 2022
To anwser your question more directly, it's the max-jobs and cores values for nix.conf. https://nixos.org/manual/nix/stable/command-ref/conf-file.html
The ./scripts/install_nix.sh should provide you with defaults, currently it will give 4 cores per build. It's possible that the build is just single threaded for some reason.
• jon added a reviewer for D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library: tomek.
• jon added a comment to D5330: [services] Tunnelbroker - Update on using of `init` in Rust notifications library.
LGTM, feel like @tomek should take a look
Oct 11 2022
Oct 11 2022
Oct 10 2022
Oct 10 2022
oh, a reminder that it's ready to land. Yea.
Rebase on top of master
Don't see why not.
Create log directory
• jon requested changes to D5269: [services] Provision EC2 Instance for Identity Service with Terraform.
We should also think about where we want the terraform state file to live if this will be a shared resource