Nice

Skimmed

The test cases in lib/utils/text-utils.test.js are extremely thorough

Nice

Nice

rebase + land

rebase + land

rebase before landing

In D6493#194506, @bartek wrote:

My main concern and the reason why I made these inputs optional is that on modern mobile OS we shouldn't assume that the filename is always available - due to security reasons, we usually receive a content URI with minimal knowledge about its origin. For instance, modern Android usually gives you a content:// URI with very few permissions, like content://com.android.providers.media.documents/document/image:56. The app can then query a content resolver for more info like filename etc, but it isn't guaranteed to be available. Currently, it usually is (e.g. through expo-media-library), but each android version increases privacy even more.
On iOS, expo-image-picker uses the suggestedName to get a filename, but it's a nullable type.
So in conclusion, we shouldn't rely on origin filenames too much.

Looks good! Sorry for the churn

Demo looks great! nits and question inline

So it appears that we're passing the filename down to processVideo which in turn passes it to getVideoProcessingPlan which is where we try to construct outputPaths for transcoded video + thumbnail and things appear to fail when we try to write to disk at the outputPaths? Wonder if we should push the sanitization down to where we're trying to construct a path so filename is "accurate" as it's being passed along to various functions?

(Default number of retries is 2, for a total of 3 attempts before failure... which seems reasonable to me?)

In D6483#194034, @ashoat wrote:

I can send him a message to double check and can revert if necessary.

Would be great if you could do that

Are you sure we need to use those colors, versus using ones in the design system? Did you check with Dave? I would prefer to keep the design system colors unless the design team indicated otherwise

Landing without "blocking reviewer" approval because @ginsu is the right person to review this (https://linear.app/comm/issue/ENG-2648/get-rid-of-formal-blocking-reviewers-requirement).

rebase before landing