Page MenuHomePhabricator
Feed Advanced Search

Apr 19 2023

ginsu accepted D7545: [native] Pass `customKeyName` to `dispatchActionPromise` in `selectFromGalleryAndUpdateThreadAvatar`.
Apr 19 2023, 3:15 PM
ginsu accepted D7542: [native] Fix error check condition.
Apr 19 2023, 1:56 PM
ginsu added inline comments to D7514: [native] introduce ChatCameraModal component.
Apr 19 2023, 1:41 PM
ginsu updated the diff for D7514: [native] introduce ChatCameraModal component.

fix goBackOnce

Apr 19 2023, 1:35 PM
ginsu closed D7504: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into EmojiAvatarCreation.
Apr 19 2023, 12:46 PM
ginsu committed rCOMMa26ae7f8bbee: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into… (authored by ginsu).
[native] factor out shared code between Emoji[User/Thread]AvatarCreation into…
Apr 19 2023, 12:46 PM
ginsu closed D7503: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and EmojiThreadAvatarCreation.
Apr 19 2023, 12:46 PM
ginsu committed rCOMM0109468d1a2a: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and… (authored by ginsu).
[native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and…
Apr 19 2023, 12:46 PM
ginsu updated the diff for D7504: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into EmojiAvatarCreation.

rebase before landing

Apr 19 2023, 12:37 PM
ginsu updated the diff for D7503: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and EmojiThreadAvatarCreation.

rebase before landing

Apr 19 2023, 12:33 PM
ginsu added inline comments to D7514: [native] introduce ChatCameraModal component.
Apr 19 2023, 11:48 AM
ginsu updated the diff for D7504: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into EmojiAvatarCreation.

address comments

Apr 19 2023, 10:54 AM
ginsu updated the diff for D7503: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and EmojiThreadAvatarCreation.

address comments

Apr 19 2023, 10:41 AM
ginsu requested review of D7514: [native] introduce ChatCameraModal component.
Apr 19 2023, 12:32 AM

Apr 18 2023

ginsu requested review of D7504: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into EmojiAvatarCreation.
Apr 18 2023, 1:56 PM
ginsu requested review of D7503: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and EmojiThreadAvatarCreation.
Apr 18 2023, 1:55 PM
ginsu accepted D7495: [native] Add second register button only visible to devs.
Apr 18 2023, 1:44 PM
ginsu accepted D7499: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency.

agree outline is better

Apr 18 2023, 12:49 PM
ginsu accepted D7494: [native] Add horizontal margin to buttons in LoggedOutModal.
Apr 18 2023, 12:47 PM
ginsu accepted D7492: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`.
Apr 18 2023, 10:21 AM
ginsu accepted D7491: [native] Move vector-related components to `native/vectors`.
Apr 18 2023, 10:17 AM
ginsu accepted D7490: [native] Move avatar-related components to `native/avatars`.

makes sense to have a new directory for avatars

Apr 18 2023, 10:16 AM

Apr 17 2023

ginsu accepted D7474: [native] Left-align pending thread header titles.
Apr 17 2023, 12:30 PM
ginsu closed D7461: [lib] introduce getEthAddressForUserInfo helper function.
Apr 17 2023, 11:52 AM
ginsu committed rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function (authored by ginsu).
[lib] introduce getEthAddressForUserInfo helper function
Apr 17 2023, 11:52 AM
ginsu added inline comments to D7462: [native] introduce use ens avatar option to edit avatar.
Apr 17 2023, 11:47 AM
ginsu updated the diff for D7461: [lib] introduce getEthAddressForUserInfo helper function.

address ashoat's comments

Apr 17 2023, 8:44 AM
ginsu closed D7460: [native] update save avatar hooks to accept all types of avatars.
Apr 17 2023, 8:37 AM
ginsu committed rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars (authored by ginsu).
[native] update save avatar hooks to accept all types of avatars
Apr 17 2023, 8:37 AM
ginsu closed D7459: [native] have actionsheet pop up on press when editing avatar.
Apr 17 2023, 8:34 AM
ginsu committed rCOMM1ecd401b99bc: [native] have actionsheet pop up on press when editing avatar (authored by ginsu).
[native] have actionsheet pop up on press when editing avatar
Apr 17 2023, 8:34 AM
ginsu closed D7458: [native] update comm icon pack.
Apr 17 2023, 8:32 AM
ginsu committed rCOMMd36c0d50101f: [native] update comm icon pack (authored by ginsu).
[native] update comm icon pack
Apr 17 2023, 8:32 AM
ginsu added a comment to D7458: [native] update comm icon pack.

Could you share the source SVGs via DropBox or Google Drive or something?

Apr 17 2023, 8:24 AM
ginsu requested review of D7462: [native] introduce use ens avatar option to edit avatar.
Apr 17 2023, 12:51 AM
ginsu requested review of D7461: [lib] introduce getEthAddressForUserInfo helper function.
Apr 17 2023, 12:10 AM
ginsu requested review of D7460: [native] update save avatar hooks to accept all types of avatars.
Apr 17 2023, 12:04 AM

Apr 16 2023

ginsu requested review of D7459: [native] have actionsheet pop up on press when editing avatar.
Apr 16 2023, 11:47 PM
ginsu requested review of D7458: [native] update comm icon pack.
Apr 16 2023, 11:39 PM
ginsu closed D7457: [native] add safe area insets for android action sheet.
Apr 16 2023, 3:40 PM
ginsu committed rCOMM73bb16e27bfd: [native] add safe area insets for android action sheet (authored by ginsu).
[native] add safe area insets for android action sheet
Apr 16 2023, 3:40 PM
ginsu closed D7456: [native] fix Android cancel action sheet crash.
Apr 16 2023, 3:39 PM
ginsu committed rCOMM39a557c86168: [native] fix Android cancel action sheet crash (authored by ginsu).
[native] fix Android cancel action sheet crash
Apr 16 2023, 3:39 PM
ginsu added inline comments to D7456: [native] fix Android cancel action sheet crash.
Apr 16 2023, 12:31 PM
ginsu updated the diff for D7456: [native] fix Android cancel action sheet crash.

fix conditional

Apr 16 2023, 12:29 PM
ginsu updated the diff for D7457: [native] add safe area insets for android action sheet.

fix merge conflict

Apr 16 2023, 12:02 PM
ginsu updated the diff for D7456: [native] fix Android cancel action sheet crash.

fix dep order

Apr 16 2023, 12:01 PM
ginsu updated the diff for D7457: [native] add safe area insets for android action sheet.

rebase

Apr 16 2023, 11:59 AM
ginsu updated the diff for D7456: [native] fix Android cancel action sheet crash.

use cancel function

Apr 16 2023, 11:59 AM
ginsu requested review of D7457: [native] add safe area insets for android action sheet.
Apr 16 2023, 11:29 AM
ginsu planned changes to D7456: [native] fix Android cancel action sheet crash.
Apr 16 2023, 11:21 AM
ginsu requested review of D7456: [native] fix Android cancel action sheet crash.
Apr 16 2023, 11:09 AM

Apr 14 2023

ginsu closed D7438: [native] introduce EditAvatar component.
Apr 14 2023, 11:37 AM
ginsu committed rCOMMdf347498d65f: [native] introduce EditAvatar component (authored by ginsu).
[native] introduce EditAvatar component
Apr 14 2023, 11:37 AM
ginsu closed D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.
Apr 14 2023, 11:36 AM
ginsu committed rCOMM9d60ddb2a63b: [native] introduce EmojiAvatarCreation into profile and chat navigators (authored by ginsu).
[native] introduce EmojiAvatarCreation into profile and chat navigators
Apr 14 2023, 11:36 AM
ginsu closed D7428: [native] extend emoji avatar creation to handle thread avatars.
Apr 14 2023, 11:34 AM
ginsu committed rCOMM567d450ef219: [native] extend emoji avatar creation to handle thread avatars (authored by ginsu).
[native] extend emoji avatar creation to handle thread avatars
Apr 14 2023, 11:34 AM
ginsu closed D7427: [native] introduce useSaveThreadAvatar hook.
Apr 14 2023, 11:33 AM
ginsu committed rCOMMaf21cf8f11cb: [native] introduce useSaveThreadAvatar hook (authored by ginsu).
[native] introduce useSaveThreadAvatar hook
Apr 14 2023, 11:33 AM
ginsu closed D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.
Apr 14 2023, 11:32 AM
ginsu committed rCOMM04ec88164e7d: [lib] introduce savedEmojiAvatarSelectorForThread selector (authored by ginsu).
[lib] introduce savedEmojiAvatarSelectorForThread selector
Apr 14 2023, 11:32 AM
ginsu updated the diff for D7438: [native] introduce EditAvatar component.

address comments and rebase before landing

Apr 14 2023, 11:14 AM
ginsu updated the diff for D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.

rebase before landing

Apr 14 2023, 11:07 AM
ginsu updated the diff for D7428: [native] extend emoji avatar creation to handle thread avatars.

rebase before landing

Apr 14 2023, 11:06 AM
ginsu updated the diff for D7427: [native] introduce useSaveThreadAvatar hook.

rebase before landing

Apr 14 2023, 11:05 AM
ginsu updated the diff for D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.

rebase before landing

Apr 14 2023, 11:03 AM

Apr 13 2023

ginsu requested review of D7438: [native] introduce EditAvatar component.
Apr 13 2023, 3:51 PM
ginsu updated the summary of D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.
Apr 13 2023, 1:09 PM
ginsu attached a referenced file: F484215: Screen Recording 2023-04-13 at 1.16.41 PM.mov.
Apr 13 2023, 1:08 PM
ginsu retitled D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators from [native] introduce EmojiAvatarCreation into profile navigator to [native] introduce EmojiAvatarCreation into profile and chat navigators.
Apr 13 2023, 1:08 PM
ginsu updated the diff for D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.

fix import and add EmojiAvatarCreation to chats

Apr 13 2023, 1:07 PM
ginsu closed D7424: [native] introduce useSaveUserAvatar hook.
Apr 13 2023, 12:57 PM
ginsu committed rCOMM7f75aff169bf: [native] introduce useSaveUserAvatar hook (authored by ginsu).
[native] introduce useSaveUserAvatar hook
Apr 13 2023, 12:57 PM
ginsu added inline comments to D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.
Apr 13 2023, 12:37 PM
ginsu requested review of D7428: [native] extend emoji avatar creation to handle thread avatars.
Apr 13 2023, 10:36 AM
ginsu requested review of D7427: [native] introduce useSaveThreadAvatar hook.
Apr 13 2023, 10:20 AM
ginsu requested review of D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.
Apr 13 2023, 10:10 AM
ginsu updated the diff for D7424: [native] introduce useSaveUserAvatar hook.

remove console.log

Apr 13 2023, 9:50 AM
ginsu closed D7423: [native] move emoji avatar creation from profile directory to components directory.
Apr 13 2023, 9:37 AM
ginsu committed rCOMM94c79f1808ee: [native] move emoji avatar creation from profile directory to components… (authored by ginsu).
[native] move emoji avatar creation from profile directory to components…
Apr 13 2023, 9:37 AM
ginsu closed D7378: [native] add edit avatar badge to thread avatar.
Apr 13 2023, 9:34 AM
ginsu committed rCOMM5bd1e72ccc56: [native] add edit avatar badge to thread avatar (authored by ginsu).
[native] add edit avatar badge to thread avatar
Apr 13 2023, 9:34 AM
ginsu closed D7359: [native] implement onPressSetAvatar function.
Apr 13 2023, 9:33 AM
ginsu committed rCOMM8c77b3ae455b: [native] implement onPressSetAvatar function (authored by ginsu).
[native] implement onPressSetAvatar function
Apr 13 2023, 9:32 AM
ginsu closed D7403: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation.
Apr 13 2023, 9:30 AM
ginsu committed rCOMMcaf80b74e363: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation (authored by ginsu).
[native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation
Apr 13 2023, 9:30 AM
ginsu updated the summary of D7378: [native] add edit avatar badge to thread avatar.
Apr 13 2023, 9:23 AM
ginsu added a comment to D7423: [native] move emoji avatar creation from profile directory to components directory.

Does nothing actually use this component? Usually we'd have to update some import paths as well

Apr 13 2023, 9:22 AM
ginsu updated the summary of D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.
Apr 13 2023, 9:18 AM
ginsu planned changes to D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.

Need to update the imports for profile and additionally will add EmojiAvatarCreation for thread avatars.

Apr 13 2023, 9:18 AM
ginsu updated the diff for D7423: [native] move emoji avatar creation from profile directory to components directory.

rebase before landing

Apr 13 2023, 9:13 AM
ginsu updated the diff for D7378: [native] add edit avatar badge to thread avatar.

rebase before landing

Apr 13 2023, 9:12 AM
ginsu updated the diff for D7359: [native] implement onPressSetAvatar function.

rebase before landing

Apr 13 2023, 9:11 AM
ginsu updated the diff for D7403: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation.

fix

Apr 13 2023, 9:09 AM
ginsu added inline comments to D7403: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation.
Apr 13 2023, 9:07 AM
ginsu requested review of D7424: [native] introduce useSaveUserAvatar hook.
Apr 13 2023, 9:05 AM
ginsu requested review of D7423: [native] move emoji avatar creation from profile directory to components directory.
Apr 13 2023, 8:41 AM
ginsu closed D7402: [lib] introduce savedEmojiAvatarSelectorForCurrentUser selector.
Apr 13 2023, 8:35 AM
ginsu committed rCOMM842d73e6de51: [lib] introduce savedEmojiAvatarSelectorForCurrentUser selector (authored by ginsu).
[lib] introduce savedEmojiAvatarSelectorForCurrentUser selector
Apr 13 2023, 8:34 AM