rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
May 11 2023
May 11 2023
kamil updated the diff for D7667: [web-db] choose storage engine depending on whether database is supported or not.
rebase before landing
address review, rebase before landing
address review, rebase before landing
address review, rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
atul awarded D7787: [web-db] stop supporting Safari a Heartbreak token.
May 10 2023
May 10 2023
I tried a different approach (getting old storage inside migration) but it will not be better. We need to have a store version before the migration process, and in that case, this version is persisted via old storage, so we need to retrieve it here.
rebase
In D7658#230011, @tomek wrote:Ah, that makes sense! But now it brings more serious issue: we shouldn't just copy and paste code from a library. Ideally, we would like to avoid modification and e.g. wrap code with our logic. If that's not possible, we can e.g. patch the library. If using this code directly is the only option, we should rewrite this code using the original one as an inspiration.
re-implement function
May 9 2023
May 9 2023
kamil published D7753: [lib] introduce function to find deep difference between two objects for review.
I think this is a bit vulnerable, we fetch all the links to the client - which means if the user is not part of a given community can get possession of the invite link and join the community when I think only members of the community should invite others. Fetching invite links to communities in which the user is a part will help.
May 8 2023
May 8 2023
@tomek questions you added are valid but those are questions to the redux-persist author. I wanted to copy-paste code from source code to preserve old logic, as this returns function which will be used inside redux-persist logic. I only updated from the sync function which returns a promise - to implicitly return a promise from the async function (which will allow us to put await before any migration).
fix typo and make inputs read-only
In D7289#227557, @tomek wrote:I've left some comments with an alternative approach. Do you think it is more readable?
refactor code to avoid while (true)
Apr 27 2023
Apr 27 2023
kamil published D7667: [web-db] choose storage engine depending on whether database is supported or not for review.
commit missed line
use loop instead of recursion
refactor code
Apr 26 2023
Apr 26 2023
Apr 25 2023
Apr 25 2023
kamil published D7613: [lib] update message store threads in SQLite after setting client DB store for review.
kamil published D7612: [lib] allow missing `messageIDs` while comparing SQLite with `redux-persist` for review.
Apr 21 2023
Apr 21 2023
kamil updated the diff for D7473: [native] retrieve message store threads from SQLite and compare with `redux-persist`.
rebase before landing
kamil updated the diff for D7472: [CommCoreModule] implement logic to get message store threads from SQLite.
rebase before landing
remove operation
put easy casees first
rebase before landing
fix typo