Feed Search

Search
Use Results
Edit Query
Hide Query

Nov 13 2023

atul added a comment to D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.

Updated hasPermission here: https://phab.comm.dev/D9844

Nov 13 2023, 8:45 PM

atul added a comment to D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.

In D9841#287271, @ashoat wrote:

If this is still relevant, should I update hasPermission to always ensure that KNOW_OF bit is set?

Yes, absolutely. The default should definitely be "match existing code" – if you ever have a question like this in the future for this project, please default to matching existing code, instead of doing things differently and hoping your reviewer will notice a question in the diff summary.

Nov 13 2023, 8:29 PM

atul published D9843: [lib] Introduce `MinimallyEncodedRelativeMemberInfo` type for review.

Nov 13 2023, 8:07 PM

atul published D9842: [keyserver] Remove `test-threadstore-reductions` script for review.

Nov 13 2023, 7:50 PM

atul published D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo` for review.

Nov 13 2023, 7:28 PM

atul published D9840: [lib] Introduce `getMinimallyEncodedCurrentUser` for review.

Nov 13 2023, 6:47 PM

atul requested review of D9839: [lib] Update `memberHasAdminPowers` to handle `MinimallyEncodedMemberInfo`.

Nov 13 2023, 6:16 PM

atul accepted D9838: [web] introduce light mode to settings switcher.

Nov 13 2023, 5:29 PM

atul accepted D9837: [web] introduce light mode to relationship lists.

Nov 13 2023, 5:28 PM

atul accepted D9824: Reset badgeCount during log out.

Nov 13 2023, 5:26 PM

atul accepted D9742: [docker-compose] Update deprecated localstack config.

Actually, just make sure it's fixed before landing. Don't think it's worth requesting changes

Nov 13 2023, 5:25 PM

atul attached a referenced file: F872579: dcb8d7.png.

Nov 13 2023, 5:25 PM

atul requested changes to D9742: [docker-compose] Update deprecated localstack config.

Requesting changes because I think HLOCALSTACK_HOST should be LOCALSTACK_HOST. Feel free to re-request if I'm missing something

Nov 13 2023, 5:25 PM

Nov 11 2023

atul closed D9832: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators.

Nov 11 2023, 8:54 PM

atul closed D9811: [lib] Update signatures of thread utils to handle `MinimallyEncodedRawThreadInfo`.

Nov 11 2023, 8:54 PM

atul committed rCOMMfc6569af43d8: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators.

Nov 11 2023, 8:54 PM

atul closed D9810: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`.

Nov 11 2023, 8:54 PM

atul committed rCOMMf63bc4642c36: [lib] Update signatures of thread utils to handle….

Nov 11 2023, 8:54 PM

atul committed rCOMM3fa4720b1ea2: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`.

Nov 11 2023, 8:54 PM

atul closed D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.

Nov 11 2023, 8:54 PM

atul closed D9808: [lib] Move minimallyEncodedPermissions types/type utils to separate file.

Nov 11 2023, 8:54 PM

atul committed rCOMM8ca8ac53f847: [lib] Just cut/paste values into `minimallyEncoded` validators.

Nov 11 2023, 8:54 PM

atul committed rCOMM1669fb7522c1: [lib] Move minimallyEncodedPermissions types/type utils to separate file.

Nov 11 2023, 8:54 PM

atul updated the diff for D9808: [lib] Move minimallyEncodedPermissions types/type utils to separate file.

remove comments

Nov 11 2023, 8:49 PM

Nov 10 2023

atul requested review of D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.

Nov 10 2023, 9:23 PM

atul added a comment to D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.

Resolved by D9832

Nov 10 2023, 9:22 PM

atul published D9832: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators for review.

Nov 10 2023, 9:22 PM

atul accepted D9831: [landing] remove ted + jon and add will to team page.

Nov 10 2023, 9:15 PM

atul accepted D9823: [lib] Fix persisting of privacy settings.

Nov 10 2023, 4:50 PM

Nov 9 2023

atul requested review of D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.

Created a Linear issue here: https://linear.app/comm/issue/ENG-5692/jest-issue-with-derived-tshape-validators

Nov 9 2023, 10:18 PM

atul published D9811: [lib] Update signatures of thread utils to handle `MinimallyEncodedRawThreadInfo` for review.

Nov 9 2023, 9:47 PM

atul added inline comments to D9808: [lib] Move minimallyEncodedPermissions types/type utils to separate file.

Nov 9 2023, 9:37 PM

atul published D9810: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo` for review.

Nov 9 2023, 9:27 PM

atul published D9809: [lib] Just cut/paste values into `minimallyEncoded` validators for review.

Nov 9 2023, 9:20 PM

atul published D9808: [lib] Move minimallyEncodedPermissions types/type utils to separate file for review.

Nov 9 2023, 9:20 PM

atul closed D9788: [lib] Update `MinimallyEncoded*Info` types to be `$ReadOnly`.

Nov 9 2023, 8:00 PM

atul committed rCOMM6e7b8508c797: [lib] Update `MinimallyEncoded*Info` types to be `$ReadOnly`.

Nov 9 2023, 8:00 PM

atul updated the diff for D9788: [lib] Update `MinimallyEncoded*Info` types to be `$ReadOnly`.

reposition spreads to top

Nov 9 2023, 7:59 PM

atul added inline comments to D9788: [lib] Update `MinimallyEncoded*Info` types to be `$ReadOnly`.

Nov 9 2023, 7:53 PM

atul closed D9787: [lib] Use `RawThreadInfos` type everywhere.

Nov 9 2023, 7:49 PM

atul committed rCOMM6609133ca9dd: [lib] Use `RawThreadInfos` type everywhere.

Nov 9 2023, 7:49 PM

atul accepted D9778: [Flow202][web][skip-ci] [12/x] Fix Flow issues with computed properties.

Nov 9 2023, 7:45 PM

atul accepted D9775: [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained.

Nov 9 2023, 7:45 PM

atul accepted D9774: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated.

Nov 9 2023, 7:44 PM

atul accepted D9773: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained.

Nov 9 2023, 7:44 PM

atul accepted D9767: [Flow202][web][skip-ci] [1/x] Fix Flow issues with useDispatch / useSelector being underconstrained.

Nov 9 2023, 7:43 PM

atul requested review of D9788: [lib] Update `MinimallyEncoded*Info` types to be `$ReadOnly`.

Nov 9 2023, 1:13 AM

Nov 8 2023

atul published D9787: [lib] Use `RawThreadInfos` type everywhere for review.

Nov 8 2023, 9:39 PM

atul closed D9766: [lib] Add `minimallyEncoded` discriminator property to `MinimallyEncodedRawThreadInfo`.

Nov 8 2023, 7:02 PM

atul committed rCOMM878c958c284e: [lib] Add `minimallyEncoded` discriminator property to….

Nov 8 2023, 7:02 PM

atul published D9766: [lib] Add `minimallyEncoded` discriminator property to `MinimallyEncodedRawThreadInfo` for review.

Nov 8 2023, 6:40 PM

atul added inline comments to D5317: [web] introduced thread-picker-modal.react.

Nov 8 2023, 6:38 PM

atul requested changes to D9759: [native] cleanup SQLite handler code.

Probably missing something here.

Nov 8 2023, 5:16 PM

atul closed D9755: [lib] Introduce `decodeMinimallyEncodedRawThreadInfo`.

Nov 8 2023, 1:42 AM

atul committed rCOMM903c6924fc04: [lib] Introduce `decodeMinimallyEncodedRawThreadInfo`.

Nov 8 2023, 1:42 AM

atul updated the diff for D9755: [lib] Introduce `decodeMinimallyEncodedRawThreadInfo`.

land

Nov 8 2023, 1:41 AM

Nov 7 2023

atul closed D9752: [lib] Introduce `threadPermissionsFromBitmaskHex`.

Nov 7 2023, 8:18 PM

atul committed rCOMMb18953404f67: [lib] Introduce `threadPermissionsFromBitmaskHex`.

Nov 7 2023, 8:18 PM

atul updated the diff for D9752: [lib] Introduce `threadPermissionsFromBitmaskHex`.

land

Nov 7 2023, 8:10 PM

atul published D9755: [lib] Introduce `decodeMinimallyEncodedRawThreadInfo` for review.

Nov 7 2023, 7:57 PM

atul published D9752: [lib] Introduce `threadPermissionsFromBitmaskHex` for review.

Nov 7 2023, 6:56 PM

atul closed D9737: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo): MinimallyEncodedRawThreadInfo`.

Nov 7 2023, 6:08 PM

atul committed rCOMM0a5e5a243ab6: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo)….

Nov 7 2023, 6:08 PM

atul updated the diff for D9737: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo): MinimallyEncodedRawThreadInfo`.

improve readability by using lodash mapValues

Nov 7 2023, 6:05 PM

atul closed D9736: [lib] Introduce `MinimallyEncodedRawThreadInfo` and validator.

Nov 7 2023, 5:46 PM

atul committed rCOMM611517f6ff00: [lib] Introduce `MinimallyEncodedRawThreadInfo` and validator.

Nov 7 2023, 5:46 PM

atul updated the diff for D9736: [lib] Introduce `MinimallyEncodedRawThreadInfo` and validator.

land

Nov 7 2023, 5:45 PM

atul added inline comments to D9683: [native] stop persisting `messageStore.threads` via redux-persist.

Nov 7 2023, 5:14 PM

atul added inline comments to D9737: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo): MinimallyEncodedRawThreadInfo`.

Nov 7 2023, 5:12 PM

atul added inline comments to D9737: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo): MinimallyEncodedRawThreadInfo`.

Nov 7 2023, 5:11 PM

Nov 6 2023

atul published D9737: [lib] Introduce `minimallyEncodeRawThreadInfo(RawThreadInfo): MinimallyEncodedRawThreadInfo` for review.

Nov 6 2023, 11:28 PM

atul published D9736: [lib] Introduce `MinimallyEncodedRawThreadInfo` and validator for review.

Nov 6 2023, 10:52 PM

atul closed D9735: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

Nov 6 2023, 10:10 PM

atul committed rCOMM8485f33ca0cc: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

Nov 6 2023, 10:10 PM

atul updated the diff for D9735: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

fix test

Nov 6 2023, 10:07 PM

atul updated the diff for D9735: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

land

Nov 6 2023, 10:04 PM

atul closed D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

Nov 6 2023, 10:03 PM

atul committed rCOMMdc24c82f4bb8: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

Nov 6 2023, 10:03 PM

atul updated the diff for D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

land

Nov 6 2023, 10:02 PM

atul updated the diff for D9735: [lib] Introduce `MinimallyEncodedMemberInfo` and validator.

rebase and land

Nov 6 2023, 9:56 PM

atul closed D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

Nov 6 2023, 8:06 PM

atul committed rCOMM3023e165ac6c: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

Nov 6 2023, 8:06 PM

atul updated the diff for D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

land

Nov 6 2023, 8:00 PM

atul added inline comments to D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

Nov 6 2023, 7:57 PM

atul updated the diff for D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

update regex from {1,16} to +

Nov 6 2023, 7:55 PM

atul updated the diff for D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

update tHexEncodedRolePermission to accomodate larger strings

Nov 6 2023, 7:51 PM

atul added inline comments to D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

Nov 6 2023, 7:49 PM

atul updated the diff for D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator.

fix regex boundary and add failing test

Nov 6 2023, 7:45 PM

atul updated the diff for D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

add failing hello a02 test case

Nov 6 2023, 7:43 PM

atul updated the diff for D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

update regex to use ^ and $ instead of \b

Nov 6 2023, 7:40 PM

atul published D9735: [lib] Introduce `MinimallyEncodedMemberInfo` and validator for review.

Nov 6 2023, 7:36 PM

atul added inline comments to D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator.

Nov 6 2023, 7:36 PM

atul published D9734: [lib] Introduce `MinimallyEncodedThreadCurrentUserInfo` and validator for review.

Nov 6 2023, 7:12 PM

atul published D9731: [lib] Introduce `MinimallyEncodedRoleInfo` and validator for review.

Nov 6 2023, 5:46 PM

atul closed D9689: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray`.

Nov 6 2023, 2:55 PM

atul committed rCOMM81c82944e7c9: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray`.

Nov 6 2023, 2:55 PM

atul closed D9687: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.

Nov 6 2023, 2:55 PM

atul committed rCOMMc6d233ee7be9: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray`.

Nov 6 2023, 2:55 PM

atul updated the diff for D9689: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray`.

rebase and land

Nov 6 2023, 2:49 PM

Nov 5 2023

atul accepted D9720: [Flow202][landing][skip-ci] [2/2] Fix Flow issues in SIWE code.

Nov 5 2023, 7:34 PM