Page MenuHomePhorge
Feed Search

Apr 3 2024

tomek commandeered D4066: [web] [refactor] [ENG-536] remove old sidebar styling from side bar modal.
Apr 3 2024, 9:36 AM
tomek abandoned D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.

The task from the title https://linear.app/comm/issue/ENG-536/sidebar-list-modal-re-style - is marked as done. If we decide to do something more about that issue, it would be probably easier to do it from scratch instead of figuring out how to make this stack solve the problem.

Apr 3 2024, 9:35 AM
tomek commandeered D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.
Apr 3 2024, 9:35 AM
tomek abandoned D4060: [native, lib, web] [refactor] move text out of state.

Later in the stack, it is mentioned that this is a part of https://linear.app/comm/issue/ENG-536/sidebar-list-modal-re-style - which is marked as done. If we decide to do something more about that issue, it would be probably easier to do it from scratch instead of figuring out how to make this stack solve the problem.

Apr 3 2024, 9:34 AM
tomek commandeered D4060: [native, lib, web] [refactor] move text out of state.
Apr 3 2024, 9:33 AM
tomek added inline comments to D11530: [scripts] Improve prompt.
Apr 3 2024, 9:10 AM

Apr 2 2024

tomek accepted D11504: [lib] Allow keyserverAuth to update currentAsOf.
Apr 2 2024, 10:11 AM
tomek accepted D11503: [web] Add invalidSessionRecovery checks for web.
Apr 2 2024, 10:10 AM
tomek accepted D11502: [lib] Make invalidSessionRecovery work with all recoveryActionSources handled by KeyserverConnectionHandler.
Apr 2 2024, 10:02 AM
tomek accepted D11501: [keyserver] Don't block innerPerformAuth return on sleep.
Apr 2 2024, 9:47 AM
tomek accepted D11500: [lib] Use identity service for keyserver session recovery.
Apr 2 2024, 9:42 AM
tomek accepted D11499: [lib] Factor out innerPerformAuth for use in keyserver session recovery.
Apr 2 2024, 9:29 AM
tomek accepted D11498: [lib] Expose callKeyserverEndpoint in CallKeyserverEndpointContext.
Apr 2 2024, 9:15 AM
tomek accepted D11497: [lib] Don't invalidate a session if the recovery is cancelled.
Apr 2 2024, 9:10 AM

Mar 29 2024

tomek closed D11440: [lib] Set default state when wiping out a keyserver store.
Mar 29 2024, 1:52 PM
tomek committed rCOMMb174bc063ee3: [lib] Set default state when wiping out a keyserver store.
Mar 29 2024, 1:52 PM

Mar 28 2024

tomek requested review of D11440: [lib] Set default state when wiping out a keyserver store.
Mar 28 2024, 3:34 PM
tomek closed D11369: [lib] Create a wrapper over dispatch.
Mar 28 2024, 3:11 PM
tomek closed D11368: [native][web] Remove processing the ops from reducers.
Mar 28 2024, 3:11 PM
tomek committed rCOMM8a655eac7f4e: [lib] Create a wrapper over dispatch.
Mar 28 2024, 3:11 PM
tomek closed D11367: [lib] Handle processing of the ops.
Mar 28 2024, 3:11 PM
tomek committed rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers.
Mar 28 2024, 3:11 PM
tomek committed rCOMMf6b18846b255: [lib] Handle processing of the ops.
Mar 28 2024, 3:11 PM
tomek closed D11366: [lib] Introduce a handler that processes the ops.
Mar 28 2024, 3:11 PM
tomek committed rCOMM4f549a94bfb2: [lib] Introduce a handler that processes the ops.
Mar 28 2024, 3:11 PM
tomek closed D11281: [lib] Add an optional ID field to all the actions.
Mar 28 2024, 3:11 PM
tomek closed D11284: [native][web] Queue new ops.
Mar 28 2024, 3:11 PM
tomek committed rCOMM6bbac957a45f: [native][web] Queue new ops.
Mar 28 2024, 3:11 PM
tomek committed rCOMMb80ef60087c4: [lib] Add an optional ID field to all the actions.
Mar 28 2024, 3:11 PM
tomek closed D11280: [lib] Add a reducer that handles successful ops processing.
Mar 28 2024, 3:11 PM
tomek closed D11279: [lib] Add an action representing a successful processing.
Mar 28 2024, 3:11 PM
tomek committed rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing.
Mar 28 2024, 3:11 PM
tomek committed rCOMM4345df3c396a: [lib] Add an action representing a successful processing.
Mar 28 2024, 3:11 PM
tomek closed D11259: [lib] Create a redux store where ops will be stored.
Mar 28 2024, 3:11 PM
tomek committed rCOMMa6d8818e3171: [lib] Create a redux store where ops will be stored.
Mar 28 2024, 3:11 PM
tomek updated the diff for D11366: [lib] Introduce a handler that processes the ops.

Rebase

Mar 28 2024, 2:44 PM
tomek updated the diff for D11281: [lib] Add an optional ID field to all the actions.

Rebase

Mar 28 2024, 2:42 PM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

Rebase

Mar 28 2024, 2:41 PM
tomek updated the diff for D11369: [lib] Create a wrapper over dispatch.

Rename

Mar 28 2024, 2:04 PM
tomek updated the diff for D11368: [native][web] Remove processing the ops from reducers.

Rename and invert a condition

Mar 28 2024, 11:59 AM
tomek added inline comments to D11367: [lib] Handle processing of the ops.
Mar 28 2024, 11:05 AM
tomek accepted D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Mar 28 2024, 10:54 AM

Mar 27 2024

tomek requested review of D11369: [lib] Create a wrapper over dispatch.
Mar 27 2024, 4:18 PM
tomek requested review of D11368: [native][web] Remove processing the ops from reducers.
Mar 27 2024, 4:15 PM
tomek requested review of D11367: [lib] Handle processing of the ops.
Mar 27 2024, 4:13 PM
tomek updated the summary of D11366: [lib] Introduce a handler that processes the ops.
Mar 27 2024, 3:56 PM
tomek updated the summary of D11366: [lib] Introduce a handler that processes the ops.
Mar 27 2024, 3:55 PM
tomek updated the diff for D11366: [lib] Introduce a handler that processes the ops.

Use the new approach where we have only one queue and process the ops one by one

Mar 27 2024, 3:54 PM
tomek updated the summary of D11284: [native][web] Queue new ops.
Mar 27 2024, 3:53 PM
tomek updated the diff for D11284: [native][web] Queue new ops.

Update queueing logic

Mar 27 2024, 3:51 PM
tomek added a comment to D11281: [lib] Add an optional ID field to all the actions.

After today's meeting, I wonder if we still need to add this ID to all actions

Mar 27 2024, 3:50 PM
tomek updated the diff for D11281: [lib] Add an optional ID field to all the actions.

Rebase

Mar 27 2024, 3:48 PM
tomek updated the summary of D11280: [lib] Add a reducer that handles successful ops processing.
Mar 27 2024, 3:47 PM
tomek updated the diff for D11280: [lib] Add a reducer that handles successful ops processing.

Simplify

Mar 27 2024, 3:45 PM
tomek updated the diff for D11279: [lib] Add an action representing a successful processing.

Simplify the action

Mar 27 2024, 2:28 PM
tomek updated the summary of D11259: [lib] Create a redux store where ops will be stored.
Mar 27 2024, 2:27 PM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

Update the types

Mar 27 2024, 2:26 PM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

Keep only one queue
https://linear.app/comm/issue/ENG-7040/implement-generating-and-awaiting-processed-ops#comment-bc0834f4

Mar 27 2024, 11:36 AM
tomek accepted D11390: [keyserver][lib] Introduce relationshipActions.FARCASTER_MUTUAL.
Mar 27 2024, 8:58 AM

Mar 25 2024

tomek closed D11354: [web] Introduce a migration that adds an actualizedCalendarQuery.
Mar 25 2024, 2:13 PM
tomek committed rCOMM4454bfe362d2: [web] Introduce a migration that adds an actualizedCalendarQuery.
Mar 25 2024, 2:13 PM
tomek accepted D11376: [keyserver] Debounce one-time key refresh request.

This looks reasonable, but I'm wondering if we shouldn't solve this on Identity service: it knows how many keys are there, and how many keys are needed to fulfill requests, and could ask a keyserver for the appropriate number. Also, it should know that a keyserver was asked for the keys recently and can decide either to not ask for more or to ask for e.g. only one more.

Mar 25 2024, 1:51 PM
tomek accepted D11375: [keyserver] Make keyserver handle one-time key refresh requests sequentially.
Mar 25 2024, 1:43 PM
tomek accepted D11374: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success.
Mar 25 2024, 1:16 PM

Mar 22 2024

tomek accepted D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Mar 22 2024, 5:09 PM
tomek requested changes to D9091: Schedule blob deletion on iOS.

Similar to Android - shouldn't we have a separate holder for each recipient?

Mar 22 2024, 4:42 PM
tomek requested changes to D9069: Schedule blob deletion on Android when large notifications arrives.

When creating a blob, we're setting one holder for the content. Then we send the same hash and holder to multiple recipients. After the processing, the recipient schedules blob deletion which means that other recipients may be unable to download the blob - as it is already deleted.

Mar 22 2024, 4:37 PM
tomek accepted D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.

All the comments are minor except the one about badgeOnly handling which seems confusing.

Mar 22 2024, 4:05 PM
tomek accepted D11349: [native] migrate integrityStore to SQLite.

At some point we should also blacklist integrityStore on native so that it isn't persisted using redux-persist

Mar 22 2024, 3:40 PM
tomek added inline comments to D11349: [native] migrate integrityStore to SQLite.
Mar 22 2024, 11:22 AM

Mar 21 2024

tomek requested review of D11366: [lib] Introduce a handler that processes the ops.
Mar 21 2024, 3:32 PM
tomek updated the diff for D11284: [native][web] Queue new ops.

Generate an ID if it isn't provided

Mar 21 2024, 3:10 PM
tomek updated the diff for D11280: [lib] Add a reducer that handles successful ops processing.

Simplify reducer logic

Mar 21 2024, 3:08 PM
tomek updated the diff for D11279: [lib] Add an action representing a successful processing.

Simplify the action

Mar 21 2024, 3:04 PM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

We don't need a second ID - removing the ops ID

Mar 21 2024, 3:02 PM
tomek added inline comments to D11284: [native][web] Queue new ops.
Mar 21 2024, 12:10 PM
tomek updated the diff for D11284: [native][web] Queue new ops.

Rebase, rename

Mar 21 2024, 12:10 PM
tomek updated the diff for D11281: [lib] Add an optional ID field to all the actions.

Rebase, update Redux types

Mar 21 2024, 12:07 PM
tomek updated the diff for D11280: [lib] Add a reducer that handles successful ops processing.

Rename, rebase

Mar 21 2024, 12:05 PM
tomek updated the diff for D11279: [lib] Add an action representing a successful processing.

Rebase

Mar 21 2024, 12:01 PM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

Update types

Mar 21 2024, 11:59 AM
tomek updated the diff for D11259: [lib] Create a redux store where ops will be stored.

Add a comment. Update the types.

Mar 21 2024, 11:56 AM
tomek accepted D11365: [lib] Fix auth with non authoritative keyserver error.
Mar 21 2024, 8:38 AM
tomek added inline comments to D11349: [native] migrate integrityStore to SQLite.
Mar 21 2024, 7:56 AM

Mar 20 2024

tomek accepted D11359: [lib] integrity reducer tests.
Mar 20 2024, 12:22 PM
tomek accepted D11358: [native][web] Read integrity thread hashes from SQLite on app start.
Mar 20 2024, 12:21 PM
tomek accepted D11357: [native][web] Start processing integrity store with sqlite operations.
Mar 20 2024, 12:06 PM
tomek requested changes to D11349: [native] migrate integrityStore to SQLite.
Mar 20 2024, 12:02 PM

Mar 19 2024

tomek requested review of D11354: [web] Introduce a migration that adds an actualizedCalendarQuery.
Mar 19 2024, 3:46 PM
tomek accepted D11333: [lib] Split implementations of `[client/server]ThreadInfoFromRawThreadInfo`.
Mar 19 2024, 12:21 PM
tomek accepted D11318: [lib] Introduce `threadInfoFromRawThreadInfo` wrapper that computes `currentUser` and passes to `baseThreadInfoFromRawThreadInfo`.

After reading the description it sounds like

By updating memberHasAdminPowers and appendUserInfo to depend on community root roles instead of computed member.permissions, we can avoid storing/persisting/sending that data to the clients.

is the main goal. What is the impact of doing this? How much can we save?

Mar 19 2024, 12:17 PM
tomek accepted D11317: [lib] Update `clientThreadFrozenDueToBlock` and `getMinimallyEncodedCurrentUser` signatures to include `communityThreadInfo`.

It seems like changing the code to check permissions in communityThreadInfo is a huge amount of work. Could you explain why we have to do this and what are the consequences of not doing it?

Mar 19 2024, 12:11 PM
tomek accepted D11308: [native][web] Update `ChatInputBar` to pass `communityThreadInfo` to `threadFrozenDueToViewerBlock`.
Mar 19 2024, 12:07 PM
tomek accepted D11311: [lib] Separate `serverThreadFrozenDueToBlock` and `clientThreadFrozenDueToBlock`.

Separate serverThreadFrozenDueToBlock and clientThreadFrozenDueToBlock

Why do we want to do that?

Mar 19 2024, 12:04 PM
tomek accepted D11286: [lib] Introduce `persistedRoleInfoValidator` and use in `convertClientDBThreadInfoToRawThreadInfo`.
Mar 19 2024, 12:01 PM
tomek accepted D11276: [lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex`.
Mar 19 2024, 10:40 AM
tomek added inline comments to D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Mar 19 2024, 10:35 AM

Mar 18 2024

tomek requested review of D11281: [lib] Add an optional ID field to all the actions.

Can you explain more about why it's necessary to include these field on all actions?

We need to know when the processing of an action is finished. This processing consists of generating 0 or more ops and applying them on the DB. We're introducing a new store, where the ops will be put and a handler that listens for new ops, applies them on the DB, and removes them from the store.

Mar 18 2024, 3:56 PM
tomek added a comment to D11271: [lib] Don't sync users with non-authoritative keyservers.

Is this is a temporary hack, shouldn't we have a Linear task to revert it?

Mar 18 2024, 8:53 AM

Mar 8 2024

tomek requested review of D11284: [native][web] Queue new ops.
Mar 8 2024, 5:30 PM