rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
May 6 2024
May 6 2024
ginsu requested review of D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.
Now that D11865 is landed, there will most likely be merge conflicts with neynar-client.js
ginsu updated the diff for D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
rebase before landing
ginsu updated the summary of D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.
ginsu updated the summary of D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
ginsu added a comment to D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
Removing this diff from the diff stack so that I can land as is.
ginsu added inline comments to D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
ginsu updated the summary of D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.
Removing this diff from the diff stack and will address the feedback for this in a separate diff stack
ginsu updated the diff for D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
address comments
ginsu added inline comments to D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
May 5 2024
May 5 2024
Like this idea a lot!
Figured these names would be less ambiguous, but open to other ideas.
May 4 2024
May 4 2024
address comments
address comments
May 3 2024
May 3 2024
Improve error handling
ginsu published D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel for review.
will make sure ci passes before landing
ginsu requested review of D11865: [lib] introduce fetchFarcasterChannelByName to neynar client class.
will make sure ci passes before landing
ginsu requested review of D11855: [native] introduce navigational logic for TagUnfollowedFarcasterChannel screen.
will make sure ci passes before landing
will make sure ci passes before landing
I considered implementing this at the FarcasterWebView layer, so that FarcasterAccountSettings and ConnectFarcasterBottomSheet could use it. But those screens will call the identity service immediately, so there's no point "pre-checking" with the identity service.
May 2 2024
May 2 2024
rebase before landing
rebase before landing
address comments + rebase before landing
address comments + rebase before landing
Apr 30 2024
Apr 30 2024
Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time
address comments + rebase before landing
rebase before landing
Apr 29 2024
Apr 29 2024
rebase before landing
ginsu updated the diff for D11784: [native] update selectedChannel state to be a FarcasterChannel type.
rebase before landing
rebase before landing
rebase before landing
rebase before landing
ginsu updated the diff for D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
rebase before landing
ginsu added a comment to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Going to land this diff now, but overall agree with the feedback regarding that reviewing this work would be easier to follow if I initially sequenced the work better. Will make sure that next time I introduce endpoints or work more in the keyserver code I think more critically on this.
ginsu updated the diff for D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.
address comments
Apr 26 2024
Apr 26 2024