Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

Jun 2 2025

bartek closed D14797: [native] Update Rust functions to use random backup keys.
Jun 2 2025, 2:04 PM
bartek committed rCOMM6cdcc516e96d: [native] Update createMainCompaction to use random backup keys.
Jun 2 2025, 2:04 PM
bartek closed D14796: [native] Pass generateBackupDataKey to Rust.
Jun 2 2025, 2:04 PM
bartek committed rCOMMeaab174a6946: [native] Update Rust functions to use random backup keys.
Jun 2 2025, 2:04 PM
bartek committed rCOMMd853ccb7d92e: [native] Pass generateBackupDataKey to Rust.
Jun 2 2025, 2:04 PM
bartek updated the diff for D14798: [native] Update createMainCompaction to use random backup keys.

Apply refactor suggestion

Jun 2 2025, 1:32 PM
bartek updated the diff for D14796: [native] Pass generateBackupDataKey to Rust.

Refactor

Jun 2 2025, 1:20 PM
bartek published D14798: [native] Update createMainCompaction to use random backup keys for review.
Jun 2 2025, 11:31 AM
bartek published D14797: [native] Update Rust functions to use random backup keys for review.
Jun 2 2025, 11:31 AM
bartek published D14796: [native] Pass generateBackupDataKey to Rust for review.
Jun 2 2025, 11:31 AM
bartek closed D14786: [native_rust_lib] Make backup upload handler thread safe.
Jun 2 2025, 9:54 AM
bartek committed rCOMM4023ea9efdbc: [native_rust_lib] Make backup upload handler thread safe.
Jun 2 2025, 9:54 AM
bartek closed D14794: [native] Fix restore API call order.
Jun 2 2025, 9:54 AM
bartek closed D14785: [native] Display appropriate alerts when restore fails.
Jun 2 2025, 9:54 AM
bartek committed rCOMMd71667e6e8c7: [native] Display appropriate alerts when restore fails.
Jun 2 2025, 9:54 AM
bartek committed rCOMMd272f07869bc: [native] Fix restore API call order.
Jun 2 2025, 9:54 AM
bartek closed D14784: [native] Define alert messages for restoration errors.
Jun 2 2025, 9:54 AM
bartek committed rCOMM7c30ca48536c: [native] Define alert messages for restoration errors.
Jun 2 2025, 9:54 AM
bartek published D14795: [native] Use AsyncMutex for logs for review.
Jun 2 2025, 9:34 AM
bartek updated the diff for D14786: [native_rust_lib] Make backup upload handler thread safe.

Rebase, add suggested improvement

Jun 2 2025, 9:27 AM
bartek accepted D14780: [lib] implement restored SQLite data migrations using JS.

Looks good to me, and given examples look reasonable too, but I'm not an expert in migrations

Jun 2 2025, 9:23 AM
bartek accepted D14793: [native][web] deprecate `getSyncedDatabaseVersion`.
Jun 2 2025, 9:18 AM
bartek accepted D14791: [lib] checking database and store version before restoring.
Jun 2 2025, 9:12 AM
bartek accepted D14790: [lib][web] extract restoring user data to hook.
Jun 2 2025, 9:10 AM
bartek accepted D14789: [lib][native][web] implement handler to sync store version.
Jun 2 2025, 9:03 AM
bartek accepted D14788: [web] refactor code to get query executor.
Jun 2 2025, 9:02 AM
bartek accepted D14787: [lib][native][web] implement getting `synced_metadata` entry.
Jun 2 2025, 9:01 AM

May 31 2025

bartek published D14794: [native] Fix restore API call order for review.
May 31 2025, 8:15 AM

May 30 2025

bartek accepted D14774: [native] set `latestDatabaseVersion` after uploading User Data.
May 30 2025, 7:10 AM
bartek accepted D14772: [native] add `latestDatabaseVersion` to `BackupStore`.
May 30 2025, 7:09 AM

May 29 2025

bartek published D14786: [native_rust_lib] Make backup upload handler thread safe for review.
May 29 2025, 2:33 PM
bartek added inline comments to D14773: [native] trigger User Data upload after schema change.
May 29 2025, 9:55 AM
bartek accepted D14773: [native] trigger User Data upload after schema change.
May 29 2025, 9:49 AM
bartek accepted D14770: [web][native] expose method to get database version.
May 29 2025, 9:43 AM
bartek accepted D14768: [SQLite] implement `DatabaseQueryExecutor` method to get database version.
May 29 2025, 9:41 AM
bartek published D14785: [native] Display appropriate alerts when restore fails for review.
May 29 2025, 9:40 AM
bartek updated the diff for D14784: [native] Define alert messages for restoration errors.

Rebase

May 29 2025, 9:02 AM
bartek updated the diff for D14784: [native] Define alert messages for restoration errors.

Fix typos

May 29 2025, 8:44 AM
bartek closed D14779: [web][native] Display network error alert in QR flow.
May 29 2025, 8:41 AM
bartek committed rCOMM4ea79a50c0b3: [web][native] Display network error alert in QR flow.
May 29 2025, 8:41 AM
bartek closed D14778: [native] Display network error alert during restore flow.
May 29 2025, 8:41 AM
bartek committed rCOMM182a40e017a7: [native] Display network error alert during restore flow.
May 29 2025, 8:41 AM
bartek closed D14777: [web] Handle grpc-web network errors.
May 29 2025, 8:41 AM
bartek committed rCOMMcc1ecabf91be: [web] Handle grpc-web network errors.
May 29 2025, 8:41 AM
bartek closed D14776: [backup-client] Handle reqwest network errors.
May 29 2025, 8:41 AM
bartek committed rCOMM7501e47fe51a: [backup-client] Handle reqwest network errors.
May 29 2025, 8:41 AM
bartek closed D14775: [native] Handle Tonic gPRC network errors.
May 29 2025, 8:41 AM
bartek committed rCOMM280659d8d495: [native] Handle Tonic gPRC network errors.
May 29 2025, 8:41 AM

May 28 2025

bartek published D14784: [native] Define alert messages for restoration errors for review.
May 28 2025, 7:59 PM
bartek accepted D14765: [web] implement persisting restored database.
May 28 2025, 1:43 PM
bartek closed D14781: [terraform] Bump staging Identity to 0.53.0.
May 28 2025, 1:27 PM
bartek committed rCOMM80b85c5561f2: [terraform] Bump staging Identity to 0.53.0.
May 28 2025, 1:27 PM
bartek accepted D14767: [native] update clearing sensitive data to delete restored database.
May 28 2025, 1:22 PM
bartek accepted D14766: [web] update clearing sensitive data to delete restored database.
May 28 2025, 1:20 PM
bartek added inline comments to D14765: [web] implement persisting restored database.
May 28 2025, 1:19 PM
bartek accepted D14764: [native][web] add `plaintextDatabasePath` to `restoreFromMainCompaction`.

Nice

May 28 2025, 1:15 PM
bartek published D14781: [terraform] Bump staging Identity to 0.53.0 for review.
May 28 2025, 1:10 PM
bartek accepted D14755: [native][web] update `getClientDBStore` to handle multiple databases.
May 28 2025, 1:06 PM
bartek accepted D14754: [native][web] update `processDBStoreOperations` to handle multiple databases.
May 28 2025, 12:55 PM
bartek closed D14760: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs.
May 28 2025, 10:36 AM
bartek closed D14759: [identity] Implement devices filter for X3DH RPCs.
May 28 2025, 10:36 AM
bartek committed rCOMM88b5108d6f46: [identity] Implement devices filter for X3DH RPCs.
May 28 2025, 10:36 AM
bartek committed rCOMM09f288c96a1d: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs.
May 28 2025, 10:36 AM
bartek closed D14758: [proto] Add devices filter param to X3DH RPC requests.
May 28 2025, 10:36 AM
bartek committed rCOMM868685472d1b: [proto] Add devices filter param to X3DH RPC requests.
May 28 2025, 10:36 AM
bartek published D14779: [web][native] Display network error alert in QR flow for review.
May 28 2025, 10:23 AM
bartek published D14778: [native] Display network error alert during restore flow for review.
May 28 2025, 10:23 AM
bartek published D14777: [web] Handle grpc-web network errors for review.
May 28 2025, 10:20 AM
bartek published D14776: [backup-client] Handle reqwest network errors for review.
May 28 2025, 10:18 AM
bartek published D14775: [native] Handle Tonic gPRC network errors for review.
May 28 2025, 10:17 AM
bartek accepted D14753: [native] add `DatabaseIdentifier` to `DBOperationBase::execute`.
May 28 2025, 7:26 AM
bartek accepted D14752: [web][native] add migrate schema and copy database content steps when restoring.
May 28 2025, 7:24 AM
bartek accepted D14751: [web][native] add to `SQLiteAPI` methods to migrate schema and copy database content.
May 28 2025, 7:23 AM
bartek added a comment to D14758: [proto] Add devices filter param to X3DH RPC requests.

Adding @ashoat because of proto changes

May 28 2025, 7:16 AM
bartek added 1 blocking reviewer(s) for D14758: [proto] Add devices filter param to X3DH RPC requests: ashoat.
May 28 2025, 7:16 AM

May 27 2025

bartek added a comment to D14758: [proto] Add devices filter param to X3DH RPC requests.
In D14758#408158, @kamil wrote:

I would also test the other backward compatibility, when the client is "newer" than the service, just to make sure we avoid issues like D14715

May 27 2025, 3:57 PM
bartek accepted D14750: [web][native] set database version when restoring.
May 27 2025, 8:51 AM
bartek accepted D14749: [web] bind `SQLiteQueryExecutor::migrate`.
May 27 2025, 8:49 AM
bartek accepted D14748: [web][native] create two `SQLiteQueryExecutor` instances.
May 27 2025, 8:49 AM
bartek accepted D14746: [native] rename `DatabaseManager::connectionManager` -> `DatabaseManager::mainConnectionManager`.
May 27 2025, 8:38 AM
bartek accepted D14745: [web][native] introduce `DatabaseIdentifier` to be able to specify database.
May 27 2025, 8:38 AM

May 26 2025

bartek closed D14762: [lib] Gracefully handle sending failure of SECONDARY_DEVICE_REGISTRATION_SUCCESS.
May 26 2025, 2:09 PM
bartek committed rCOMM25b84b412be2: [lib] Gracefully handle sending failure of SECONDARY_DEVICE_REGISTRATION_SUCCESS.
May 26 2025, 2:09 PM
bartek closed D14761: [backup-client] Fix unnecessary user data cloning.
May 26 2025, 2:09 PM
bartek committed rCOMM5ac69684cc00: [backup-client] Fix unnecessary user data cloning.
May 26 2025, 2:09 PM
bartek published D14762: [lib] Gracefully handle sending failure of SECONDARY_DEVICE_REGISTRATION_SUCCESS for review.
May 26 2025, 12:35 PM
bartek published D14761: [backup-client] Fix unnecessary user data cloning for review.
May 26 2025, 12:33 PM
bartek published D14760: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs for review.
May 26 2025, 12:21 PM
bartek closed D14675: [native] Pass backup size, timestamp and version info to JS.
May 26 2025, 11:59 AM
bartek committed rCOMM8b776350234b: [native] Pass backup size, timestamp and version info to JS.
May 26 2025, 11:59 AM
bartek accepted D14734: [SQLite] make `connectionManager` to be local prop `SQLiteQueryExecutor` and move management to `DatabaseManager`.
May 26 2025, 10:31 AM
bartek accepted D14730: [SQLite] move `validateEncryption` to `SQLiteConnectionManager`.
May 26 2025, 10:28 AM
bartek updated the diff for D14675: [native] Pass backup size, timestamp and version info to JS.

Rebase. Revert temporary changes to defaults

May 26 2025, 10:26 AM
bartek closed D14757: [terraform] Deploy services to prod.
May 26 2025, 10:18 AM
bartek committed rCOMM90ea61c713b0: [terraform] Deploy services to prod.
May 26 2025, 10:18 AM
bartek published D14759: [identity] Implement devices filter for X3DH RPCs for review.
May 26 2025, 10:14 AM
bartek published D14758: [proto] Add devices filter param to X3DH RPC requests for review.
May 26 2025, 10:14 AM
bartek added inline comments to D14734: [SQLite] make `connectionManager` to be local prop `SQLiteQueryExecutor` and move management to `DatabaseManager`.
May 26 2025, 9:30 AM
bartek accepted D14744: [SQLite] make it possible to skip migrations in `SQLiteQueryExecutor` constructor.
May 26 2025, 9:28 AM
bartek accepted D14743: [SQLite] factor out `restoreFromMainCompaction` from `SQLiteQueryExecutor`.
May 26 2025, 9:24 AM
First
Prev
Next