Rename lib, update Dockerfiles and list services script
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 27 2023
- Identity service also uses these functions.
Haven't figured out how to send a request from host, but verifying that is the next step.
Not sure what you exactly mean, but docker-compose exposes the service port to host, so you should be able to simply
yarn run-feature-flags-service-in-sandbox # in a separate terminal curl "http://localhost:50055/features?platform=..." # etc
Make code more readable and make platfor case-insensitive
Rebase. Use to_owned instead of clone
Bind IPv6 address
Rebase and simplify code version check
I've created a task where we can discuss the caching https://linear.app/comm/issue/ENG-3082/consider-using-cache-in-feature-flags-service. I think it is really not worth it in near future, as it greatly increases the complexity and doesn't introduce measurable value.
Rebase and introduce platform constants
Rebase
Reabase and make error handling more consistent with other places.
Extarct common code into a lib
In D6854#204407, @ashoat wrote:This seems like it would've been a great time to introduce a shared library instead of copy-pasting. I understand there is a monthly goal at play here, but how long does it really take to set up a shared library? In JavaScript it can be done in ~15min, but I'm not as familiar with Rust
Feb 24 2023
Feb 23 2023
Feb 22 2023
Feb 21 2023
In D6634#201769, @ginsu wrote:The video from the test plan doesn't load for me - it is displayed but the spinner is present for a couple of minutes now. Could you describe your test plan in words? It also might be a good idea to have shorter and smaller (with only the relevant portion of the screen) videos.
Hmm strange it's not loading for me either. Regardless we don't need it anymore since I will create new ones here shortly
Looks ok, but I haven't verified the complicated logic. It would be great if we had some tests checking it, or at least it should be covered in a test plan.
It is a good practice to be more explicit in the test plan. Saying that there are no regression doesn't allow the reviewer to verify if all the important cases were covered.
Feb 17 2023
Feb 16 2023
Feb 15 2023
How about the case where we detect that an update is available, we stop an interval and then downloading the update fails?
The video from the test plan doesn't load for me - it is displayed but the spinner is present for a couple of minutes now. Could you describe your test plan in words? It also might be a good idea to have shorter and smaller (with only the relevant portion of the screen) videos.
Feb 14 2023
Is there a better solution for this? The fact that we have to be aware that an import has different variants might cause maintainability issues in the future.
Feb 13 2023
Feb 10 2023
On both platforms all the borders are present (according to the test plan). The only difference is that all the colors on iOS look less saturated, but if we really want to address that, we should do it as a separate task.
Feb 9 2023
Overall looks good, but there are a couple of minor comments and I would like to see this code after the changes are applied.
The summary can be improved a bit
checked null values in measureMessages method.
This can be replaced by more correct description, e.g.
modified measureMessages method so that it can handle the case where messages is null