Page MenuHomePhabricator
Feed Advanced Search

Feb 27 2023

tomek added inline comments to D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 8:13 AM
tomek updated the diff for D6854: [services] Extract common database code to a separate lib.

Rename lib, update Dockerfiles and list services script

Feb 27 2023, 7:20 AM
tomek added a comment to D6854: [services] Extract common database code to a separate lib.
  • Identity service also uses these functions.
Feb 27 2023, 6:44 AM
tomek added a comment to D6886: [services][feature-flags] Dockerize the service.

Haven't figured out how to send a request from host, but verifying that is the next step.

Not sure what you exactly mean, but docker-compose exposes the service port to host, so you should be able to simply

yarn run-feature-flags-service-in-sandbox
# in a separate terminal
curl "http://localhost:50055/features?platform=..." # etc
Feb 27 2023, 6:12 AM
tomek updated the diff for D6862: [services][feature-flags] Connect http service with database.

Make code more readable and make platfor case-insensitive

Feb 27 2023, 6:03 AM
tomek added inline comments to D6862: [services][feature-flags] Connect http service with database.
Feb 27 2023, 6:02 AM
tomek planned changes to D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 6:00 AM
tomek added inline comments to D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 27 2023, 5:37 AM
tomek updated the diff for D6861: [services][feature-flags] Introduce `features` endpoint.

Rebase. Use to_owned instead of clone

Feb 27 2023, 5:19 AM
tomek added inline comments to D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 27 2023, 4:59 AM
tomek updated the test plan for D6860: [services][feature-flags] Add hello world http server.
Feb 27 2023, 4:56 AM
tomek updated the diff for D6860: [services][feature-flags] Add hello world http server.

Bind IPv6 address

Feb 27 2023, 4:56 AM
tomek added inline comments to D6860: [services][feature-flags] Add hello world http server.
Feb 27 2023, 4:45 AM
tomek updated the diff for D6858: [services][feature-flags] Determine enabled features set.

Rebase and simplify code version check

Feb 27 2023, 4:35 AM
tomek added a comment to D6858: [services][feature-flags] Determine enabled features set.

I've created a task where we can discuss the caching https://linear.app/comm/issue/ENG-3082/consider-using-cache-in-feature-flags-service. I think it is really not worth it in near future, as it greatly increases the complexity and doesn't introduce measurable value.

Feb 27 2023, 4:21 AM
tomek updated the test plan for D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 4:06 AM
tomek updated the diff for D6857: [services][feature-flags] Query the db.

Rebase and introduce platform constants

Feb 27 2023, 4:02 AM
tomek added inline comments to D6857: [services][feature-flags] Query the db.
Feb 27 2023, 3:57 AM
tomek updated the diff for D6856: [services][feature-flags] Parse feature flags response from DynamoDB.

Rebase

Feb 27 2023, 3:54 AM
tomek added inline comments to D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
Feb 27 2023, 3:52 AM
tomek updated the diff for D6855: [services][feature-flags] Introduce map and i32 parsing.

Reabase and make error handling more consistent with other places.

Feb 27 2023, 3:38 AM
tomek added inline comments to D6855: [services][feature-flags] Introduce map and i32 parsing.
Feb 27 2023, 3:37 AM
tomek requested review of D6854: [services] Extract common database code to a separate lib.
Feb 27 2023, 3:25 AM
tomek retitled D6854: [services] Extract common database code to a separate lib from [services][feature-flags] Copy DynamoDB utils from other services to [services] Extract common database code to a separate lib.
Feb 27 2023, 3:23 AM
tomek updated the diff for D6854: [services] Extract common database code to a separate lib.

Extarct common code into a lib

Feb 27 2023, 3:22 AM
tomek added a comment to D6854: [services] Extract common database code to a separate lib.

This seems like it would've been a great time to introduce a shared library instead of copy-pasting. I understand there is a monthly goal at play here, but how long does it really take to set up a shared library? In JavaScript it can be done in ~15min, but I'm not as familiar with Rust

Feb 27 2023, 1:59 AM
tomek added inline comments to D6853: [services][feature-flags] Describe feature flags table in terraform.
Feb 27 2023, 1:53 AM
tomek accepted D6815: [keyserver/ web] Handle device_token on web.
Feb 27 2023, 1:03 AM

Feb 24 2023

tomek requested review of D6886: [services][feature-flags] Dockerize the service.
Feb 24 2023, 8:31 AM
tomek accepted D6816: [web] Change import path and fix errors showing up when the typing is correct.
Feb 24 2023, 2:25 AM
tomek requested changes to D6634: [web] implement emoji keyboard position into message tooltip.
Feb 24 2023, 1:51 AM

Feb 23 2023

tomek requested review of D6862: [services][feature-flags] Connect http service with database.
Feb 23 2023, 8:59 AM
tomek requested review of D6861: [services][feature-flags] Introduce `features` endpoint.
Feb 23 2023, 8:58 AM
tomek requested review of D6860: [services][feature-flags] Add hello world http server.
Feb 23 2023, 8:54 AM
tomek requested review of D6859: [services][feature-flags] Add configuration for http server.
Feb 23 2023, 8:49 AM
tomek requested review of D6858: [services][feature-flags] Determine enabled features set.
Feb 23 2023, 8:46 AM
tomek requested review of D6857: [services][feature-flags] Query the db.
Feb 23 2023, 8:34 AM
tomek requested review of D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
Feb 23 2023, 8:30 AM
tomek requested review of D6855: [services][feature-flags] Introduce map and i32 parsing.
Feb 23 2023, 7:43 AM
tomek requested review of D6853: [services][feature-flags] Describe feature flags table in terraform.
Feb 23 2023, 7:31 AM
tomek requested review of D6854: [services] Extract common database code to a separate lib.
Feb 23 2023, 7:21 AM
tomek requested review of D6852: [services][feature-flags] Introduce constants for accessing DynamoDB table.
Feb 23 2023, 6:52 AM

Feb 22 2023

tomek added inline comments to D6632: [web] introduce the getEmojiKeyboardPosition function.
Feb 22 2023, 1:39 AM
tomek accepted D6634: [web] implement emoji keyboard position into message tooltip.
Feb 22 2023, 1:32 AM

Feb 21 2023

tomek accepted D6782: [web] Fix tabs in modals displaying incorrectly.
Feb 21 2023, 8:31 AM
tomek requested changes to D6634: [web] implement emoji keyboard position into message tooltip.
Feb 21 2023, 8:22 AM
tomek requested changes to D6782: [web] Fix tabs in modals displaying incorrectly.
Feb 21 2023, 7:04 AM
tomek requested changes to D6634: [web] implement emoji keyboard position into message tooltip.
In D6634#201769, @ginsu wrote:

The video from the test plan doesn't load for me - it is displayed but the spinner is present for a couple of minutes now. Could you describe your test plan in words? It also might be a good idea to have shorter and smaller (with only the relevant portion of the screen) videos.

Hmm strange it's not loading for me either. Regardless we don't need it anymore since I will create new ones here shortly

Feb 21 2023, 2:43 AM
tomek accepted D6632: [web] introduce the getEmojiKeyboardPosition function.

Looks ok, but I haven't verified the complicated logic. It would be great if we had some tests checking it, or at least it should be covered in a test plan.

Feb 21 2023, 2:36 AM
tomek accepted D6786: [web] factor out app container position info logic out of tooltip utils.

It is a good practice to be more explicit in the test plan. Saying that there are no regression doesn't allow the reviewer to verify if all the important cases were covered.

Feb 21 2023, 1:00 AM

Feb 17 2023

tomek accepted D6746: [web] Add a selector for getting the item currently selected in the drawer.
Feb 17 2023, 12:42 AM

Feb 16 2023

tomek accepted D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.
Feb 16 2023, 2:09 AM

Feb 15 2023

tomek requested changes to D6683: [desktop] Continue checking for updates even after an exception.

How about the case where we detect that an update is available, we stop an interval and then downloading the update fails?

Feb 15 2023, 2:21 AM
tomek added inline comments to D6660: [native] Allow user to ‘see more’ on native and navigate to a full screen gallery.
Feb 15 2023, 2:13 AM
tomek added inline comments to D6659: [native] Display both photos and videos in the media gallery on native.
Feb 15 2023, 2:11 AM
tomek requested changes to D6634: [web] implement emoji keyboard position into message tooltip.

The video from the test plan doesn't load for me - it is displayed but the spinner is present for a couple of minutes now. Could you describe your test plan in words? It also might be a good idea to have shorter and smaller (with only the relevant portion of the screen) videos.

Feb 15 2023, 2:08 AM
tomek requested changes to D6632: [web] introduce the getEmojiKeyboardPosition function.
Feb 15 2023, 2:00 AM

Feb 14 2023

tomek accepted D6729: [native] Omit extensions when importing components with platform-specific extensions.

Is there a better solution for this? The fact that we have to be aware that an import has different variants might cause maintainability issues in the future.

Feb 14 2023, 4:24 AM
tomek accepted D6685: [native] [ENG-2207] Too big notifications when the message is long.
Feb 14 2023, 4:15 AM
tomek added inline comments to D6687: [services][feature-flags] Introduce AWS config.
Feb 14 2023, 2:31 AM

Feb 13 2023

tomek accepted D6711: [web] Update to react-switch@7.0.0.
Feb 13 2023, 6:05 AM
tomek closed D6687: [services][feature-flags] Introduce AWS config.
Feb 13 2023, 5:12 AM
tomek committed rCOMM439d162b4fbb: [services][feature-flags] Introduce AWS config (authored by tomek).
[services][feature-flags] Introduce AWS config
Feb 13 2023, 5:12 AM
tomek closed D6666: [services][feature-flags] Introduce command line arguments.
Feb 13 2023, 5:12 AM
tomek closed D6664: [services][feature-flags] Set up the logger.
Feb 13 2023, 5:12 AM
tomek committed rCOMM5e2bd01d038e: [services][feature-flags] Set up the logger (authored by tomek).
[services][feature-flags] Set up the logger
Feb 13 2023, 5:12 AM
tomek committed rCOMMb171815db35a: [services][feature-flags] Introduce command line arguments (authored by tomek).
[services][feature-flags] Introduce command line arguments
Feb 13 2023, 5:12 AM
tomek closed D6663: [services][feature-flags] Set up a new Rust project.
Feb 13 2023, 5:12 AM
tomek committed rCOMM5fd8f979ba02: [services][feature-flags] Set up a new Rust project (authored by tomek).
[services][feature-flags] Set up a new Rust project
Feb 13 2023, 5:12 AM
tomek added inline comments to D6687: [services][feature-flags] Introduce AWS config.
Feb 13 2023, 4:57 AM
tomek requested changes to D6685: [native] [ENG-2207] Too big notifications when the message is long.
Feb 13 2023, 4:50 AM
tomek accepted D6710: [lib][landing][web] Update to babel-loader@9.1.2.
Feb 13 2023, 4:45 AM
tomek accepted D6709: [lib][landing][web] Update to style-loader@3.3.1.
Feb 13 2023, 4:44 AM
tomek accepted D6708: [lib][landing][web] Update to css-loader@6.7.3.
Feb 13 2023, 4:42 AM
tomek accepted D6461: [web] Add a selector fetching thread IDs according to COMMUNITIES calendar filter.
Feb 13 2023, 4:41 AM

Feb 10 2023

tomek requested review of D6687: [services][feature-flags] Introduce AWS config.
Feb 10 2023, 5:45 AM
tomek accepted D6669: [native] Fixing wrong leftBorderColor on the quotes.

On both platforms all the borders are present (according to the test plan). The only difference is that all the colors on iOS look less saturated, but if we really want to address that, we should do it as a separate task.

Feb 10 2023, 2:18 AM
tomek accepted D6668: [web] Fix drawer higlight glitch.
Feb 10 2023, 2:11 AM
tomek requested changes to D6461: [web] Add a selector fetching thread IDs according to COMMUNITIES calendar filter.
Feb 10 2023, 1:10 AM

Feb 9 2023

tomek accepted D6462: [web] Add logic for displaying only chats from a given community in calendar filters.
Feb 9 2023, 8:14 AM
tomek accepted D6645: [web] Add to calendar filters reducer logic for handling the COMMUNITY filters.
Feb 9 2023, 5:42 AM
tomek requested changes to D6462: [web] Add logic for displaying only chats from a given community in calendar filters.

Overall looks good, but there are a couple of minor comments and I would like to see this code after the changes are applied.

Feb 9 2023, 4:53 AM
tomek accepted D6461: [web] Add a selector fetching thread IDs according to COMMUNITIES calendar filter.
Feb 9 2023, 4:33 AM
tomek accepted D6665: [native] Fixed crash when logging out while thread opened.

The summary can be improved a bit

checked null values in measureMessages method.

This can be replaced by more correct description, e.g.

modified measureMessages method so that it can handle the case where messages is null

Feb 9 2023, 2:45 AM

Feb 8 2023

tomek requested review of D6666: [services][feature-flags] Introduce command line arguments.
Feb 8 2023, 7:51 AM
tomek requested review of D6664: [services][feature-flags] Set up the logger.
Feb 8 2023, 4:28 AM
tomek requested review of D6663: [services][feature-flags] Set up a new Rust project.
Feb 8 2023, 3:37 AM
tomek accepted D6457: [web] Add calendar filter type for displaying only one community.
Feb 8 2023, 1:58 AM

Feb 7 2023

tomek accepted D6363: [web] Make drawer items not expandable in the calendar tab.
Feb 7 2023, 8:28 AM
tomek accepted D6346: [web] Use SettingsSwitcher and Topbar.
Feb 7 2023, 7:20 AM
tomek accepted D6160: [web] Add drawer item implementations.
Feb 7 2023, 7:14 AM
tomek accepted D6643: [11/n] Native Typeahead - SelectableTextInput for iOS.
Feb 7 2023, 7:03 AM
tomek accepted D6642: [10/n] Native Typeahead - SelectableTextInput for Android.
Feb 7 2023, 6:41 AM
tomek added 1 blocking reviewer(s) for D6641: [9/n] Native Typeahead - Introduce SelectableTextInput: przemek.
Feb 7 2023, 6:00 AM
tomek accepted D6641: [9/n] Native Typeahead - Introduce SelectableTextInput.
Feb 7 2023, 6:00 AM
tomek accepted D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
Feb 7 2023, 3:48 AM

Feb 6 2023

tomek accepted D6628: [lib] Show "just you" for thread title if there are no members besides you.
Feb 6 2023, 8:59 AM
tomek accepted D6553: [native] Cleanup of sidebar animation code.
Feb 6 2023, 8:56 AM
tomek accepted D6627: [lib] Pluralize NotifTexts.title when it's not a string.
Feb 6 2023, 8:54 AM
tomek accepted D6616: [keyserver] Fix "added username and username" issue when adding user.
Feb 6 2023, 3:45 AM