Page MenuHomePhabricator
Feed Advanced Search

Mar 15 2024

michal requested review of D11340: [web/native] Add getUserPublicKey to olmAPI.
Mar 15 2024, 10:48 AM
michal requested review of D11339: [web/native] Add content outbound session to olmAPI.
Mar 15 2024, 10:45 AM
michal requested review of D11338: [web] olmAPI on shared worker.
Mar 15 2024, 10:34 AM
michal accepted D11336: [native] Remove connection from persist black list.
Mar 15 2024, 3:48 AM

Mar 14 2024

michal requested changes to D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.

In general the code looks good but there is one major problem: if someone doesn't update their desktop app they can still run a newer version of the web app.

Mar 14 2024, 6:30 AM
michal requested changes to D11304: Refactor notifications sessions storage to support multiple keyservers on web and desktop.
Mar 14 2024, 6:25 AM
michal accepted D11290: [native][web] Expose Device List RPCs to JS.
Mar 14 2024, 6:06 AM
michal requested review of D11326: [web] Persist web sessions.
Mar 14 2024, 4:55 AM
michal accepted D11315: [lib] Refactor user reducers.
Mar 14 2024, 4:41 AM
michal requested review of D11324: [web] Move worker database globals to worker-database.js.
Mar 14 2024, 4:30 AM
michal updated the diff for D11275: [web] Add identity client shared worker proxy.

Rebase

Mar 14 2024, 4:27 AM
michal added inline comments to D11274: [web] Create identity client on shared worker.
Mar 14 2024, 4:26 AM
michal updated the diff for D11274: [web] Create identity client on shared worker.

Updated the diff to match the changes in previous diffs.

Mar 14 2024, 4:23 AM
michal updated the diff for D11272: [web] Add cryptoStore to shared worker.
  • Small fixes
  • Keep the olm runtime objects directly in memory instead of the pickled form
  • Create a new separation for olm related requests in worker request types (like in the next diffs for identity client)
  • Use the globals getters introduced in the previous diff
Mar 14 2024, 4:17 AM
michal accepted D11313: [lib] Refactor fullStateSyncActionType in reducers.
Mar 14 2024, 3:49 AM

Mar 13 2024

michal accepted D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.

If it returns empty object we should generate remove_all_integrity_thread_hashes operation - you could do it in a separate diff

Mar 13 2024, 4:20 AM
michal added inline comments to D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 13 2024, 4:11 AM
michal accepted D11310: [nix] Run set-up-authoritative-keyserver.sh on nix startup.
Mar 13 2024, 3:50 AM

Mar 12 2024

michal updated the diff for D11236: [web] Rename database worker.

Fixed comment. Also renamed the worker name from comm-app-database-${codeVersion} to comm-app-shared-worker-${codeVersion}.

Mar 12 2024, 9:51 AM
michal requested changes to D11310: [nix] Run set-up-authoritative-keyserver.sh on nix startup.
Mar 12 2024, 9:42 AM
michal accepted D11282: [keyserver] Create json files with authoritative keyserver id.
Mar 12 2024, 9:36 AM
michal accepted D11267: [keyserver] Print warnings if usingIdentityCredentials not set.
Mar 12 2024, 9:23 AM
michal accepted D11234: Implement notifications sessions storage on top of MMKV. Migrate existing notifs account to SQLite.
Mar 12 2024, 8:54 AM
michal added inline comments to D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.
Mar 12 2024, 8:31 AM
michal accepted D11302: Send keyserverID in web and desktop notifications.
Mar 12 2024, 8:24 AM
michal added a comment to D11275: [web] Add identity client shared worker proxy.

I'm also curious how expensive it might be to change the approach at this time.

Mar 12 2024, 6:33 AM

Mar 11 2024

michal requested review of D11299: [web] Handle shared worker message sequentially.
Mar 11 2024, 7:10 AM

Mar 8 2024

michal added a comment to D11274: [web] Create identity client on shared worker.

Response to the opaque URL comment:

Mar 8 2024, 7:31 AM
michal updated the diff for D11275: [web] Add identity client shared worker proxy.

@ashoat would something like this be more preferable?

Mar 8 2024, 4:56 AM

Mar 7 2024

michal requested review of D11275: [web] Add identity client shared worker proxy.
Mar 7 2024, 8:43 AM
michal requested review of D11274: [web] Create identity client on shared worker.
Mar 7 2024, 8:30 AM
michal requested review of D11273: [web] Make identity service client runnable on shared worker.
Mar 7 2024, 8:23 AM
michal requested review of D11272: [web] Add cryptoStore to shared worker.
Mar 7 2024, 8:13 AM
michal updated the diff for D11236: [web] Rename database worker.

Rebase

Mar 7 2024, 7:50 AM
michal accepted D11235: Add keyserverID to Android and iOS notification payload..
Mar 7 2024, 2:49 AM
michal accepted D11266: [services] update `Cargo.lock` files.
Mar 7 2024, 2:43 AM

Mar 6 2024

michal accepted D11257: [keyserver][native] remove cookie logic.
Mar 6 2024, 6:36 AM
michal added a comment to D11256: [identity] replace cache calls with DB client method calls.
  1. We no longer invalidate the cache. What happens if a client calls _finish method a second time?
  2. Just want to make sure: we don't have any sensitive data in WorkflowInProgress that we would prefer to keep only in-memory or sth like this?
Mar 6 2024, 6:34 AM
michal accepted D11255: [identity] db client methods to interact with workflows table.
Mar 6 2024, 6:20 AM
michal added inline comments to D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.
Mar 6 2024, 4:12 AM
michal accepted D11160: [services] derive serialize/deserialize for WorkflowInProgress enum.
Mar 6 2024, 4:10 AM
michal updated subscribers of D11234: Implement notifications sessions storage on top of MMKV. Migrate existing notifs account to SQLite.
Mar 6 2024, 3:42 AM
michal added a comment to D11235: Add keyserverID to Android and iOS notification payload..

This differential removes ashoatKeyserverID from native notifs code

Mar 6 2024, 3:29 AM
michal added inline comments to D11232: Introduce notifications crypto module to CommCoreModule.
Mar 6 2024, 3:21 AM

Mar 5 2024

michal added a comment to D11041: [backup-client] Compile to wasm.

When using binaryen from npm I was getting this error in CI:

Mar 5 2024, 6:36 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Try reverting binaryen to the apt install because of CI failure.

Mar 5 2024, 6:18 AM
michal accepted D11244: [keyserver] Transform client IDs when handling socket message.
Mar 5 2024, 6:03 AM
michal added inline comments to D11243: [CI] Clean on failure for Emscripten pipeline.
Mar 5 2024, 5:52 AM
michal planned changes to D11041: [backup-client] Compile to wasm.
Mar 5 2024, 5:16 AM
michal added inline comments to D11244: [keyserver] Transform client IDs when handling socket message.
Mar 5 2024, 5:16 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Fix script path in dockerfile

Mar 5 2024, 3:50 AM
michal added a comment to D11041: [backup-client] Compile to wasm.

I know this was discussed earlier, but can you remind me why we're taking the rust-node-addon approach here instead of the opaque-ke-wasm approach? Is it because of issues getting the CI pipeline working?

Mar 5 2024, 3:34 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Renamed the script to run-emscripten.sh, moved postinstall.sh to scripts. Added web/backup-client-wasm/target to .dockerignore.

Mar 5 2024, 3:33 AM
michal requested review of D11240: [web] Fix non-readonly types.
Mar 5 2024, 3:01 AM

Mar 4 2024

michal requested review of D11041: [backup-client] Compile to wasm.

Requesting review again because there were some changes:

Mar 4 2024, 7:37 AM
michal requested review of D11236: [web] Rename database worker.
Mar 4 2024, 7:34 AM
michal added inline comments to D11123: [web] Proxy tunnelbroker messages to the active tab.
Mar 4 2024, 6:55 AM
michal updated the diff for D11123: [web] Proxy tunnelbroker messages to the active tab.

Rebase, fix path

Mar 4 2024, 6:54 AM
michal updated the diff for D11118: [web] Only open tunnelbroker on the active tab.

Rebase

Mar 4 2024, 6:50 AM
michal updated the diff for D11114: [web] Release lock on app hot reload.

Rebase, fix issues

Mar 4 2024, 6:45 AM
michal updated the diff for D11113: [web] Introduce useWebLock.

Fix issues

Mar 4 2024, 6:43 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Fixes for keyserver docker build.

Mar 4 2024, 6:37 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

As discussed in ENG-6873 : Add a buildkite job for checking integrity of backup client wasm file, we are changing thr approach and instead of keeping the wasm file in git repo we will be building it on cleaninstall as we do with the keyserver node addon.

Mar 4 2024, 4:02 AM
michal accepted D11127: Enable SQLite database to hold two olm accounts: content and notifs.
Mar 4 2024, 3:32 AM
michal added a comment to D11230: [lib][native] Introduce supportingMultipleKeyservers constant.

is there an existing task tracking implementing backup restore for corrupt database recovery, for both native and web? I want to add a comment referencing this code in SQLiteDataHandler, to make sure it's updated as part of that task.

Mar 4 2024, 3:17 AM

Feb 28 2024

michal resigned from D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.

Resigning so I won't block landing. I don't there should be any problems with fixing the tests.

Feb 28 2024, 8:17 AM
michal abandoned D11115: [web] Check backup client wasm integrity buildkite.

Canceling this in favour of just adding another build step to cleaninstall. See discussions in ENG-6873

Feb 28 2024, 7:01 AM
michal accepted D11187: [lib] Render a socket for each keyserver.
Feb 28 2024, 6:20 AM
michal accepted D11185: [lib] Check keyserver connection in request-response-handler.
Feb 28 2024, 6:18 AM
michal accepted D11186: [lib] Move report handler from a socket.
Feb 28 2024, 6:10 AM
michal accepted D11184: [lib] Compute hashes only from one keyserver.
Feb 28 2024, 6:06 AM
michal requested changes to D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.
Feb 28 2024, 6:00 AM
michal planned changes to D11115: [web] Check backup client wasm integrity buildkite.

Sorry, I keep forgetting that for this diff, when testing CI I have to plan changes after every new revision.

Feb 28 2024, 5:44 AM

Feb 27 2024

michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Rebase

Feb 27 2024, 6:06 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Rebase

Feb 27 2024, 6:05 AM
michal updated the diff for D11123: [web] Proxy tunnelbroker messages to the active tab.

Rebase

Feb 27 2024, 6:02 AM
michal updated the diff for D11118: [web] Only open tunnelbroker on the active tab.

Rebase

Feb 27 2024, 6:02 AM
michal added a comment to D11115: [web] Check backup client wasm integrity buildkite.

Oh sorry, I forgot this was in review, sorry for the confusion. I'm having issues with generated WASM reproducibility on CI so this diff isn't ready yet and I'm still testing.

Feb 27 2024, 5:16 AM

Feb 26 2024

michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Remap paths

Feb 26 2024, 6:58 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Rebase

Feb 26 2024, 5:42 AM
michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Try cleaning before building

Feb 26 2024, 5:33 AM
michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Check that CI passes if wasm is current.

Feb 26 2024, 5:20 AM
michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Switch to two command, as I had problems with doing both builds in one command.

Feb 26 2024, 5:02 AM
michal updated the diff for D11115: [web] Check backup client wasm integrity buildkite.

Switch to one command. Check that CI fails if wasm wasn't updated.

Feb 26 2024, 3:29 AM
michal added inline comments to D10858: [native] Notify backup uploader after compaction creation.
Feb 26 2024, 3:06 AM

Feb 23 2024

michal published D11115: [web] Check backup client wasm integrity buildkite for review.
Feb 23 2024, 10:10 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Rebase

Feb 23 2024, 9:22 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Rebase

Feb 23 2024, 9:21 AM
michal updated the diff for D11039: [backup] Move authentication inside of the websocket.

Rebase

Feb 23 2024, 9:21 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Fix rebase error

Feb 23 2024, 9:15 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Rebase

Feb 23 2024, 9:07 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Rebase

Feb 23 2024, 9:04 AM
michal updated the diff for D10985: [backup client] Refactor ws creation.

Rebase

Feb 23 2024, 8:49 AM
michal updated the diff for D11041: [backup-client] Compile to wasm.

Update lock file

Feb 23 2024, 4:47 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Update lock file

Feb 23 2024, 3:54 AM
michal updated the diff for D11040: [comm lib] Add additional features.

Rebase

Feb 23 2024, 3:40 AM
michal updated the diff for D11038: [native] Download and apply logs.

Rebase

Feb 23 2024, 3:39 AM
michal updated the diff for D10859: [native] Create and upload backup compaction.

Fix comment

Feb 23 2024, 3:34 AM
michal added inline comments to D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.
Feb 23 2024, 3:28 AM
michal accepted D11111: [lib] introduce stateless `olm` API.
Feb 23 2024, 3:23 AM