Bump min code version
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 28 2025
Feb 28 2025
tomek requested review of D14425: [native] Schedule backup generation and upload after saving SIWE secrets.
bartek added inline comments to D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Shouldn't D14391 be added to the stack here? You seem to be depending on it
address feedback
Feb 27 2025
Feb 27 2025
In D14414#400577, @ashoat wrote:In D14414#400524, @bartek wrote:I'm worried about using Clipboard.setImageFromBase64 for large media files... I suspect it will be passing a massive string over the legacy React Native bridge, and so I feel obliged to do some performance testing on that, and I don't have the time to do that for an approach that I suspect might end up not working for us.
In D14414#400524, @bartek wrote:An alternative approach, that doesn't require using temporary file:
- Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
- For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
- For non-encrypted, fetch base64 but don't save to file (skip last step)
- call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116
Should we bump the version in keyserver/src/session/version.js along with this change?
bartek published D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut for review.
Invert confirmation prompt logic to make script more error-proof
I'm not entirely sure what functionality I should be testing to verify that backup-client-wasm still works correctly on web. If reviewers have any context here, please feel free to test that functionality on https://comm.software/
Feb 26 2025
Feb 26 2025
Looks great!
Reuse the code
In D14411#400429, @ashoat wrote:Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase
tomek added inline comments to D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025
Feb 25 2025
ashoat added inline comments to D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
ashoat updated the diff for D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
Feedback
ashoat added inline comments to D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
ashoat added inline comments to D14412: [native] Fall back to v1 login after `use_v1_flow` response.
Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase
Add AWS_REGION export, remove check for jq being installed
In D14411#400375, @tomek wrote:Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?