different approach that doesn't override $HOME/.my.cnf, continues to work:
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 27 2023
Sep 27 2023
ginsu added inline comments to D9286: [native] make user profiles accessible from RelationshipListItem.
• ted added inline comments to D9286: [native] make user profiles accessible from RelationshipListItem.
atul updated the diff for D9301: [keyserver] Add `$KEYSERVER_PROFILING_ENABLED` to toggle `node:cluster`.
remove extraneous condition
atul added inline comments to D9301: [keyserver] Add `$KEYSERVER_PROFILING_ENABLED` to toggle `node:cluster`.
fix
atul published D9301: [keyserver] Add `$KEYSERVER_PROFILING_ENABLED` to toggle `node:cluster` for review.
Similar to .*/node_modules/resolve/test/resolver/malformed_package_json/package\.json$ which is in the RN .flowconfig this package.json isn't actually a package.json, but rather an intentionally malformed json file used as part of some internal tests. We can just ignore it for now to appease flow.
Can you make sure CI passes before landing? It looks like you'll need to add some [ignore] lines to some .flowconfigs
Harbormaster failed remote builds in B22863: Diff 31446 for D9300: [keyserver] Introduce `0x` dependency for `keyserver` profiling!
Harbormaster failed remote builds in B22862: Diff 31445 for D9300: [keyserver] Introduce `0x` dependency for `keyserver` profiling!
atul updated the test plan for D9300: [keyserver] Introduce `0x` dependency for `keyserver` profiling.
Render Text component directly in markdown rules to avoid a bug where
message "onPress area" was smaller when chat mention with no access was
rendered
Rebase
Move hasAccessToChat to rules.react.js
Modify getMentionTypeaheadChatSuggestions
Fix typo
Sort threads by name
Store entries in a set
Remove strong tag
ashoat added inline comments to D9286: [native] make user profiles accessible from RelationshipListItem.
Let's defer landing this for a while
Sep 26 2023
Sep 26 2023
Looks good!
Let's memoize that style object (array)
Thanks for thoroughly explaining reasoning in comment
Personally would prefer to inline these conditions but it doesn't matter a ton
Add comments
ashoat updated the test plan for D9294: Introduce Brotli compression for keyserver -> client socket messages.
ashoat updated the test plan for D9294: Introduce Brotli compression for keyserver -> client socket messages.
Glad it wasn't too much overhead to use the async versions of the brotli functions
Just skimmed through, trusting CI here
Looks good, thanks for addressing feedback
ashoat added inline comments to D9294: Introduce Brotli compression for keyserver -> client socket messages.
ashoat added inline comments to D9294: Introduce Brotli compression for keyserver -> client socket messages.
ashoat updated the diff for D9294: Introduce Brotli compression for keyserver -> client socket messages.
Remove brotli.js from keyserver in favor of built-in Node.js utility from zlib library
address comments
ashoat added a comment to D9294: Introduce Brotli compression for keyserver -> client socket messages.
- It looks like Brotli is included in Zlib in (at least) Node >= 18 LTS: https://nodejs.org/dist/latest-v18.x/docs/api/zlib.html#class-brotlioptions. Would it be possible to leverage this instead of brotli.js (which doesn't seem to have a "real" commit since ~2016)?
Remove brotli.js from keyserver in favor of built-in Node.js utility from zlib library
Nice, much easier to understand at a glance
Looks good, only thing I'd change before landing is trying to avoid the one-off spacer.
ashoat added a comment to D9292: [lib] Only consider children of GENESIS when proposing existing chats.
pendingToRealizedThreadIDsSelector is used for three things:
ashoat updated the diff for D9292: [lib] Only consider children of GENESIS when proposing existing chats.
Allow SIDEBARs
Let's use existing relationshipBlockedInEitherDirection