Page MenuHomePhabricator

max (Max Kalashnikoff)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2021, 2:32 PM (173 w, 4 d)
Roles
Disabled

Recent Activity

Mar 1 2023

max added a comment to D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming.

Please make the requested edit before landing. Otherwise Flow types look good, but defer to others on Rust

Mar 1 2023, 8:33 AM
max updated the diff for D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming.

Addressing comment.

Mar 1 2023, 7:25 AM
max published D6923: [keyserver] Tunnelbroker integration - Adding Tunnelbroker publisher and connector for review.
Mar 1 2023, 6:56 AM

Feb 27 2023

max added a reviewer for D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming: bartek.
Feb 27 2023, 8:05 AM
max closed D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 27 2023, 4:23 AM
max committed rCOMM35260f3a78a9: [keyserver] Unifying API interface and adding Tunnelbroker types (authored by max).
[keyserver] Unifying API interface and adding Tunnelbroker types
Feb 27 2023, 4:23 AM
max closed D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 27 2023, 4:21 AM
max committed rCOMM70ebd47b4563: [services] Tunnelbroker - Fix calling blocking C++ function from an async task (authored by max).
[services] Tunnelbroker - Fix calling blocking C++ function from an async task
Feb 27 2023, 4:21 AM
max published D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming for review.
Feb 27 2023, 4:15 AM
max updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Rebasing on master and parent changes.

Feb 27 2023, 3:05 AM
max added a comment to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Fix Flow types and remove .default

Feb 27 2023, 3:00 AM
max closed D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.
Feb 27 2023, 12:30 AM
max committed rCOMM31a3e54aa020: [keyserver] Adding metadata to the Tunnelbroker client constructor (authored by max).
[keyserver] Adding metadata to the Tunnelbroker client constructor
Feb 27 2023, 12:30 AM
max updated the diff for D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.

Fixing commit and rebasing on master.

Feb 27 2023, 12:09 AM

Feb 26 2023

max requested review of D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 26 2023, 11:18 PM
max added inline comments to D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 26 2023, 11:17 PM

Feb 23 2023

max added a comment to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Adding @jon to take a look.

Feb 23 2023, 8:29 AM
max edited reviewers for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types, added: jon; removed: ginsu.
Feb 23 2023, 8:28 AM
max updated subscribers of D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 23 2023, 8:27 AM
max planned changes to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 23 2023, 8:14 AM
max updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Rebasing on master changes.

Feb 23 2023, 8:13 AM
max abandoned D6689: [keyserver] Refactoring rust-node-addon API names.

Abandoning this revision in a favor of D6690.

Feb 23 2023, 6:52 AM
max closed D6850: [services] Tunnelbroker - Skipping sending notif token request when notifications are off by the config flag.
Feb 23 2023, 6:39 AM
max committed rCOMM266b7425934b: [services] Tunnelbroker - Skipping sending notif token request when… (authored by max).
[services] Tunnelbroker - Skipping sending notif token request when…
Feb 23 2023, 6:39 AM
max added inline comments to D6850: [services] Tunnelbroker - Skipping sending notif token request when notifications are off by the config flag.
Feb 23 2023, 6:32 AM
max updated the diff for D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.

Rebasing on master to fix build.

Feb 23 2023, 6:26 AM
max added a comment to D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.
In D6771#202707, @varun wrote:

what is device ID in the context of tunnelbroker? just curious because we're replacing the concept of a device ID with a device public key in the Identity service

Feb 23 2023, 6:25 AM
max closed D6490: [services] Tunnelbroker - Add disable notifications config parameter.
Feb 23 2023, 6:13 AM
max committed rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter (authored by max).
[services] Tunnelbroker - Add disable notifications config parameter
Feb 23 2023, 6:13 AM
max published D6850: [services] Tunnelbroker - Skipping sending notif token request when notifications are off by the config flag for review.
Feb 23 2023, 6:11 AM
max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.

Rebasing on master and parent changes.

Feb 23 2023, 5:43 AM
max updated the diff for D6490: [services] Tunnelbroker - Add disable notifications config parameter.

Rebasing on master, parent changes and D6749 fix.

Feb 23 2023, 5:32 AM
max closed D6626: [services] Tunnelbroker - Disabling messages persistence on messages removing.
Feb 23 2023, 5:12 AM
max committed rCOMM7fa036f59002: [services] Tunnelbroker - Disabling messages persistence on messages removing (authored by max).
[services] Tunnelbroker - Disabling messages persistence on messages removing
Feb 23 2023, 5:12 AM
max closed D6625: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function.
Feb 23 2023, 5:08 AM
max committed rCOMMc7c87fa04cab: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate… (authored by max).
[services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate…
Feb 23 2023, 5:08 AM
max closed D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.
Feb 23 2023, 5:00 AM
max committed rCOMMf95747ecac53: [services] Tunnelbroker - Disabling messages persistence on messages send (authored by max).
[services] Tunnelbroker - Disabling messages persistence on messages send
Feb 23 2023, 5:00 AM
max updated the diff for D6626: [services] Tunnelbroker - Disabling messages persistence on messages removing.

Rebasing on master and parent changes.

Feb 23 2023, 4:55 AM
max updated the diff for D6625: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function.

Rebasing on master and parent changes.

Feb 23 2023, 4:52 AM
max closed D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.
Feb 23 2023, 4:48 AM
max committed rCOMM343be0ba9181: [services] Tunnelbroker - Disabling checking of the persisted messages on… (authored by max).
[services] Tunnelbroker - Disabling checking of the persisted messages on…
Feb 23 2023, 4:48 AM
max closed D6622: [services] Tunnelbroker - Disable messages persistence config parameter.
Feb 23 2023, 4:42 AM
max committed rCOMM43468c1caea8: [services] Tunnelbroker - Disable messages persistence config parameter (authored by max).
[services] Tunnelbroker - Disable messages persistence config parameter
Feb 23 2023, 4:42 AM
max updated the diff for D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.

Rebasing on master and parent changes.

Feb 23 2023, 4:41 AM
max updated the diff for D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.

Rebasing on master.

Feb 23 2023, 4:31 AM
max added inline comments to D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.
Feb 23 2023, 4:28 AM
max updated the diff for D6622: [services] Tunnelbroker - Disable messages persistence config parameter.

Rebasing on master, fixing based on D6749 changes.

Feb 23 2023, 4:23 AM
max published D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task for review.
Feb 23 2023, 4:16 AM

Feb 21 2023

max closed D6747: [services] Tunnelbroker - Disabling updating session state when session authentication is skipped.
Feb 21 2023, 3:42 PM
max committed rCOMMe0bc3f7ac53c: [services] Tunnelbroker - Disabling updating session state when session… (authored by max).
[services] Tunnelbroker - Disabling updating session state when session…
Feb 21 2023, 3:42 PM
max added inline comments to D6747: [services] Tunnelbroker - Disabling updating session state when session authentication is skipped.
Feb 21 2023, 3:41 PM
max closed D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Feb 21 2023, 11:33 AM
max committed rCOMMd21e55e6c13a: [keyserver] Adding Tunnelbroker-client napi-rs publish class method (authored by max).
[keyserver] Adding Tunnelbroker-client napi-rs publish class method
Feb 21 2023, 11:33 AM
max closed D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.
Feb 21 2023, 11:29 AM
max committed rCOMM430209fa1517: [keyserver] Adding Tunnelbroker-client napi-rs class constructor (authored by max).
[keyserver] Adding Tunnelbroker-client napi-rs class constructor
Feb 21 2023, 11:29 AM
max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.

Rebasing on master.

Feb 21 2023, 10:58 AM
max updated the diff for D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.

Rebasing on master.

Feb 21 2023, 10:53 AM
max closed D6749: [services] Tunnelbroker - Adding boolean config parameters to be used in the config file.
Feb 21 2023, 7:19 AM
max committed rCOMM28b3c262873e: [services] Tunnelbroker - Adding boolean config parameters to be used in the… (authored by max).
[services] Tunnelbroker - Adding boolean config parameters to be used in the…
Feb 21 2023, 7:19 AM
max closed D6792: [keyserver] Removing `.gitignore` from rust-node-addon.
Feb 21 2023, 6:46 AM
max committed rCOMMf1bc99677895: [keyserver] Removing `.gitignore` from rust-node-addon (authored by max).
[keyserver] Removing `.gitignore` from rust-node-addon
Feb 21 2023, 6:46 AM
max retitled D6792: [keyserver] Removing `.gitignore` from rust-node-addon from [keyserver] Removing `.gitignore` in rust-node-addon to [keyserver] Removing `.gitignore` from rust-node-addon.
Feb 21 2023, 6:08 AM
max reopened D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.

Reopening this diff due to solving ENG-3048.

Feb 21 2023, 6:06 AM
max reopened D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.

Reopening this diff due to solving ENG-3048.

Feb 21 2023, 6:06 AM
max added a reviewer for D6792: [keyserver] Removing `.gitignore` from rust-node-addon: ashoat.
Feb 21 2023, 5:52 AM
max added a comment to D6792: [keyserver] Removing `.gitignore` from rust-node-addon.
In D6792#202240, @varun wrote:

i actually prefer having separate .gitignore files at the cargo project level but it’s not a strong opinion. just think it makes the files more readable. also we already have other .gitignore files in the repo I think

Feb 21 2023, 5:52 AM
max closed D6791: [keyserver] Removing from the rust-node-addon gitignore and populate it.
Feb 21 2023, 5:48 AM
max committed rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it (authored by max).
[keyserver] Removing from the rust-node-addon gitignore and populate it
Feb 21 2023, 5:48 AM

Feb 20 2023

max published D6792: [keyserver] Removing `.gitignore` from rust-node-addon for review.
Feb 20 2023, 3:58 PM
max published D6791: [keyserver] Removing from the rust-node-addon gitignore and populate it for review.
Feb 20 2023, 3:52 PM
max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.

Fixing parent stack.

Feb 20 2023, 5:40 AM
max added inline comments to D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.
Feb 20 2023, 5:23 AM
max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.

Renaming promises.redis to promises.messageBroker.

Feb 20 2023, 5:22 AM
max retitled D6690: [keyserver] Unifying API interface and adding Tunnelbroker types from [keyserver] Adding of Tunnelbroker client type interface and getter in `rust-node-addon` index file to [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 20 2023, 5:11 AM
max planned changes to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 20 2023, 5:08 AM
max updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Fixing type file import path.

Feb 20 2023, 5:07 AM
max updated the summary of D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 20 2023, 5:04 AM
max planned changes to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Feb 20 2023, 5:01 AM
max updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.

Refactoring function to be used in any provided API, refactoring types, moving types to a separate file.

Feb 20 2023, 5:01 AM
max published D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor for review.
Feb 20 2023, 2:54 AM
max published D6770: [keyserver] Updating `yarn` scripts to run rust-node-addon build for review.
Feb 20 2023, 2:13 AM

Feb 16 2023

max published D6749: [services] Tunnelbroker - Adding boolean config parameters to be used in the config file for review.
Feb 16 2023, 7:30 AM
max published D6747: [services] Tunnelbroker - Disabling updating session state when session authentication is skipped for review.
Feb 16 2023, 7:13 AM

Feb 15 2023

max closed D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.
Feb 15 2023, 4:15 PM
max committed rCOMM044b8239d2c4: [services] Tunnelbroker - Skipping `deviceID` validation in tools function (authored by max).
[services] Tunnelbroker - Skipping `deviceID` validation in tools function
Feb 15 2023, 4:15 PM
max added inline comments to D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.
Feb 15 2023, 4:00 PM
max updated the diff for D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.

Removing logging.

Feb 15 2023, 3:54 PM
max accepted D6721: [Android] Refactor openssl code to separate file and target.
Feb 15 2023, 3:51 PM
max closed D6523: [services] Tunnelbroker - Add disable `deviceID` format validation config parameter.
Feb 15 2023, 3:24 PM
max committed rCOMM5a05f25ddd00: [services] Tunnelbroker - Add disable `deviceID` format validation config… (authored by max).
[services] Tunnelbroker - Add disable `deviceID` format validation config…
Feb 15 2023, 3:24 PM
max closed D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Feb 15 2023, 3:13 PM
max committed rCOMM7b4e9f3176d2: [keyserver] Adding Tunnelbroker-client napi-rs publish class method (authored by max).
[keyserver] Adding Tunnelbroker-client napi-rs publish class method
Feb 15 2023, 3:13 PM
max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#197482, @varun wrote:

awesome! nice job max

would you mind explaining how you avoided the mut requirement?

Feb 15 2023, 2:58 PM
max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.

Rebasing on parent.

Feb 15 2023, 2:56 PM
max closed D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.
Feb 15 2023, 2:46 PM
max committed rCOMMa1400b0cb428: [keyserver] Adding Tunnelbroker-client napi-rs class constructor (authored by max).
[keyserver] Adding Tunnelbroker-client napi-rs class constructor
Feb 15 2023, 2:46 PM
max updated the diff for D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.

Rebasing on parent changes.

Feb 15 2023, 2:25 PM
max closed D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Feb 15 2023, 2:08 PM
max committed rCOMMccb92e0486e1: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies (authored by max).
[keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies
Feb 15 2023, 2:08 PM