Page MenuHomePhabricator

[lib] Update `convertRawThreadInfoToClientDBThreadInfo` to handle `RawThreadInfo`
ClosedPublic

Authored by atul on Dec 5 2023, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 2:29 PM
Unknown Object (File)
Tue, Nov 5, 7:43 PM
Unknown Object (File)
Tue, Nov 5, 7:39 PM
Unknown Object (File)
Tue, Nov 5, 7:22 PM
Unknown Object (File)
Tue, Nov 5, 5:59 PM
Unknown Object (File)
Oct 15 2024, 11:52 PM
Unknown Object (File)
Oct 15 2024, 11:52 PM
Unknown Object (File)
Oct 15 2024, 11:52 PM
Subscribers
None

Details

Summary

Basically modify function to pull out minimallyEncoded field before converting to ClientDBThreadInfo representation. This is fine because all of the columns in the SQLite database are compatible with the new "shape" of the data here.

Unfortunately, we can't do this as easily with convertClientDBThreadInfoToRawThreadInfo because it's used as part of migrations so we don't want to change the behavior of those migrations for users upgrading from an older version. Will have to create a "legacy" version of that function so migration functionality is retained.


Depends on D10197

Test Plan

CI/flow/etc

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Dec 5 2023, 12:55 PM

Yeah, we'll need to think through migrations carefully. We'll also need to migrate all of the data in SQLite from the old format to the new, right?

This revision is now accepted and ready to land.Dec 5 2023, 7:35 PM

rebase and land noop refactors

Yeah, we'll need to think through migrations carefully. We'll also need to migrate all of the data in SQLite from the old format to the new, right?

Yeah there's a Redux migration later in the stack that handles this