Page MenuHomePhabricator
Differential D10211

[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`
ClosedPublic
Actions

Authored by atul on Dec 6 2023, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:51 PM
Unknown Object (File)
Tue, Oct 15, 11:51 PM
View All 84 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMc8c3cea3fb65: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync…
rCOMM77cc67c2c532: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync…
Summary

Introduce validator that can handle both LegacyRawThreadInfo and MinimallyEncodedRawThreadInfo because keyserver will be handling both.

Updated validator was required to update threads-state-sync-spec which will allow us to update rest of thread update/thread "ops" code.

Depends on D10210

Test Plan

Flow/CI/validator will fail during testing if not defined correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 6 2023, 2:42 PM
atul published this revision for review.Dec 6 2023, 2:43 PM
Harbormaster completed remote builds in B24836: Diff 34358.Dec 6 2023, 3:00 PM
atul added a child revision: D10212: [lib] Update `Role[Deletion/Modification][Payload/Result]` to handle `RawThreadInfo`.Dec 6 2023, 3:08 PM
tomek accepted this revision.Dec 7 2023, 6:53 AM
This revision is now accepted and ready to land.Dec 7 2023, 6:53 AM
ashoat added inline comments.Dec 8 2023, 2:29 PM
lib/permissions/minimally-encoded-thread-permissions-validators.js
1 ↗(On Diff #34358)

Can you add a newline after the Flow declaration here

atul updated this revision to Diff 34467.Dec 10 2023, 7:33 PM

newline after @flow AND fix TUnion import

Harbormaster completed remote builds in B24933: Diff 34467.Dec 10 2023, 7:50 PM
Closed by commit rCOMM77cc67c2c532: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync… (authored by atul). · Explain WhyDec 12 2023, 7:52 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM77cc67c2c532: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync….
atul added a reverting change: rCOMMd18296d7f320: Revert "[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state….Dec 12 2023, 8:08 PM
atul reopened this revision.Dec 12 2023, 8:09 PM
This revision is now accepted and ready to land.Dec 12 2023, 8:09 PM
atul updated this revision to Diff 34572.Dec 13 2023, 12:47 PM

fix up and re-land

atul updated this revision to Diff 34573.Dec 13 2023, 12:48 PM

re-land

This revision was landed with ongoing or failed builds.Dec 13 2023, 12:51 PM
Closed by commit rCOMMc8c3cea3fb65: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc8c3cea3fb65: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync….
Harbormaster completed remote builds in B25024: Diff 34572.Dec 13 2023, 1:05 PM
Harbormaster completed remote builds in B25025: Diff 34573.Dec 13 2023, 1:07 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
shared/
state-sync/
10 lines
lib/
permissions/
9 lines
types/
3 lines

Diff 34574

View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...
View Options

lib/types/thread-types.js

Loading...