Paths

Table of Contentst

Differential D10243

[lib] Update `lib/types` to accomodate `RawThreadInfos`
ClosedPublic
Actions

Authored by atul on Dec 7 2023, 6:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 17, 8:05 AM

	Unknown Object (File)
	Thu, Oct 17, 7:44 AM

	Unknown Object (File)
	Tue, Oct 15, 8:50 PM

	Unknown Object (File)
	Tue, Oct 15, 8:50 PM

	Unknown Object (File)
	Sep 16 2024, 1:59 PM

	Unknown Object (File)
	Sep 16 2024, 1:59 PM

	Unknown Object (File)
	Sep 16 2024, 1:59 PM

	Unknown Object (File)
	Sep 16 2024, 1:59 PM

View All 63 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMaf5c27550278: [lib] Update `lib/types` to accomodate `RawThreadInfos`

Summary

Update types that used LegacyRawThreadInfos to now use RawThreadInfos which is LegacyRawThreadInfos | MinimallyEncodedRawThreadInfos.

NOTE: CI is expected to fail. I got to a point in my local environment where all flow issues were resolved, but based on earlier fedback in the stack I'm breaking them down so things are easier to review.. even if that means that intermediate steps fail.

Depends on D10235

Test Plan

Flow/CI AT END OF STACK + thorough testing of keyserver and native client.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 7 2023, 6:53 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2023, 7:04 PM

Harbormaster failed remote builds in B24877: Diff 34401!

atul requested review of this revision.Dec 8 2023, 9:47 AM

atul added a child revision: D10268: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`.Dec 8 2023, 11:49 AM

ginsu accepted this revision.Dec 8 2023, 11:51 AM

This revision is now accepted and ready to land.Dec 8 2023, 11:51 AM

final rebase pass

Harbormaster failed remote builds in B25040: Diff 34600!Dec 13 2023, 2:51 PM

This revision was landed with ongoing or failed builds.Dec 14 2023, 12:48 PM

Closed by commit rCOMMaf5c27550278: [lib] Update `lib/types` to accomodate `RawThreadInfos` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaf5c27550278: [lib] Update `lib/types` to accomodate `RawThreadInfos`.

Revision Contents
Changeset List

Path

Size

lib/

types/

account-types.js

10 lines

request-types.js

6 lines

session-types.js

6 lines

socket-types.js

4 lines

thread-types.js

5 lines

update-types.js

6 lines

Diff 34600

lib/types/account-types.js

Loading...

lib/types/request-types.js

Loading...

lib/types/session-types.js

Loading...

lib/types/socket-types.js

Loading...

lib/types/thread-types.js

Loading...

lib/types/update-types.js

Loading...