Page MenuHomePhabricator

[lib] Add ridiculous branching to `delete-account-spec` to appease `flow`
ClosedPublic

Authored by atul on Dec 8 2023, 11:58 AM.
Tags
None
Referenced Files
F1927676: D10270.diff
Sat, Jun 1, 6:14 PM
Unknown Object (File)
Sun, May 26, 4:17 AM
Unknown Object (File)
Thu, May 23, 12:44 PM
Unknown Object (File)
Wed, May 22, 9:12 AM
Unknown Object (File)
Mon, May 20, 3:39 AM
Unknown Object (File)
Mon, May 20, 3:39 AM
Unknown Object (File)
Mon, May 20, 3:39 AM
Unknown Object (File)
Mon, May 20, 3:39 AM
Subscribers
None

Details

Summary

I'm completely aware that the amount of branching and repetition here is ridiculous. This is just to help us get towards 0 flow issues, at which point I will definitely come back and do noop refactors to tidy these up.

NOTE: CI is expected to fail. I got to a point in my local environment where all flow issues were resolved, but based on earlier fedback in the stack I'm breaking them down so things are easier to review.. even if that means that intermediate steps fail.

[skip-ci]


Depends on D10268

Test Plan

Flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24913
Build 216813: arc lint + arc unit