Implemented method to creating olm session.
Depends on D10374
Details
Details
This code is really hard to test as it's impossible to verify partial results.
I generated some keys and values, verified them with olm-utils.test.js, and checked if they succeeded/failed when calling the method introduced here in the same cases as JS tests.
Full functionality tested later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 753 ↗ | (On Diff #34789) | this probably could be defined in a different place |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 756 ↗ | (On Diff #34789) | Looks like this call is is not blocking execution of the code below. What happens if persistOlmAccount fails and rejects the promise but we were able to resolve it to a correct value first? If the rejection after resolution is ignored then it is a bug and we want to avoid it. Simplest solution would be to block on successful persistence completion. Alternatively I am wondering if we could return two promises one for crypto and the other for persistence and make JS await them in parallel. However I might be wrong and the code above is actually correct. If you justify that there is no risk of an ignored error I will accept the revision. |