Page MenuHomePhabricator
Differential D10380

[native] implement accepting `olm` session
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 5:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 8:35 AM
Unknown Object (File)
Mar 7 2025, 12:43 AM
Unknown Object (File)
Mar 5 2025, 2:55 PM
Unknown Object (File)
Mar 5 2025, 8:05 AM
Unknown Object (File)
Mar 4 2025, 3:40 PM
Unknown Object (File)
Feb 20 2025, 6:28 PM
Unknown Object (File)
Feb 20 2025, 6:28 PM
Unknown Object (File)
Feb 20 2025, 6:28 PM
View All 89 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMMf0890b14c438: [native] implement accepting `olm` session
Summary

Code which receive response from Tunnelbroker with session creation request, calls Identity to get Inbound keys and creates session.

Depends on D10379

Test Plan

Call this method and verify result

Diff Detail

Repository
rCOMM Comm
Branch
publish-olm-stack-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 5:49 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 5:49 AM
kamil added a child revision: D10381: [native] implement creating `olm` session with own devices.Dec 18 2023, 5:50 AM
kamil published this revision for review.Dec 18 2023, 6:54 AM
Harbormaster failed remote builds in B25179: Diff 34794!Dec 18 2023, 7:20 AM
ashoat added inline comments.Dec 18 2023, 11:08 AM
native/utils/crypto-utils.js
63 ↗(On Diff #34794)

Can you split this string so the lines stay to 80 char width?

marcin accepted this revision.Jan 4 2024, 3:39 AM

This diff looks fine in terms of the inbound session creation itself. Wondering what is our approach to handle session creation failure.

native/handlers/peer-to-peer-message-handler.js
20 ↗(On Diff #34794)

Do we have a plan to inform the other peer that we failed to create inbound session? Alternatively is there a mechanism that will prevent them from sending us encrypted messages we won't be able to decrypt?

This revision is now accepted and ready to land.Jan 4 2024, 3:39 AM
kamil updated this revision to Diff 35420.Jan 9 2024, 1:55 AM

make lines 80 char width

native/handlers/peer-to-peer-message-handler.js
20 ↗(On Diff #34794)

yes, it's described in here - that's the place when this client should inform other peers about a failure, ask for a new session and re-send all messages

Harbormaster completed remote builds in B25621: Diff 35420.Jan 9 2024, 2:20 AM
Closed by commit rCOMMf0890b14c438: [native] implement accepting `olm` session (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf0890b14c438: [native] implement accepting `olm` session.

Revision Contents
Changeset List

PathSize
native/
handlers/
15 lines
utils/
61 lines

Diff 35420

View Options

native/handlers/peer-to-peer-message-handler.js

Show All 13 Lines
import androidx.core.app.NotificationCompat; import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle; import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner; import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager; import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils; import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity; import app.comm.android.MainActivity;
import app.comm.android.R; import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat; import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient; import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV; import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities; import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule; import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule; import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils; import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations; import app.comm.android.fbjni.ThreadOperations;
Show All 33 Linespublic class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match // Those and future MMKV-related constants should match
// similar constants in NotificationService.mm // similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = "."; private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER"; private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT"; private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon; private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager; private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager; private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient; private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule; private AESCryptoModuleCompat aesCryptoModule;
public static final String RESCIND_KEY = "rescind"; public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID"; public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title"; public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix"; public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body"; public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos"; public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID"; public static final String THREAD_ID_KEY = "threadID";
public static final String TOKEN_EVENT = "TOKEN_EVENT"; public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT"; public static final String MESSAGE_EVENT = "MESSAGE_EVENT";
@Override @Override
public void onCreate() { public void onCreate() {
super.onCreate(); super.onCreate();
CommSecureStore.getInstance().initialize( CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext())); ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService( notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE); Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this); localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource( displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher); this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient(); servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat(); aesCryptoModule = new AESCryptoModuleCompat();
} }
@Override @Override
public void onNewToken(String token) { public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT); Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token); intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent); localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification"); Log.w("COMM", "Database not existing yet. Skipping notification");
} }
} }
private void handleLargeNotification(RemoteMessage message) { private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY); String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY); String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try { try {
byte[] largePayload = blobClient.getBlobSync(blobHash); byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload); message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message); handleMessageInfosPersistence(message);
} catch (Exception e) { } catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e); Log.w("COMM", "Failure when handling large notification.", e);
} }
blobClient.scheduleDeferredBlobDeletion( servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext()); blobHash, blobHolder, this.getApplicationContext());
} }
private void addToThreadGroupAndDisplay( private void addToThreadGroupAndDisplay(
String notificationID, String notificationID,
NotificationCompat.Builder notificationBuilder, NotificationCompat.Builder notificationBuilder,
String threadID) { String threadID) {
▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines
View Options

native/utils/crypto-utils.js

Show All 13 Lines
import androidx.core.app.NotificationCompat; import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle; import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner; import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager; import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils; import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity; import app.comm.android.MainActivity;
import app.comm.android.R; import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat; import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient; import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV; import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities; import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule; import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule; import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils; import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations; import app.comm.android.fbjni.ThreadOperations;
Show All 33 Linespublic class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match // Those and future MMKV-related constants should match
// similar constants in NotificationService.mm // similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = "."; private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER"; private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT"; private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon; private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager; private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager; private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient; private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule; private AESCryptoModuleCompat aesCryptoModule;
public static final String RESCIND_KEY = "rescind"; public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID"; public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title"; public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix"; public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body"; public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos"; public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID"; public static final String THREAD_ID_KEY = "threadID";
public static final String TOKEN_EVENT = "TOKEN_EVENT"; public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT"; public static final String MESSAGE_EVENT = "MESSAGE_EVENT";
@Override @Override
public void onCreate() { public void onCreate() {
super.onCreate(); super.onCreate();
CommSecureStore.getInstance().initialize( CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext())); ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService( notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE); Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this); localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource( displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher); this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient(); servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat(); aesCryptoModule = new AESCryptoModuleCompat();
} }
@Override @Override
public void onNewToken(String token) { public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT); Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token); intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent); localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification"); Log.w("COMM", "Database not existing yet. Skipping notification");
} }
} }
private void handleLargeNotification(RemoteMessage message) { private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY); String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY); String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try { try {
byte[] largePayload = blobClient.getBlobSync(blobHash); byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload); message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message); handleMessageInfosPersistence(message);
} catch (Exception e) { } catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e); Log.w("COMM", "Failure when handling large notification.", e);
} }
blobClient.scheduleDeferredBlobDeletion( servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext()); blobHash, blobHolder, this.getApplicationContext());
} }
private void addToThreadGroupAndDisplay( private void addToThreadGroupAndDisplay(
String notificationID, String notificationID,
NotificationCompat.Builder notificationBuilder, NotificationCompat.Builder notificationBuilder,
String threadID) { String threadID) {
▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines