[native] initialize crypto account before any crypto-related operation
ClosedPublic
Actions

Authored by kamil on Jan 10 2024, 7:12 AM.

Details

Reviewers

marcin
michal
varun

Commits

rCOMM0e78e4efe821: [native] initialize crypto account before any crypto-related operation

Summary

The entire stack worked fine because of D10327, adding this to make sure the crypto thread is always present.

Created ENG-6419 to discuss alternatives.

Depends on D10526

Test Plan

Make sure app does not crash with recent changes

Diff Detail

Repository

rCOMM Comm

Branch

publish-olm-stack-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 10 2024, 7:12 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 10 2024, 7:12 AM

kamil published this revision for review.Jan 10 2024, 7:33 AM

kamil edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B25672: Diff 35495.Jan 10 2024, 7:37 AM

I think this approach is inefficient. Here is my suggestion: https://linear.app/comm/issue/ENG-6419/initialize-crypto-account-on-native#comment-07e9238a

In D10594#306739, @marcin wrote:

I think this approach is inefficient. Here is my suggestion: https://linear.app/comm/issue/ENG-6419/initialize-crypto-account-on-native#comment-07e9238a

Can we, for now, follow the existing convention to unblock my stack, discuss the best solution, and implement it in ENG-6419?

Accepting since this diff works and it will unblock @kamil but it would be nice if someone implemented the right approach in February as a small project since it doesn't seem to be too much of a hassle.

This revision is now accepted and ready to land.Jan 11 2024, 4:22 AM

Closed by commit rCOMM0e78e4efe821: [native] initialize crypto account before any crypto-related operation (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0e78e4efe821: [native] initialize crypto account before any crypto-related operation.