Details
- See that specialRole field is missing before:
- See that specialRole field is present after:
Add logging to migration to ensure that specialRole field is included and correctly formed:
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D11188_2 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Question inline about updating version field
| web/redux/persist.js | ||
|---|---|---|
| 363 ↗ | (On Diff #37663) | Should this be updated too? |
Version will be bumped in "flip the switch" diff. native, web, and keyserver all need to be updated at the same time as a release.
| web/redux/persist.js | ||
|---|---|---|
| 315 ↗ | (On Diff #37663) | Does the returned state contain threads that are already "patched"? |
| web/redux/persist.js | ||
|---|---|---|
| 315 ↗ | (On Diff #37663) | I don't think there are any threads in state which is a result of migration (threads are blacklisted) |
| web/redux/persist.js | ||
|---|---|---|
| 363 ↗ | (On Diff #37663) | Gets bumped in "Flip the switch" diff |
Looks like eg await databaseModule.isDatabaseSupported(); are no longer available, so this migration will need to be updated.
Will defer this until after hackathon since IMO that's probably higher priority right now.
| web/redux/persist.js | ||
|---|---|---|
| 462 ↗ | (On Diff #39351) | Will update similarly to migration 16 to address feedback about avoiding invariants. |
| keyserver/src/version.js | ||
|---|---|---|
| 3 ↗ | (On Diff #39351) | Why do you need to bump this? We typically bump the web version in web/app.react.js in tandem |
| keyserver/src/version.js | ||
|---|---|---|
| 3 ↗ | (On Diff #39351) | For the minCodeVersion check in rawThreadInfosFromServerThreadInfos. Will update this diff to bump in app.react.js and remove invariants from migration before landing |
replace invariant in migration with null/undefined check, will re-test before landing
