[lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 9:42 PM.

Details

Reviewers

ginsu
tomek
kamil
michal

Commits

rCOMM531b65b66af4: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`

Summary

We update the existing patchRoleInfoWithSpecialRole utility used in the client migration to strip out the isDefault field from RoleInfo. It makes sense to include specialRole and exclude isDefault at the same time.

Depends on D11253

Test Plan

Re-run migration on web and native

Make sure all RoleInfos have the specialRole field included (can be null, but must be included)
Make sure all RoleInfos have the isDefault field removed.
Look at keyserver logIn response payload and ensure that specialRole IS included and isDefault ISN'T included

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:42 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:42 PM

Harbormaster completed remote builds in B27352: Diff 37874.Mar 5 2024, 10:00 PM

atul requested review of this revision.Mar 5 2024, 10:00 PM

This migration wasn't already applied, right?

This revision is now accepted and ready to land.Mar 6 2024, 4:31 AM

atul added a child revision: D11261: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`.Mar 6 2024, 2:11 PM

In D11254#325066, @tomek wrote:

This migration wasn't already applied, right?

No, it's consumed by migration D11099/D11188 which haven't been landed yet. Those will be landed alongside "flip the switch" diff after re-arranging stack.