Page MenuHomePhabricator
Differential D11254

[lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 11:14 PM
Unknown Object (File)
Feb 22 2025, 1:31 AM
Unknown Object (File)
Feb 22 2025, 1:31 AM
Unknown Object (File)
Feb 22 2025, 1:31 AM
Unknown Object (File)
Feb 22 2025, 1:31 AM
Unknown Object (File)
Feb 22 2025, 1:31 AM
Unknown Object (File)
Feb 16 2025, 10:21 AM
Unknown Object (File)
Feb 15 2025, 5:33 AM
View All 89 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
kamil
michal
Commits
rCOMM531b65b66af4: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`
Summary

We update the existing patchRoleInfoWithSpecialRole utility used in the client migration to strip out the isDefault field from RoleInfo. It makes sense to include specialRole and exclude isDefault at the same time.

Depends on D11253

Test Plan

Re-run migration on web and native

  1. Make sure all RoleInfos have the specialRole field included (can be null, but must be included)
  2. Make sure all RoleInfos have the isDefault field removed.
  3. Look at keyserver logIn response payload and ensure that specialRole IS included and isDefault ISN'T included

Diff Detail

Repository
rCOMM Comm
Branch
updatePatchFunc (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:42 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:42 PM
Harbormaster completed remote builds in B27352: Diff 37874.Mar 5 2024, 10:00 PM
atul requested review of this revision.Mar 5 2024, 10:00 PM
tomek accepted this revision.Mar 6 2024, 4:31 AM

This migration wasn't already applied, right?

This revision is now accepted and ready to land.Mar 6 2024, 4:31 AM
atul added a child revision: D11261: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`.Mar 6 2024, 2:11 PM
atul added a comment.Mar 19 2024, 11:38 AM
In D11254#325066, @tomek wrote:

This migration wasn't already applied, right?

No, it's consumed by migration D11099/D11188 which haven't been landed yet. Those will be landed alongside "flip the switch" diff after re-arranging stack.

atul updated this revision to Diff 38229.Mar 20 2024, 10:50 AM

land

This revision was landed with ongoing or failed builds.Mar 20 2024, 11:03 AM
Closed by commit rCOMM531b65b66af4: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM531b65b66af4: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`.
Harbormaster completed remote builds in B27627: Diff 38229.Mar 20 2024, 11:19 AM

Revision Contents
Changeset List

PathSize
lib/
permissions/
14 lines
4 lines

Diff 38229

View Options

lib/permissions/special-roles.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunction useFetchEntries(): (
calendarQuery: CalendarQuery, calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> { ) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries); return useKeyserverCall(fetchEntries);
} }
export type UpdateCalendarQueryInput = { export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean, +reduxAlreadyUpdated?: boolean,
+keyserverIDs?: $ReadOnlyArray<string>,
}; };
const updateCalendarQueryActionTypes = Object.freeze({ const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED', started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS', success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED', failed: 'UPDATE_CALENDAR_QUERY_FAILED',
}); });
const updateCalendarQuery = const updateCalendarQuery =
( (
callKeyserverEndpoint: CallKeyserverEndpoint, callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>, allKeyserverIDs: $ReadOnlyArray<string>,
): (( ): ((
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) => ) => Promise<CalendarQueryUpdateResult>) =>
async input => { async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input; const { calendarQuery, reduxAlreadyUpdated = false } = input;
const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;
const calendarQueries = sortCalendarQueryPerKeyserver( const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery, calendarQuery,
allKeyserverIDs, keyserverIDs,
); );
const requests: { [string]: CalendarQuery } = {}; const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) { for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID]; requests[keyserverID] = calendarQueries[keyserverID];
} }
const responses = await callKeyserverEndpoint( const responses = await callKeyserverEndpoint(
'update_calendar_query', 'update_calendar_query',
requests, requests,
); );
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = []; let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = []; let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) { for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat( rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos, responses[keyserverID].rawEntryInfos,
); );
deletedEntryIDs = deletedEntryIDs.concat( deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs, responses[keyserverID].deletedEntryIDs,
); );
} }
return { return {
rawEntryInfos, rawEntryInfos,
deletedEntryIDs, deletedEntryIDs,
calendarQuery, calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated, calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
keyserverIDs,
}; };
}; };
function useUpdateCalendarQuery(): ( function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> { ) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery); return useKeyserverCall(updateCalendarQuery);
} }
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

lib/permissions/special-roles.test.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunction useFetchEntries(): (
calendarQuery: CalendarQuery, calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> { ) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries); return useKeyserverCall(fetchEntries);
} }
export type UpdateCalendarQueryInput = { export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean, +reduxAlreadyUpdated?: boolean,
+keyserverIDs?: $ReadOnlyArray<string>,
}; };
const updateCalendarQueryActionTypes = Object.freeze({ const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED', started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS', success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED', failed: 'UPDATE_CALENDAR_QUERY_FAILED',
}); });
const updateCalendarQuery = const updateCalendarQuery =
( (
callKeyserverEndpoint: CallKeyserverEndpoint, callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>, allKeyserverIDs: $ReadOnlyArray<string>,
): (( ): ((
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) => ) => Promise<CalendarQueryUpdateResult>) =>
async input => { async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input; const { calendarQuery, reduxAlreadyUpdated = false } = input;
const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;
const calendarQueries = sortCalendarQueryPerKeyserver( const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery, calendarQuery,
allKeyserverIDs, keyserverIDs,
); );
const requests: { [string]: CalendarQuery } = {}; const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) { for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID]; requests[keyserverID] = calendarQueries[keyserverID];
} }
const responses = await callKeyserverEndpoint( const responses = await callKeyserverEndpoint(
'update_calendar_query', 'update_calendar_query',
requests, requests,
); );
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = []; let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = []; let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) { for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat( rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos, responses[keyserverID].rawEntryInfos,
); );
deletedEntryIDs = deletedEntryIDs.concat( deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs, responses[keyserverID].deletedEntryIDs,
); );
} }
return { return {
rawEntryInfos, rawEntryInfos,
deletedEntryIDs, deletedEntryIDs,
calendarQuery, calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated, calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
keyserverIDs,
}; };
}; };
function useUpdateCalendarQuery(): ( function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> { ) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery); return useKeyserverCall(updateCalendarQuery);
} }
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines