This differential implements full notifications structure generation on the client.
Details
Details
- Apply this patch
- Send message from native device
- Examin the console output.
Shortly I will make this test plan more extensive to test all notif types.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8282
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/push/send-utils.js | ||
---|---|---|
547–551 ↗ | (On Diff #41569) | In general, we have a rule in codebase that await should always be either the first keyword in a statement, or the first keyword on the right hand side of an assignment |
lib/push/send-utils.js | ||
---|---|---|
547–551 ↗ | (On Diff #41569) |
This can't be done since we would sequentially await in a loop.
This can be done by first assigning promise result to a variable and then filtering, but still keeping operations inside (async () => {})() |