issue: ENG-8617
A handler will display one tip, then pressing on ok will navigate to the next tip and so on. So we need to be able to provide each tip with coordinates and params for the next tip.
We will do this like so: route.params will include a tipKey, and the tip will fetch its coordinates from the context. It will also use this getTipCallbackParams function to get params for the next tip it has to navigate to.
Details
Details
Tested with later diffs - tested that this solution works and it is possible to navigate to next tips
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
native/components/nux-tips-context.react.js | ||
---|---|---|
16 ↗ | (On Diff #43376) | Why is it called CallbackParams? Can we find a less implementation-specific name? Also, we can consider including a tip text in this object. |
native/components/nux-tips-context.react.js | ||
---|---|---|
16 ↗ | (On Diff #43376) | It doesn't make sense to include text here because we are passing the button to createNUXTipsOverlay anyway, and text directly depends on the button |