Page MenuHomePhabricator
Differential D13118

[native] Rename RegistrationButton
ClosedPublic
Actions

Authored by inka on Aug 20 2024, 12:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 9:31 PM
Unknown Object (File)
Nov 13 2024, 8:44 PM
Unknown Object (File)
Nov 9 2024, 9:47 PM
Unknown Object (File)
Nov 9 2024, 8:46 PM
Unknown Object (File)
Nov 8 2024, 2:08 AM
Unknown Object (File)
Nov 8 2024, 2:08 AM
Unknown Object (File)
Nov 8 2024, 2:08 AM
Unknown Object (File)
Nov 8 2024, 2:08 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMb8e622562734: [native] Rename RegistrationButton
Summary

Addressing review from D13080

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 20 2024, 12:33 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 20 2024, 12:33 AM
inka added a parent revision: D13079: [native] Fetch coordinates from context in nux tips overlay.Aug 20 2024, 12:33 AM
inka added a child revision: D13080: [native] Add <next> button to nux tips.
Harbormaster completed remote builds in B31156: Diff 43471.Aug 20 2024, 12:50 AM
inka requested review of this revision.Aug 20 2024, 12:50 AM
tomek accepted this revision.Aug 20 2024, 1:24 AM
tomek added inline comments.
native/components/loading-button.react.js
14 ↗(On Diff #43471)

I'm wondering if this name can be improved. Why is it called loading? Maybe we can make this less specific and call it primary? What do you think? Does it make sense?

This revision is now accepted and ready to land.Aug 20 2024, 1:24 AM
inka updated this revision to Diff 43489.Aug 20 2024, 2:55 AM

Rename

Harbormaster completed remote builds in B31163: Diff 43489.Aug 20 2024, 3:14 AM
Closed by commit rCOMMb8e622562734: [native] Rename RegistrationButton (authored by inka). · Explain WhyAug 21 2024, 12:07 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMb8e622562734: [native] Rename RegistrationButton.

Revision Contents
Changeset List

Diff 43489

View Options

native/account/registration/account-does-not-exist.react.js

Loading...
View Options

native/account/registration/avatar-selection.react.js

Loading...
View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/cool-or-nerd-mode-selection.react.js

Loading...
View Options

native/account/registration/existing-ethereum-account.react.js

Loading...
View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/password-selection.react.js

Loading...
View Options

native/account/registration/registration-button.react.js

Loading...
View Options

native/account/registration/registration-terms.react.js

Loading...
View Options

native/account/registration/siwe-backup-message-creation.react.js

Loading...
View Options

native/account/registration/username-selection.react.js

Loading...
View Options

native/community-creation/community-configuration.react.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...
View Options

native/components/connect-farcaster-bottom-sheet.react.js

Loading...
View Options

native/components/primary-button.react.js

Loading...
View Options

native/profile/farcaster-account-settings.react.js

Loading...